[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790883#comment-17790883 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert merged PR #2001: URL: ht

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert merged PR #2001: URL: https://github.com/apache/groovy/pull/2001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790857#comment-17790857 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert commented on PR #2001: U

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert commented on PR #2001: URL: https://github.com/apache/groovy/pull/2001#issuecomment-1831068762 > I have all these changes together locally if you'd like me to push a branch or commit. I've included some of them with tweaks. I'll merge when ready but feel free to amend fur

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790853#comment-17790853 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert commented on code in PR

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790852#comment-17790852 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert commented on code in PR

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert commented on code in PR #2001: URL: https://github.com/apache/groovy/pull/2001#discussion_r1408619139 ## src/test/groovy/InterfaceTest.groovy: ## @@ -91,4 +91,19 @@ final class InterfaceTest extends CompilableTestSupport { assert impl2.foo() == 'hello fr

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790849#comment-17790849 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert commented on code in PR

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert commented on code in PR #2001: URL: https://github.com/apache/groovy/pull/2001#discussion_r1408619048 ## src/main/java/org/codehaus/groovy/classgen/ClassCompletionVerifier.java: ## @@ -418,10 +418,6 @@ private void checkMethodsForIncorrectModifiers(final ClassNode c

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert commented on code in PR #2001: URL: https://github.com/apache/groovy/pull/2001#discussion_r1408618851 ## src/main/java/org/codehaus/groovy/classgen/ClassCompletionVerifier.java: ## @@ -418,10 +418,6 @@ private void checkMethodsForIncorrectModifiers(final ClassNode c

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790837#comment-17790837 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert commented on PR #2001: U

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert commented on PR #2001: URL: https://github.com/apache/groovy/pull/2001#issuecomment-1831026189 > With static method support so close at hand, did you think of re-rolling 5.0.0-alpha-3? Let's go with the current release and shoot for another before the end of the year. -

[jira] [Updated] (GROOVY-11240) Tweak cleanup DFA cache of parser

2023-11-28 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11240: Description: We should keep the DFA cache as long as possible for better parsing performance, bu

[jira] [Resolved] (GROOVY-11230) ProxyGenerator creates a lot of AtomicReference instances regardless of "groovy.adapter.cache.default.size" setting

2023-11-28 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-11230. -- Fix Version/s: 5.0.0-alpha-3 Resolution: Fixed > ProxyGenerator creates a lot of Atomi

[jira] [Resolved] (GROOVY-11238) Logical implication operator revisited

2023-11-28 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-11238. Resolution: Fixed > Logical implication operator revisited >

[jira] [Updated] (GROOVY-11238) Logical implication operator revisited

2023-11-28 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-11238: --- Fix Version/s: 5.0.0-alpha-4 (was: 5.x) > Logical implication operator revis

[jira] [Commented] (GROOVY-11238) Logical implication operator revisited

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790785#comment-17790785 ] ASF GitHub Bot commented on GROOVY-11238: - paulk-asert merged PR #1999: URL: ht

Re: [PR] GROOVY-11238: Logical implication operator revisited [groovy]

2023-11-28 Thread via GitHub
paulk-asert merged PR #1999: URL: https://github.com/apache/groovy/pull/1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790762#comment-17790762 ] ASF GitHub Bot commented on GROOVY-11237: - eric-milles commented on PR #2001: U

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
eric-milles commented on PR #2001: URL: https://github.com/apache/groovy/pull/2001#issuecomment-1830768443 I have all these changes together locally if you'd like me to push a branch or commit. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790749#comment-17790749 ] ASF GitHub Bot commented on GROOVY-11237: - eric-milles commented on PR #2001: U

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
eric-milles commented on PR #2001: URL: https://github.com/apache/groovy/pull/2001#issuecomment-1830732529 With static method support so close at hand, did you think of re-rolling 5.0.0-alpha-3? -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790748#comment-17790748 ] ASF GitHub Bot commented on GROOVY-11237: - eric-milles commented on code in PR

Re: [PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
eric-milles commented on code in PR #2001: URL: https://github.com/apache/groovy/pull/2001#discussion_r1408404532 ## src/test/groovy/InterfaceTest.groovy: ## @@ -91,4 +91,19 @@ final class InterfaceTest extends CompilableTestSupport { assert impl2.foo() == 'hello fr

[jira] [Updated] (GROOVY-8948) BigDecimal to primitive conversion not working

2023-11-28 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-8948: Fix Version/s: 3.0.20 4.0.16 > BigDecimal to primitive conversion not working >

[jira] [Commented] (GROOVY-11240) Tweak cleanup DFA cache of parser

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790671#comment-17790671 ] ASF GitHub Bot commented on GROOVY-11240: - daniellansun opened a new pull reque

[jira] [Updated] (GROOVY-11240) Tweak cleanup DFA cache of parser

2023-11-28 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun updated GROOVY-11240: Description: We should keep the DFA cache as possible as we could for better parsing performance

[jira] [Created] (GROOVY-11240) Tweak cleanup DFA cache of parser

2023-11-28 Thread Daniel Sun (Jira)
Daniel Sun created GROOVY-11240: --- Summary: Tweak cleanup DFA cache of parser Key: GROOVY-11240 URL: https://issues.apache.org/jira/browse/GROOVY-11240 Project: Groovy Issue Type: Improvement

[jira] [Updated] (GROOVY-11239) VerifyError for explicit this parameter and default argument(s)

2023-11-28 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11239: - Fix Version/s: 5.0.0-alpha-4 (was: 5.x) > VerifyError for explicit this

[jira] [Updated] (GROOVY-11239) VerifyError for explicit this parameter and default argument(s)

2023-11-28 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-11239: - Fix Version/s: 5.x > VerifyError for explicit this parameter and default argument(s) >

[jira] [Resolved] (GROOVY-11239) VerifyError for explicit this parameter and default argument(s)

2023-11-28 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-11239. -- Resolution: Fixed https://github.com/apache/groovy/commit/507e4f08860c13e886dc286e6f66c8608d3

[jira] [Created] (GROOVY-11239) VerifyError for explicit this parameter and default argument(s)

2023-11-28 Thread Eric Milles (Jira)
Eric Milles created GROOVY-11239: Summary: VerifyError for explicit this parameter and default argument(s) Key: GROOVY-11239 URL: https://issues.apache.org/jira/browse/GROOVY-11239 Project: Groovy

[jira] [Commented] (GROOVY-11238) Logical implication operator revisited

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790568#comment-17790568 ] ASF GitHub Bot commented on GROOVY-11238: - daniellansun commented on code in PR

Re: [PR] GROOVY-11238: Logical implication operator revisited [groovy]

2023-11-28 Thread via GitHub
daniellansun commented on code in PR #1999: URL: https://github.com/apache/groovy/pull/1999#discussion_r1407754977 ## src/antlr/GroovyParser.g4: ## @@ -848,6 +848,9 @@ expression // logical or (||) (level 13) | left=expression nls op=OR nls right=expression

[jira] [Commented] (GROOVY-11237) Support static interface methods

2023-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790487#comment-17790487 ] ASF GitHub Bot commented on GROOVY-11237: - paulk-asert opened a new pull reques

[PR] GROOVY-11237: Support static interface methods [groovy]

2023-11-28 Thread via GitHub
paulk-asert opened a new pull request, #2001: URL: https://github.com/apache/groovy/pull/2001 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e