[jira] [Commented] (GROOVY-11263) Analyze dead code

2024-01-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801625#comment-17801625 ] ASF GitHub Bot commented on GROOVY-11263: - daniellansun commented on PR #2023:

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2024-01-01 Thread via GitHub
daniellansun commented on PR #2023: URL: https://github.com/apache/groovy/pull/2023#issuecomment-1873540757 @eric-milles As we all know, source code is meant for developers to read, and the less redundant code there is, the more developer-friendly it becomes. Admittedly, it's cha

Re: [PR] GROOVY-11260: ASTMatcher should support matching a var-arg placeholder [groovy]

2024-01-01 Thread via GitHub
paulk-asert merged PR #2022: URL: https://github.com/apache/groovy/pull/2022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Commented] (GROOVY-11260) ASTMatcher should support matching a var-arg placeholder

2024-01-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801622#comment-17801622 ] ASF GitHub Bot commented on GROOVY-11260: - paulk-asert merged PR #2022: URL: ht

[jira] [Commented] (GROOVY-11263) Analyze dead code

2024-01-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801570#comment-17801570 ] ASF GitHub Bot commented on GROOVY-11263: - eric-milles commented on code in PR

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2024-01-01 Thread via GitHub
eric-milles commented on code in PR #2023: URL: https://github.com/apache/groovy/pull/2023#discussion_r1439064503 ## src/main/java/org/codehaus/groovy/classgen/Verifier.java: ## @@ -302,6 +310,12 @@ private void checkFinalVariables(final ClassNode node) { visitor.visitC

Re: [PR] GROOVY-11263: Analyze dead code [groovy]

2024-01-01 Thread via GitHub
eric-milles commented on PR #2023: URL: https://github.com/apache/groovy/pull/2023#issuecomment-1873409213 Besides the extra class bytecode, is there a strong reason for this? The issue ticket pops up out of the blue without much explanation. There are so many possible paths that I t

[jira] [Commented] (GROOVY-11264) Bump jarjar to 1.13.1

2024-01-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801532#comment-17801532 ] ASF GitHub Bot commented on GROOVY-11264: - daniellansun closed pull request #20

Re: [PR] GROOVY-11264: Bump jarjar to 1.13.1 [groovy]

2024-01-01 Thread via GitHub
daniellansun closed pull request #2024: GROOVY-11264: Bump jarjar to 1.13.1 URL: https://github.com/apache/groovy/pull/2024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u