Re: [PR] Backport Gradle 8 updates for Groovy 4 branch [groovy]

2024-02-05 Thread via GitHub
Goooler commented on PR #2048: URL: https://github.com/apache/groovy/pull/2048#issuecomment-1928713497 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] Backport Gradle 8 updates for Groovy 4 branch [groovy]

2024-02-05 Thread via GitHub
paulk-asert merged PR #2048: URL: https://github.com/apache/groovy/pull/2048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[jira] [Created] (GROOVY-11307) Compiler error for misapplication of @FunctionalInterface

2024-02-05 Thread Eric Milles (Jira)
Eric Milles created GROOVY-11307: Summary: Compiler error for misapplication of @FunctionalInterface Key: GROOVY-11307 URL: https://issues.apache.org/jira/browse/GROOVY-11307 Project: Groovy

Re: [PR] Backport Gradle 8 updates for Groovy 4 branch [groovy]

2024-02-05 Thread via GitHub
paulk-asert commented on PR #2048: URL: https://github.com/apache/groovy/pull/2048#issuecomment-1926786023 Plan to look at this tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (GROOVY-11294) Make generated toList() and toMap() methods on records return immutable collections

2024-02-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814328#comment-17814328 ] ASF GitHub Bot commented on GROOVY-11294: - paulk-asert commented on PR #2044: U

[jira] [Commented] (GROOVY-11294) Make generated toList() and toMap() methods on records return immutable collections

2024-02-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814327#comment-17814327 ] ASF GitHub Bot commented on GROOVY-11294: - paulk-asert closed pull request #204

Re: [PR] GROOVY-11294: Make generated toList() and toMap() methods on records return immutable collections [groovy]

2024-02-05 Thread via GitHub
paulk-asert closed pull request #2044: GROOVY-11294: Make generated toList() and toMap() methods on records return immutable collections URL: https://github.com/apache/groovy/pull/2044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] GROOVY-11294: Make generated toList() and toMap() methods on records return immutable collections [groovy]

2024-02-05 Thread via GitHub
paulk-asert commented on PR #2044: URL: https://github.com/apache/groovy/pull/2044#issuecomment-1926785163 As per comment in the issue, I'll close this PR. There is plenty of scope for further improvements - as noted, even with POJO, records still make calls into runtime. This is why @POJO

[jira] [Commented] (GROOVY-11294) Make generated toList() and toMap() methods on records return immutable collections

2024-02-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-11294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814326#comment-17814326 ] ASF GitHub Bot commented on GROOVY-11294: - paulk-asert merged PR #2047: URL: ht

Re: [PR] GROOVY-11294: Make generated toList() and toMap() methods on records … [groovy]

2024-02-05 Thread via GitHub
paulk-asert merged PR #2047: URL: https://github.com/apache/groovy/pull/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g