[GitHub] groovy pull request #:

2018-05-08 Thread bsideup
Github user bsideup commented on the pull request: https://github.com/apache/groovy/commit/33be1e1d51dd0b238ee551eff0c46a2306b7e339#commitcomment-28897694 In subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/methods/MacroGroovyMethods.java: In subprojects/groovy

[GitHub] groovy pull request #472: Macro methods

2017-03-26 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r108093778 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroMethodsCache.java --- @@ -0,0 +1,144

[GitHub] groovy pull request #472: Macro methods

2016-12-29 Thread bsideup
GitHub user bsideup opened a pull request: https://github.com/apache/groovy/pull/472 Macro methods Introduce macro methods and re-implement macro as a macro method You can merge this pull request into a Git repository by running: $ git pull https://github.com/bsideup/groovy

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-09 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82528217 --- Diff: build.gradle --- @@ -238,6 +239,7 @@ dependencies { testCompile project(':groovy-ant') testCompile project(&#x

[GitHub] groovy pull request #443: Simplify MacroGroovy substitutions' implementation...

2016-10-08 Thread bsideup
GitHub user bsideup opened a pull request: https://github.com/apache/groovy/pull/443 Simplify MacroGroovy substitutions' implementation. Assume the order of substitutions, so we can use a list instead of a map to pass the context. Fixes some Antlr4 migration-re

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-08 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82503510 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-07 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82380664 --- Diff: src/spec/test/metaprogramming/ASTMatcherTestingTest.groovy --- @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-07 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82379710 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-07 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82380154 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] groovy pull request #439: WIP Add groovy-macro docs

2016-10-07 Thread bsideup
Github user bsideup commented on a diff in the pull request: https://github.com/apache/groovy/pull/439#discussion_r82379792 --- Diff: src/spec/test/metaprogramming/ASTMatcherFilteringTest.groovy --- @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF