[GitHub] groovy pull request #840: [20181213]Bump dependencies to the latest version

2018-12-12 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/840 ---

[GitHub] groovy pull request #841: Avoid `gradlew assemble` before running tests on t...

2018-12-12 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/841 Avoid `gradlew assemble` before running tests on travis-ci You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine

[GitHub] groovy pull request #840: [20181213]Bump dependencies to the latest version

2018-12-12 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/840 [20181213]Bump dependencies to the latest version You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy bump-deps-1

[GitHub] groovy pull request #838: GROOVY-8920: Fails to infer parameter and return t...

2018-12-12 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/838 GROOVY-8920: Fails to infer parameter and return type of SAM on RHS You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240468415 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240451854 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/837#discussion_r240445739 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java --- @@ -213,4 +220,15 @@ private static String makeRefDescription(String

[GitHub] groovy pull request #837: GROOVY-8917: Failed to infer parameter type of som...

2018-12-10 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/837 GROOVY-8917: Failed to infer parameter type of some SAM, e.g. BinaryO… …perator You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #836: GROOVY-8915: [Parrot] Make groovydoc configuration...

2018-12-08 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/836 GROOVY-8915: [Parrot] Make groovydoc configuration flexible You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY

[GitHub] groovy pull request #835: GROOVY-8908: Bump gradle to 5.0

2018-12-03 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/835#discussion_r238350588 --- Diff: subprojects/parser-antlr4/build.gradle --- @@ -30,9 +30,11 @@ def srcBase = "subprojects/parser-antlr4/src" def srcMain = &quo

[GitHub] groovy pull request #835: GROOVY-8908: Bump gradle to 5.0

2018-12-03 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/835 GROOVY-8908: Bump gradle to 5.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8908 Alternatively you can

[GitHub] groovy pull request #831: GROOVY-8901: Add DGSM `countDistinct[By]`, `sum[By...

2018-11-26 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/831 ---

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-11-26 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/708 ---

[GitHub] groovy pull request #832: GROOVY-8902: Add method `mapAll` to tuples

2018-11-24 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/832 GROOVY-8902: Add method `mapAll` to tuples You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy tuple-mapall

[GitHub] groovy pull request #831: GROOVY-8901: Add DGSM `countDistinct[By]`, `sum[By...

2018-11-23 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/831 GROOVY-8901: Add DGSM `countDistinct[By]`, `sum[By]`, `avg[By]` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #829: GROOVY-8900: Make class `Tuple0`, `Tuple1`...`Tupl...

2018-11-22 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/829 GROOVY-8900: Make class `Tuple0`, `Tuple1`...`Tuple16` final You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY

[GitHub] groovy pull request #828: GROOVY-8899: Add DGSM `first` and `last`

2018-11-22 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/828 GROOVY-8899: Add DGSM `first` and `last` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy enhance-collectors

[GitHub] groovy pull request #826: GROOVY-8894: Improve performance of DGM `leftShift...

2018-11-19 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/826 GROOVY-8894: Improve performance of DGM `leftShift(OutputStream, Inpu… …tStream)` You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #825: GROOVY-8890: Make "Inspect Tokens" of groovy conso...

2018-11-18 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/825 GROOVY-8890: Make "Inspect Tokens" of groovy console support Parrot's… … tokens You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] groovy pull request #824: GROOVY-8887: Support multi-assignment of tuples in...

2018-11-17 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/824 GROOVY-8887: Support multi-assignment of tuples in STC You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy stc-tuple

[GitHub] groovy pull request #821: GROOVY-8874: Refine tuples to support functional p...

2018-11-10 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/821 GROOVY-8874: Refine tuples to support functional programming better You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #:

2018-11-05 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/7d2d6319f694b87fc4e646d3d22679315e1411bf#commitcomment-31185553 In src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java: In src/main/java/org/apache/groovy/ast/tools

[GitHub] groovy pull request #819: GROOVY-7975/GROOVY-3278/GROOVY-7854: improved acce...

2018-11-04 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/819#discussion_r230589376 --- Diff: src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java --- @@ -18,20 +18,205 @@ */ package org.apache.groovy.ast.tools

[GitHub] groovy pull request #818: GROOVY-8866: Implement `GProperties` to handle pro...

2018-11-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/818 GROOVY-8866: Implement `GProperties` to handle properties file smartly You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106

[GitHub] groovy pull request #:

2018-10-28 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075653 No one can assure Groovy users will not create GroovyCodeSource instances with different names for the same source code

[GitHub] groovy pull request #:

2018-10-28 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075542 e.g. GroovyShell evaluates same script with different file names, which results in loading classes repeatedly

[GitHub] groovy pull request #817: GROOVY-8861: Simplify the switch for runtime groov...

2018-10-28 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/817 GROOVY-8861: Simplify the switch for runtime groovydoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine

[GitHub] groovy pull request #816: GROOVY-8858: Refine GCL to avoid occupying Permane...

2018-10-27 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/816 GROOVY-8858: Refine GCL to avoid occupying Permanent Area/Metaspace repeatedly for same source code You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #813: GROOVY-8851: Refine safe indexing for named proper...

2018-10-20 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/813 GROOVY-8851: Refine safe indexing for named properties You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine-safe

[GitHub] groovy pull request #809: GROOVY-8842: Refine highlighting source code in gr...

2018-10-12 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/809 GROOVY-8842: Refine highlighting source code in groovy console editor You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106

[GitHub] groovy pull request #:

2018-10-10 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/fd21ad4e3b6d2a4297944d079ba8948e8d8e6052#commitcomment-30846491 Using Java 8 API causes the test failure when running on Java 7 ---

[GitHub] groovy pull request #807: GROOVY-8819: java.lang.VerifyError when calling th...

2018-10-07 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/807 GROOVY-8819: java.lang.VerifyError when calling this() with static fi… …nal field from a super class You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #806: GROOVY-8831: Add instance methods from `String` to...

2018-10-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/806 GROOVY-8831: Add instance methods from `String` to `GString` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine

[GitHub] groovy pull request #805: Refine compileJava task

2018-10-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/805 Refine compileJava task You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine-compile-java-task Alternatively you

[GitHub] groovy pull request #801: GROOVY-8327: Parser regression. Can't access stati...

2018-09-22 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/801 GROOVY-8327: Parser regression. Can't access static instance method b… …efore class is constructed You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #800: GROOVY-8808: Add DGM `Throwable.asString`

2018-09-22 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/800 GROOVY-8808: Add DGM `Throwable.asString` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy throwable-asstring

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217901272 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217900520 --- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc --- @@ -0,0 +1,112

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-15 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/797#discussion_r217900457 --- Diff: build.gradle --- @@ -160,6 +160,8 @@ ext { spockVersion = '1.2-groovy-2.4-SNAPSHOT' // supports 3.0 antlr4Version = '4.7.1

[GitHub] groovy pull request #:

2018-09-14 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/522fd4996b6314caa05d16590f3896bf750eb83e#commitcomment-30515521 I've merged the commit into https://github.com/danielsun1106/groovy-parser with your information reserved

[GitHub] groovy pull request #797: GROOVY-8794: Add groovy-yaml subproject to support...

2018-09-14 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/797 GROOVY-8794: Add groovy-yaml subproject to support parsing yaml You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #793: GROOVY-8780: Add `sha256` DGM

2018-09-07 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/793#discussion_r216121282 --- Diff: src/main/java/org/codehaus/groovy/runtime/EncodingGroovyMethods.java --- @@ -389,6 +390,26 @@ public static String md5(byte[] self) throws

[GitHub] groovy pull request #793: GROOVY-8780: Add `sha256` DGM

2018-09-07 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/793 GROOVY-8780: Add `sha256` DGM You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy more-digest Alternatively you can

[GitHub] groovy pull request #792: GROOVY-8778: Cast short-hand breaks for empty map

2018-09-07 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/792#discussion_r216116090 --- Diff: subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java --- @@ -2337,14 +2337,11 @@ public Expression

[GitHub] groovy pull request #792: GROOVY-8778: Cast short-hand breaks for empty map

2018-09-07 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/792#discussion_r216113948 --- Diff: subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java --- @@ -2337,14 +2337,11 @@ public Expression

[GitHub] groovy pull request #789: GROOVY-8090: Incorrectly processing method-level t...

2018-08-26 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/789 GROOVY-8090: Incorrectly processing method-level type generics inform… …ation You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #:

2018-08-17 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/35a3df1436b76f315a925f7d30479c8d092805c0#commitcomment-30151884 GROOVY-8741: Make single character GString behave like similar String in '==' #782 ---

[GitHub] groovy pull request #:

2018-08-12 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/ed3814a053eee8a4480c85c23485e161fd74c16a#commitcomment-30046088 Nice! The codebase is much cleaner than before :-) ---

[GitHub] groovy pull request #:

2018-08-11 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/ec7b147b4b90c55e1d117f3bac63b060eeb79386#commitcomment-30043824 `UnlimitedConcurrentCache`'s `getAndPut` on 2.5 branch is not thread safe, so the commit is only for the master. ---

[GitHub] groovy pull request #:

2018-07-02 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574669 In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java: In src/main/java/org/codehaus/groovy/ast/tools

[GitHub] groovy pull request #765: GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACH...

2018-07-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/765 GROOVY-8675: GenericsUtils.PARAMETERIZED_TYPE_CACHE is static and pri… …vate You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #755: Fix inferring return type issues

2018-06-14 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/755 Fix inferring return type issues When methods are mixed with other expressions in the return statement, `isNestedOrSandwichedMethodCall` fails to handle all cases and the source of issues

[GitHub] groovy pull request #752: Add openjdk10 build

2018-06-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/752 Add openjdk10 build You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy java10 Alternatively you can review and apply

[GitHub] groovy pull request #751: Bump asm to 6.2

2018-06-06 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/751 Bump asm to 6.2 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy bump-asm-62 Alternatively you can review and apply

[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/748#discussion_r193360798 --- Diff: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java

[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-06 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/748#discussion_r193360554 --- Diff: src/main/antlr2/org/codehaus/groovy/antlr/java/java.g --- @@ -402,10 +402,9 @@ wildcardType (("extends"

[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-05 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/748#discussion_r193270629 --- Diff: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java

[GitHub] groovy pull request #750: Refine the parameterized type cache

2018-06-04 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/750 Refine the parameterized type cache Use `SoftReference` instance to hold value to release memory after STC is done. You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #749: GROOVY-8629: Groovy STC fails on return of nested ...

2018-06-04 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/749 GROOVY-8629: Groovy STC fails on return of nested class using generics You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106

[GitHub] groovy pull request #748: GROOVY-8628: Groovydoc fails to parse Java static ...

2018-06-03 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/748#discussion_r192608515 --- Diff: subprojects/groovy-groovydoc/src/test/groovy/org/codehaus/groovy/tools/groovydoc/testfiles/JavaStaticNestedClassWithDiamond.java

[GitHub] groovy pull request #746: Refine the rule for missing right parenthesis

2018-06-02 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/746 Refine the rule for missing right parenthesis You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine-missing-right

[GitHub] groovy pull request #744: GROOVY-8613: GCE in elvis assignment evaluation

2018-06-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/744 GROOVY-8613: GCE in elvis assignment evaluation You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8613

[GitHub] groovy pull request #739: Refine GROOVY-8595: Fix type inference of method c...

2018-06-01 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/739 ---

[GitHub] groovy pull request #739: Refine GROOVY-8595: Fix type inference of method c...

2018-06-01 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/739 Refine GROOVY-8595: Fix type inference of method call in property exp… …ression You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #738: Make classpath table of groovy console not editabl...

2018-05-31 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/738 Make classpath table of groovy console not editable You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine-classpath

[GitHub] groovy pull request #735: Fix file descriptor leak in AST transform discover...

2018-05-29 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/735#discussion_r191637941 --- Diff: src/main/java/org/codehaus/groovy/transform/ASTTransformationVisitor.java --- @@ -221,7 +222,9 @@ private static void doAddGlobalTransforms

[GitHub] groovy pull request #734: Make some groovy classes compile static

2018-05-29 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/734 Make some groovy classes compile static In order to reduce the size of class files and improve the performance of groovy console, the PR tries to make as many groovy classes as possible

[GitHub] groovy pull request #733: Trivial refactoring: Use `AtomicInteger` instead o...

2018-05-28 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/733 Trivial refactoring: Use `AtomicInteger` instead of `synchronized` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #732: Refine the usage of `toArray` in `GroovyShell`

2018-05-28 Thread danielsun1106
Github user danielsun1106 closed the pull request at: https://github.com/apache/groovy/pull/732 ---

[GitHub] groovy pull request #732: Refine the usage of `toArray` in `GroovyShell`

2018-05-28 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/732 Refine the usage of `toArray` in `GroovyShell` You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy refine-groovyshell

[GitHub] groovy pull request #730: GROOVY-8609 Fails to compile when upper bound has ...

2018-05-27 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/730 GROOVY-8609 Fails to compile when upper bound has generics You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY

[GitHub] groovy pull request #726: Minor refactoring: use another extracting placehol...

2018-05-25 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/726 Minor refactoring: use another extracting placeholder logic You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy minor

[GitHub] groovy pull request #722: Request YourKit Java Profiler Open Source License

2018-05-24 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/722 Request YourKit Java Profiler Open Source License Here is the link to YourKit and search "Open source project license" in the page: https://www.yourkit.co

[GitHub] groovy pull request #721: Cache the parameterized info for better performanc...

2018-05-24 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/721 Cache the parameterized info for better performance Finding the parameterized type is expensive, so it's better to cache it. You can merge this pull request into a Git repository by running

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-23 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/717#discussion_r190359768 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -596,6 +597,26 @@ public void visitVariableExpression

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-23 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/717#discussion_r190359237 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -596,6 +597,26 @@ public void visitVariableExpression

[GitHub] groovy pull request #718: Bump ivy to 2.5.0-rc1

2018-05-23 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/718 Bump ivy to 2.5.0-rc1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy bump-ivy-2.5.0-rc1 Alternatively you can

[GitHub] groovy pull request #714: GROOVY-8586: Support Java 9 ARM blocks

2018-05-21 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/714 GROOVY-8586: Support Java 9 ARM blocks You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8586 Alternatively

[GitHub] groovy pull request #:

2018-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/869c365161457c050d5a54c7ff43d73d3263f34e#commitcomment-29055018 I've synchronized your changes to https://github.com/danielsun1106/groovy-parser with your contribution info kept

[GitHub] groovy pull request #:

2018-05-18 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c2cea059fecc3bc4a2c01adc6a30d2a1508bd64b#commitcomment-29031873 author is not blank 😉 ---

[GitHub] groovy pull request #:

2018-05-17 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c9eea7c30ececdc0a24939fb780c56c27eec798f#commitcomment-29020550 GROOVY-4151 test has been recovered by https://github.com/apache/groovy/commit/ef2fbe68d25ae7dce57ee2580c975c54e3dbaace ---

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188837462 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188826337 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/708 GROOVY-6668: Static compiler doesn't coerce GString for getAt() call You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #:

2018-05-14 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/62f877abd28c62e3058a383905bb93624ef36130#commitcomment-28966000 @paulk-asert author is not blank again? o_O ---

[GitHub] groovy pull request #705: GROOVY-7883 Static compiler prefers private constr...

2018-05-11 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/705#discussion_r187764707 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java --- @@ -3973,7 +3973,7 @@ protected final ResultSet executePreparedQuery(String sql

[GitHub] groovy pull request #705: GROOVY-7883 Static compiler prefers private constr...

2018-05-11 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/705 GROOVY-7883 Static compiler prefers private constructor over public … …if private matches be You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #:

2018-05-11 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/3f650cc681cf1702860a47247bfa728c4c793ef8#commitcomment-28943410 @paulk-asert author field is not blank again? ;-) ---

[GitHub] groovy pull request #699: GROOVY-7204: Static type checking and compilation ...

2018-05-09 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/699 GROOVY-7204: Static type checking and compilation fail when multiple … …generics in use You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #:

2018-05-04 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28855880 @paulk-asert you can check whether the Author field in the commit dialog of IntelliJ IDEA is blank. ---

[GitHub] groovy pull request #:

2018-05-04 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28855805 @paulk-asert I have not contributed the commit... ---

[GitHub] groovy pull request #693: Allow methodMissing/propertyMissing to be defined ...

2018-05-03 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/693#discussion_r185901767 --- Diff: src/main/groovy/groovy/lang/MetaClassImpl.java --- @@ -945,6 +945,15 @@ private Object invokeMissingMethod(Object instance, String

[GitHub] groovy pull request #:

2018-05-01 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/aa1ad8fe2ab2c37a0b95215e692e73bdc37297f7#commitcomment-28806379 weird... I have not contributed such a change, but the author is me... ---

[GitHub] groovy pull request #691: Support java-like array

2018-04-26 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/691 Support java-like array ## Background In order to improve the compatibility with Java(Copy & Paste), Java array is one of features widely applied in Java projects. The PR will make Gr

[GitHub] groovy pull request #690: Add DGM `whichJar` to get the url of the jar conta...

2018-04-23 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/690 Add DGM `whichJar` to get the url of the jar containing the specified… … class You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #:

2018-04-22 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b5ff40d8717d3a48cbf0f177bef4982520484166#commitcomment-28690012 I've submitted an issue: https://github.com/gradle/gradle/issues/5131 @melix any thoughts on the issue? ---

[GitHub] groovy pull request #:

2018-04-21 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b5ff40d8717d3a48cbf0f177bef4982520484166#commitcomment-28683345 The following error occurred after bumped gradle to 4.7 http://ci.groovy-lang.org/viewLog.html?buildId=49104

[GitHub] groovy pull request #686: @Newify table name pattern support

2018-04-19 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/686#discussion_r182659937 --- Diff: src/main/java/org/codehaus/groovy/transform/NewifyASTTransformation.java --- @@ -286,31 +372,106 @@ private static boolean isNewMethodStyle

[GitHub] groovy pull request #686: @Newify table name pattern support

2018-04-19 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/686#discussion_r182659807 --- Diff: src/main/java/org/codehaus/groovy/transform/NewifyASTTransformation.java --- @@ -196,39 +322,10 @@ private boolean shouldTransform

[GitHub] groovy pull request #:

2018-04-13 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28569390 In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java: In src/main/java/org/codehaus/groovy/control

  1   2   >