[GitHub] groovy pull request #835: GROOVY-8908: Bump gradle to 5.0

2018-12-03 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/835#discussion_r238345659 --- Diff: subprojects/parser-antlr4/build.gradle --- @@ -30,9 +30,11 @@ def srcBase = "subprojects/parser-antlr4/src" def srcMain = &quo

[GitHub] groovy pull request #719: Optimize generation of Groovydoc

2018-05-23 Thread melix
GitHub user melix opened a pull request: https://github.com/apache/groovy/pull/719 Optimize generation of Groovydoc There's a lot to say about Groovydoc, but worst of all, its performance is terrible. This PR is an attempt to fix part of it. Before my changes: https

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2018-02-06 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/566#discussion_r166246347 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -12026,6 +12026,9 @@ public static boolean equals(List left, List right

[GitHub] groovy pull request #:

2017-12-19 Thread melix
Github user melix commented on the pull request: https://github.com/apache/groovy/commit/a6c82ad08b85ae8746b982a1a19107e93bfdb568#commitcomment-26384969 :+1: I apparently missed that! ---

[GitHub] groovy pull request #635: GROOVY-8255: Odd problems with flow typing and gen...

2017-11-14 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/635#discussion_r150800145 --- Diff: src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -3461,6 +3465,36 @@ public void visitTernaryExpression(final

[GitHub] groovy pull request #:

2017-06-16 Thread melix
Github user melix commented on the pull request: https://github.com/apache/groovy/commit/6c4fa92328f48c9a0e2c85c4a26e65000dbd1088#commitcomment-22584865 Sorry my bad, it's not an API change, it's just that I had the build scan recipes plugin applied in an init script, so I didn't

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103271106 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroTransformation.java --- @@ -18,42 +18,113

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103270568 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java --- @@ -0,0 +1,114

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103270486 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroClassTransformation.java --- @@ -0,0 +1,114

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103271019 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/transform/MacroTransformation.java --- @@ -18,42 +18,113

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103269693 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/MacroStub.java --- @@ -0,0 +1,32 @@ +/* + * Licensed

[GitHub] groovy pull request #472: Macro methods

2017-02-27 Thread melix
Github user melix commented on a diff in the pull request: https://github.com/apache/groovy/pull/472#discussion_r103269312 --- Diff: subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/runtime/Macro.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache

[GitHub] groovy pull request #:

2016-07-15 Thread melix
Github user melix commented on the pull request: https://github.com/apache/groovy/commit/a903c9e330af224006380af0f56afa98c0cc6b64#commitcomment-18257989 In src/main/groovy/lang/ObjectRange.java: In src/main/groovy/lang/ObjectRange.java on line 237: This is a binary breaking