Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/837#discussion_r240451723
--- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java
---
@@ -213,4 +220,15 @@ private static String makeRefDescription(String
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/837#discussion_r240451547
--- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java
---
@@ -213,4 +220,15 @@ private static String makeRefDescription(String
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/837#discussion_r240451187
--- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java
---
@@ -213,4 +220,15 @@ private static String makeRefDescription(String
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/837#discussion_r240369943
--- Diff: src/main/java/org/codehaus/groovy/classgen/asm/util/TypeUtil.java
---
@@ -213,4 +220,15 @@ private static String makeRefDescription(String
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/833
GROOVY-8903: Retrofit NamedParams to groovy.sql.Sql
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8903
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/830
GROOVY-7647: Incorrect line information for debug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy7647
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/827
GROOVY-8882: CS: Loop over elements of String has different element type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/823
GROOVY-8880: Traits - static/instance init blocks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8880
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/822
GROOVY-7632: Groovy named parameters static check (initial cut of supâ¦
â¦port)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7d2d6319f694b87fc4e646d3d22679315e1411bf#commitcomment-31185822
In src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java:
In src/main/java/org/apache/groovy/ast/tools
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/819#discussion_r230627859
--- Diff: src/main/java/org/apache/groovy/ast/tools/ExpressionUtils.java ---
@@ -18,20 +18,205 @@
*/
package org.apache.groovy.ast.tools
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/819
GROOVY-7975/GROOVY-3278/GROOVY-7854: improved accessing of constants â¦
â¦for annotation attributes
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/814
GROOVY-3278: Using referenced String constant as value of Annotation â¦
â¦causes compile error
You can merge this pull request into a Git repository by running:
$ git pull https
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/811#discussion_r225328503
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java ---
@@ -18,14 +18,78 @@
*/
package org.codehaus.groovy.vmplugin.v9
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/811
GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.Jâ¦
â¦ava7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/fd21ad4e3b6d2a4297944d079ba8948e8d8e6052#commitcomment-30846605
True, I'll fix
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/803
GROOVY-8806: Immutable classes break in groovy 2.5.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8806
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/798
GROOVY-8549: Compile Static causes getAt to fail
I started fixing this in STCSW first with something like below but then
putAt also needs fixing.
In the meantime, the added DGM methods
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217901029
--- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc ---
@@ -0,0 +1,112
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217899766
--- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc ---
@@ -0,0 +1,112
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217899761
--- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc ---
@@ -0,0 +1,112
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217899737
--- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc ---
@@ -0,0 +1,112
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217899707
--- Diff: build.gradle ---
@@ -160,6 +160,8 @@ ext {
spockVersion = '1.2-groovy-2.4-SNAPSHOT' // supports 3.0
antlr4Version = '4.7.1
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/797#discussion_r217899699
--- Diff: subprojects/groovy-yaml/src/spec/doc/yaml-userguide.adoc ---
@@ -0,0 +1,112
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/796
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/796
GROOVY-8775: Bug joint compilation in ant task groovyc: classpath not set
This doesn't fix the issue but enables a workaround until we fix fully
You can merge this pull request into a Git
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/795
GROOVY-8703: Unexpected behavior with @NamedVariant on constructor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/793#discussion_r216121209
--- Diff:
src/main/java/org/codehaus/groovy/runtime/EncodingGroovyMethods.java ---
@@ -389,6 +390,26 @@ public static String md5(byte[] self) throws
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/793#discussion_r216121214
--- Diff:
src/main/java/org/codehaus/groovy/runtime/EncodingGroovyMethods.java ---
@@ -389,6 +390,26 @@ public static String md5(byte[] self) throws
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/792#discussion_r216118264
--- Diff:
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
---
@@ -2337,14 +2337,11 @@ public Expression
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/792#discussion_r216115626
--- Diff:
subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java
---
@@ -2337,14 +2337,11 @@ public Expression
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/792
GROOVY-8778: Cast short-hand breaks for empty map
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8778
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427238
In subprojects/groovy-test-junit5/build.gradle:
In subprojects/groovy-test-junit5/build.gradle on line 28:
Thanks
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/791
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/791
GROOVY-8771: global AST transformation declarations should move to MEâ¦
â¦TA-INF/groovy instead of META-INF/services
You can merge this pull request into a Git repository by running
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/788
GROOVY-8757: Incorrect bytecode produced after compiling class implemâ¦
â¦enting trait with generic method
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/787
GROOVY-8758: @WithReadLock in inner class of @CompileStatic class cauâ¦
â¦ses java.lang.VerifyError
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/786
GROOVY-8753: Compiler error in STC: exception in phase 'instruction sâ¦
â¦election'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/785
GROOVY-7330: Incorrect dynamic proxy creation from map when there areâ¦
⦠default methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/783
GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act aâ¦
â¦s a "global" node for metadata
You can merge this pull request into a Git repository by running:
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/781
GROOVY-8732: @CompileStatic refers to private field in parent class
Currently JavaBean style getters aren't recognised
before some preliminary provisions are made for the
case
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/780
GROOVY-8722: final modifier for non-abstract methods in traits is ignâ¦
â¦ored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/776
GROOVY-8710: JAXB JDK9-11 compatibility for install
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8710
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/775
GROOVY-8639: @Sortable annotation is not able to use accessible parenâ¦
â¦t properties
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/774
GROOVY-8282: Error while popping argument from operand stack tracker â¦
â¦in class ...$Trait$Helper
Bare named argument parameters are captured in a TupleExpression rather
than
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/773
GROOVY-8696: TypeWrapper leaks out of DecompiledClassNode
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8696
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/767
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/772
GROOVY-8281: Final field is null in trait, but it has assigned value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/767
GROOVY-8233: Java stub generation incorrect for static properties of â¦
â¦traits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3143944c30f340208be40e9452e2e5be2e4a33be#commitcomment-29574608
In src/main/java/org/codehaus/groovy/ast/tools/GenericsUtils.java:
In src/main/java/org/codehaus/groovy/ast/tools
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/764
GROOVY-8671: Move JaxbGroovyMethods into their own optional groovy-jaâ¦
â¦xb "module"
You can merge this pull request into a Git repository by running:
$ git pull https://
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/763
GROOVY-8670: Make groovy-bsf an optional "module" for 2.5.1+, i.e. noâ¦
â¦t reference by groovy-all
You can merge this pull request into a Git repository by running:
$ git
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/760
GROOVY-8224: Stubs for classes implementing traits with fields don't â¦
â¦include getters/setters
You can merge this pull request into a Git repository by running:
$ git pull https
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/757#discussion_r195962344
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v5/Java5.java ---
@@ -405,6 +408,32 @@ public void configureClassNode(CompileUnit
compileUnit
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/759
GROOVY-8627: Compile error using NamedParam with value
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8627
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/758
GROOVY-8637: @NamedVariant processing error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8637
Alternatively
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/727
GROOVY-8592: changes for groovysh and tidy up
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8592b
Alternatively
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/725
GROOVY-8607: CliBuilder should ignore 'opt' property if provided withâ¦
â¦in a Map of arguments
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/723
GROOVY-8601: Groovy should have a runner for JUnit5 tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8601
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/720
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/716
GROOVY-8596: SqlGroovyMethods could be moved to avoid split packages â¦
â¦- part (1)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/715
GROOVY-8593: DocGenerator could be moved to avoid split packages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/708#discussion_r188832656
--- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/62f877abd28c62e3058a383905bb93624ef36130#commitcomment-28966636
Weird, I had to reset again. Seems okay now. I don't know how it keeps
coming back. Maybe I just need to do a fresh reinstall
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3f650cc681cf1702860a47247bfa728c4c793ef8#commitcomment-28943972
It was changed again! Weird, I've never set that field myself.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28863337
That's it! I was wondering how it got in there. I had checked all my git
config from the cmd line. I don't remember ever
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/694#discussion_r186015829
--- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java
---
@@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/694#discussion_r186015291
--- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java
---
@@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/aa1ad8fe2ab2c37a0b95215e692e73bdc37297f7#commitcomment-28813835
It was me - I am not sure how your name got there. I'll have to check
whether my git config is messed up.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28711056
In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java:
In src/main/java/org/codehaus/groovy/control
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/684
move commons-cli CliBuilder into its own subproject
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy-cli
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28576091
In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java:
In src/main/java/org/codehaus/groovy/control
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28569181
In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java:
In src/main/java/org/codehaus/groovy/control
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/683
GROOVY-8539: Groovy fails to compile assignment operators on boolean â¦
â¦array
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f88d0122525cabf6bdf61ab051533f9983f352f1#commitcomment-28390910
In src/test/groovy/SerializableCompatibilityTest.groovy:
In src/test/groovy/SerializableCompatibilityTest.groovy on line
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388135
Technically we only need to "fix" the broken bits but it will be easiest to
revert on all branches and work fr
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387886
Please revert. That just also breaks serializable compability between
2.4.15 and 2_4_X HEAD!!
Run this script
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387375
Let me generate you an example ...
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387373
my last reply was to your earlier comment.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387349
Not all the classes probably gave errors but yep, that will probably be the
easiest. The only other comment I'll make
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387291
Bonus points if you can pin-point what is causing the false positives - we
should submit a bug report/PR to japicmp to fix
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387263
Best bet for checking is to just serialize from 2.4 using
ObjectOutputStream into a dat file (binary file) and read that back
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387229
Also, I'd note that in some cases, like the ObservableList/Map/Set example
which weren't serializable in the first place
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387216
To keep serializability compatible within 2.4 we can add serialVersionUID
values generated from the 2.4 codebase. We can
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387182
Yes but it will break serializability within a point release!
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386425
If you get a chance to check the "Serializable incompatible(!)" warnings
from the checkBinaryCompatibility task
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/678
---
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421035
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -199,20 +208,35 @@ public int size() {
return
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421016
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347515
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
But ''' and """ can quote t
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346795
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
I don't see this as a case of it can be done so
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346403
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
There is no doubt some merit to this approach
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/678
GROOVY-8525: Binary compatibility issue for GroovyClassLoader betweenâ¦
⦠2.4 vs later branches
You can merge this pull request into a Git repository by running:
$ git pull https
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/675#discussion_r176603885
--- Diff: src/main/groovy/groovy/lang/MissingMethodException.java ---
@@ -48,7 +48,7 @@ public MissingMethodException(String method, Class type,
Object
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/675#discussion_r176602934
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -367,6 +367,22 @@ private Object
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/676#discussion_r176448808
--- Diff:
src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy ---
@@ -310,4 +312,18 @@ class DefaultGroovyMethodsTest extends
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107275
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50:
The test passed
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107251
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50:
It would
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/e154c3e560e998e158985316566c7e321579b193#commitcomment-28107242
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 22:
It would
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28040924
I was hoping to have it out (for Apache voting) by now. I might still get
that done before I hop on a plane tonight
1 - 100 of 296 matches
Mail list logo
