Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/648#discussion_r158607705
--- Diff: src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java
---
@@ -305,11 +305,6 @@ private void makeInnerClassEntry(ClassNode cn
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/648
GROOVY-8423: Do not adjust access modifiers for inner class table entâ¦
â¦ries
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/644#discussion_r156211571
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -3371,77 +3396,179 @@ public static Number count(byte[] self, Object
value
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/641
GROOVY-8402: GroovyScriptEngine.ScriptClassLoader applies compilationâ¦
⦠customizers twice
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/625
GROOVY-8369: Statically compiled property access on enum class throwsâ¦
⦠NoSuchFieldError
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/619#discussion_r146433436
--- Diff: src/test/gls/enums/EnumTest.groovy ---
@@ -592,6 +592,80 @@ class EnumTest extends CompilableTestSupport {
assert
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/619
GROOVY-8360: Enums that are inner classes should have the static clasâ¦
â¦s modifier
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/539#discussion_r116149015
--- Diff:
src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy
---
@@ -128,6 +128,18 @@ class
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/539
GROOVY-8074: Statically compiled dot property accesses instance propeâ¦
â¦rty instead of Map property
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/537
GROOVY-8157: Flow typing doesn't work with assignment to a parameter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy GROOVY
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/536
Improve type inference/STC compatibility of Sql methods with closure
parameters
This PR adds @ClosureParams to closure parameters of the following methods
in Sql and DataSet:
* asList
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/518
GROOVY-8132: Owner properties should be preferred over properties of â¦
â¦@Delegate field
* Add test for method delegation precedence
You can merge this pull request into a Git repository
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/487
GROOVY-8069: Annotation based logging of complex expression in closurâ¦
â¦e throws GroovyCastException with SC.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/476
GROOVY-8033: spread property calls on non-list collections fail STC iâ¦
â¦n static methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/449
GROOVY-7932: generate bridge methods for private constructors during â¦
â¦static compilation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/442#discussion_r82517775
--- Diff:
src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule
---
@@ -17,5 +17,5 @@
# IT IS A WORKAROUND FOR 2
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/442
GROOVY-7953: property expressions for extension methods on primitivesâ¦
⦠fail STC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/436
GROOVY-7952: Property expressions for extension methods starting withâ¦
⦠'is' fail STC
* Add support for 'is' getter method variants of GROOVY-5580
You can merge this
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/362
GROOVY-7870: BinaryExpressionTransformer: Set line numbers on transfoâ¦
â¦rmed binary expressions
You can merge this pull request into a Git repository by running:
$ git pull https
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/348#discussion_r67703766
--- Diff: src/main/groovy/transform/Undefined.java ---
@@ -28,6 +28,10 @@
private Undefined() {}
public static final String STRING
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/351
GROOVY-7862: Statically compiled calls to protected methods of an outâ¦
â¦erclass' superclass result in IllegalAccessErrors
You can merge this pull request into a Git repository by ru
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/350
GROOVY-7863: Statically compiled calls to private outer class methodsâ¦
⦠fail with multiple levels of nesting
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/346
GROOVY-7849: Verifier should be aware of array type covariance when câ¦
â¦hecking overriding method return types
You can merge this pull request into a Git repository by running:
$ git pull
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/338#discussion_r64561363
--- Diff:
src/main/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
---
@@ -134,15 +134,19 @@ public void visit(final
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/338#discussion_r64490605
--- Diff:
src/main/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java
---
@@ -134,15 +134,19 @@ public void visit(final
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/310
GROOVY-7813: Calling a non-static outer class method from a static clâ¦
â¦ass should fail STC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shils closed the pull request at:
https://github.com/apache/groovy/pull/309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/308#discussion_r59120922
--- Diff: src/main/groovy/cli/Unparsed.java ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/309
GROOVY-7813: Calling a non-static outer class method from a static clâ¦
â¦ass should fail STC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/306
GROOVY-7804: Coercion of parameterless closure to generic SAM type thâ¦
â¦rows NPE during STC
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/292#discussion_r56113728
--- Diff: src/main/groovy/grape/GrapeIvy.groovy ---
@@ -76,11 +76,11 @@ class GrapeIvy implements GrapeEngine {
Set resolvedDependencies
Set
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/294
GROOVY-7758: GroovyCastException when both @CompileStatic and @Newifyâ¦
⦠are used
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/257#discussion_r52389570
--- Diff: src/main/org/codehaus/groovy/classgen/asm/ClosureWriter.java ---
@@ -80,7 +80,11 @@ public void writeClosure(ClosureExpression expression
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/257
GROOVY-7312 Add ACC_STATIC flag to inner classes of interfaces
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/groovy GROOVY-7312
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/253#discussion_r52126075
--- Diff: src/test/groovy/transform/stc/GenericsSTCTest.groovy ---
@@ -1800,6 +1800,19 @@ assert result == 'ok'
'''
}
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/253#discussion_r52125211
--- Diff: src/test/groovy/transform/stc/GenericsSTCTest.groovy ---
@@ -1800,6 +1800,19 @@ assert result == 'ok'
'''
}
Github user shils commented on a diff in the pull request:
https://github.com/apache/groovy/pull/242#discussion_r50188030
--- Diff:
src/main/org/codehaus/groovy/transform/sc/StaticCompilationVisitor.java ---
@@ -123,9 +123,20 @@ public void visitClass(final ClassNode node
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/242
GROOVY-7558 Add private field accessors and bridge methods to dynamicâ¦
⦠classes with statically compiled inner classes
You can merge this pull request into a Git repository by running
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/229
GROOVY-7705: Add bridge methods for setting private fields of outer câ¦
â¦lass from inner class or closure
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/228
GROOVY-7036: An interface implementation (override) with a method incâ¦
â¦luding a default parameter value does not compile
You can merge this pull request into a Git repository by running
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/227
GROOVY-7702: @CompileStatic and the method with(Closure) seem to deteâ¦
â¦rmine wrong type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/217
GROOVY-7717 StaticTypeCheckingTestCase#shouldFailWithMessages erroneoâ¦
â¦usly passes
*StaticTypeCheckingTestCase: shouldFailWithMessages should only pass if all
and only the expected
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/207
GROOVY-6958 null != NullObject when using categories
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shils/incubator-groovy GROOVY-6958
GitHub user shils opened a pull request:
https://github.com/apache/groovy/pull/201
GROOVY-7698 Safe navigation is broken for property style non-synthetiâ¦
â¦c setter calls under static compilation
You can merge this pull request into a Git repository by running:
$ git pull
44 matches
Mail list logo