[GitHub] groovy pull request #648: GROOVY-8423: Do not adjust access modifiers for in...

2017-12-24 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/648#discussion_r158607705 --- Diff: src/main/java/org/codehaus/groovy/classgen/AsmClassGenerator.java --- @@ -305,11 +305,6 @@ private void makeInnerClassEntry(ClassNode cn

[GitHub] groovy pull request #648: GROOVY-8423: Do not adjust access modifiers for in...

2017-12-24 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/648 GROOVY-8423: Do not adjust access modifiers for inner class table ent… …ries You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy

[GitHub] groovy pull request #644: GROOVY-8406: Various DefaultGroovyMethods missing ...

2017-12-11 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/644#discussion_r156211571 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -3371,77 +3396,179 @@ public static Number count(byte[] self, Object value

[GitHub] groovy pull request #641: GROOVY-8402: GroovyScriptEngine.ScriptClassLoader ...

2017-12-03 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/641 GROOVY-8402: GroovyScriptEngine.ScriptClassLoader applies compilation… … customizers twice You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #625: GROOVY-8369: Statically compiled property access o...

2017-10-31 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/625 GROOVY-8369: Statically compiled property access on enum class throws… … NoSuchFieldError You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #619: GROOVY-8360: Enums that are inner classes should h...

2017-10-23 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/619#discussion_r146433436 --- Diff: src/test/gls/enums/EnumTest.groovy --- @@ -592,6 +592,80 @@ class EnumTest extends CompilableTestSupport { assert

[GitHub] groovy pull request #619: GROOVY-8360: Enums that are inner classes should h...

2017-10-19 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/619 GROOVY-8360: Enums that are inner classes should have the static clas… …s modifier You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-11 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/539#discussion_r116149015 --- Diff: src/test/org/codehaus/groovy/classgen/asm/sc/ArraysAndCollectionsStaticCompileTest.groovy --- @@ -128,6 +128,18 @@ class

[GitHub] groovy pull request #539: GROOVY-8074: Statically compiled dot property acce...

2017-05-07 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/539 GROOVY-8074: Statically compiled dot property accesses instance prope… …rty instead of Map property You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #537: GROOVY-8157: Flow typing doesn't work with assignm...

2017-05-06 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/537 GROOVY-8157: Flow typing doesn't work with assignment to a parameter You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy GROOVY

[GitHub] groovy pull request #536: Improve type inference/STC compatibility of Sql me...

2017-05-05 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/536 Improve type inference/STC compatibility of Sql methods with closure parameters This PR adds @ClosureParams to closure parameters of the following methods in Sql and DataSet: * asList

[GitHub] groovy pull request #518: GROOVY-8132: Owner properties should be preferred ...

2017-03-27 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/518 GROOVY-8132: Owner properties should be preferred over properties of … …@Delegate field * Add test for method delegation precedence You can merge this pull request into a Git repository

[GitHub] groovy pull request #487: GROOVY-8069: Annotation based logging of complex e...

2017-02-01 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/487 GROOVY-8069: Annotation based logging of complex expression in closur… …e throws GroovyCastException with SC. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #476: GROOVY-8033: spread property calls on non-list col...

2017-01-04 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/476 GROOVY-8033: spread property calls on non-list collections fail STC i… …n static methods You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils

[GitHub] groovy pull request #449: GROOVY-7932: generate bridge methods for private c...

2016-10-15 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/449 GROOVY-7932: generate bridge methods for private constructors during … …static compilation You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

2016-10-09 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/442#discussion_r82517775 --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule --- @@ -17,5 +17,5 @@ # IT IS A WORKAROUND FOR 2

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

2016-10-08 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/442 GROOVY-7953: property expressions for extension methods on primitives… … fail STC You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy

[GitHub] groovy pull request #436: GROOVY-7952: Property expressions for extension me...

2016-10-04 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/436 GROOVY-7952: Property expressions for extension methods starting with… … 'is' fail STC * Add support for 'is' getter method variants of GROOVY-5580 You can merge this

[GitHub] groovy pull request #362: GROOVY-7870: BinaryExpressionTransformer: Set line...

2016-07-02 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/362 GROOVY-7870: BinaryExpressionTransformer: Set line numbers on transfo… …rmed binary expressions You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request #348: Groovy7860 AutoImplement transform

2016-06-20 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/348#discussion_r67703766 --- Diff: src/main/groovy/transform/Undefined.java --- @@ -28,6 +28,10 @@ private Undefined() {} public static final String STRING

[GitHub] groovy pull request #351: GROOVY-7862: Statically compiled calls to protecte...

2016-06-15 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/351 GROOVY-7862: Statically compiled calls to protected methods of an out… …erclass' superclass result in IllegalAccessErrors You can merge this pull request into a Git repository by ru

[GitHub] groovy pull request #350: GROOVY-7863: Statically compiled calls to private ...

2016-06-14 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/350 GROOVY-7863: Statically compiled calls to private outer class methods… … fail with multiple levels of nesting You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request #346: GROOVY-7849: Verifier should be aware of array typ...

2016-06-02 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/346 GROOVY-7849: Verifier should be aware of array type covariance when c… …hecking overriding method return types You can merge this pull request into a Git repository by running: $ git pull

[GitHub] groovy pull request: GROOVY-7841: Assert fails when accessing part...

2016-05-25 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/338#discussion_r64561363 --- Diff: src/main/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java --- @@ -134,15 +134,19 @@ public void visit(final

[GitHub] groovy pull request: GROOVY-7841: Assert fails when accessing part...

2016-05-24 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/338#discussion_r64490605 --- Diff: src/main/org/codehaus/groovy/transform/sc/transformers/BooleanExpressionTransformer.java --- @@ -134,15 +134,19 @@ public void visit(final

[GitHub] groovy pull request: GROOVY-7813: Calling a non-static outer class...

2016-04-10 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/310 GROOVY-7813: Calling a non-static outer class method from a static cl… …ass should fail STC You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request: GROOVY-7813: Calling a non-static outer class...

2016-04-10 Thread shils
Github user shils closed the pull request at: https://github.com/apache/groovy/pull/309 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] groovy pull request: CliBuilder enhancements

2016-04-09 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/308#discussion_r59120922 --- Diff: src/main/groovy/cli/Unparsed.java --- @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] groovy pull request: GROOVY-7813: Calling a non-static outer class...

2016-04-09 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/309 GROOVY-7813: Calling a non-static outer class method from a static cl… …ass should fail STC You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request: GROOVY-7804: Coercion of parameterless closur...

2016-04-05 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/306 GROOVY-7804: Coercion of parameterless closure to generic SAM type th… …rows NPE during STC You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request: make private fields final where possible

2016-03-14 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/292#discussion_r56113728 --- Diff: src/main/groovy/grape/GrapeIvy.groovy --- @@ -76,11 +76,11 @@ class GrapeIvy implements GrapeEngine { Set resolvedDependencies Set

[GitHub] groovy pull request: GROOVY-7758: GroovyCastException when both @C...

2016-03-14 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/294 GROOVY-7758: GroovyCastException when both @CompileStatic and @Newify… … are used You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy

[GitHub] groovy pull request: GROOVY-7312 Add ACC_STATIC flag to inner clas...

2016-02-09 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/257#discussion_r52389570 --- Diff: src/main/org/codehaus/groovy/classgen/asm/ClosureWriter.java --- @@ -80,7 +80,11 @@ public void writeClosure(ClosureExpression expression

[GitHub] groovy pull request: GROOVY-7312 Add ACC_STATIC flag to inner clas...

2016-02-09 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/257 GROOVY-7312 Add ACC_STATIC flag to inner classes of interfaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy GROOVY-7312

[GitHub] groovy pull request: GROOVY-7742 - Stackoverflow when method param...

2016-02-07 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/253#discussion_r52126075 --- Diff: src/test/groovy/transform/stc/GenericsSTCTest.groovy --- @@ -1800,6 +1800,19 @@ assert result == 'ok' ''' }

[GitHub] groovy pull request: GROOVY-7742 - Stackoverflow when method param...

2016-02-07 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/253#discussion_r52125211 --- Diff: src/test/groovy/transform/stc/GenericsSTCTest.groovy --- @@ -1800,6 +1800,19 @@ assert result == 'ok' ''' }

[GitHub] groovy pull request: GROOVY-7558 Add private field accessors and b...

2016-01-19 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/242#discussion_r50188030 --- Diff: src/main/org/codehaus/groovy/transform/sc/StaticCompilationVisitor.java --- @@ -123,9 +123,20 @@ public void visitClass(final ClassNode node

[GitHub] groovy pull request: GROOVY-7558 Add private field accessors and b...

2016-01-16 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/242 GROOVY-7558 Add private field accessors and bridge methods to dynamic… … classes with statically compiled inner classes You can merge this pull request into a Git repository by running

[GitHub] groovy pull request: GROOVY-7705: Add bridge methods for setting p...

2015-12-29 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/229 GROOVY-7705: Add bridge methods for setting private fields of outer c… …lass from inner class or closure You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] groovy pull request: GROOVY-7036: An interface implementation (ove...

2015-12-28 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/228 GROOVY-7036: An interface implementation (override) with a method inc… …luding a default parameter value does not compile You can merge this pull request into a Git repository by running

[GitHub] groovy pull request: GROOVY-7702: @CompileStatic and the method wi...

2015-12-28 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/227 GROOVY-7702: @CompileStatic and the method with(Closure) seem to dete… …rmine wrong type You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils

[GitHub] groovy pull request: GROOVY-7717 StaticTypeCheckingTestCase#should...

2015-12-20 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/217 GROOVY-7717 StaticTypeCheckingTestCase#shouldFailWithMessages erroneo… …usly passes *StaticTypeCheckingTestCase: shouldFailWithMessages should only pass if all and only the expected

[GitHub] groovy pull request: GROOVY-6958 null != NullObject when using cat...

2015-12-08 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/207 GROOVY-6958 null != NullObject when using categories You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/incubator-groovy GROOVY-6958

[GitHub] groovy pull request: GROOVY-7698 Safe navigation is broken for pro...

2015-12-01 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/201 GROOVY-7698 Safe navigation is broken for property style non-syntheti… …c setter calls under static compilation You can merge this pull request into a Git repository by running: $ git pull