[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-489298692 @paulk-asert All tests pass :-) This is an automated message f

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-489297126 @paulk-asert I'm verifying the case you mentioned, i.e. generating stubs with `GenerateStubsTask`: https://travis-ci.org/da

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-489044849 @paulk-asert I find `GenerateStubsTask` is not used any more: https://github.com/apache/groovy/blob/master/subprojects/groov

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482805844 OK. I will wait you, Paul 😉 This is an automated message from the

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482779742 @blackdrag @paulk-asert To sum up, the current implementation supports compiling Java stubs(in-memory and in-file) in the s

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482642708 @blackdrag As far as I know, `javax.tools.JavaCompiler` is a normal official API and will not stop working suddenly, isn't it?

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482640324 @blackdrag Jochen, in-memory compilation is still supported, but in-file compilation is changed to rely on the same API, e.g. `

[GitHub] [groovy] danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API

danielsun1106 commented on issue #904: GROOVY-9067: Compile Java stubs with standard API URL: https://github.com/apache/groovy/pull/904#issuecomment-482633625 @paulk-asert @blackdrag Please set aside some time to review the PR. --