[GitHub] [groovy] paulk-asert commented on pull request #1671: Add equals() and hashCode() methods to the ImportNode class.

2022-01-20 Thread GitBox
paulk-asert commented on pull request #1671: URL: https://github.com/apache/groovy/pull/1671#issuecomment-1018214007 Merged with the suggested hashCode modification. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [groovy] paulk-asert commented on pull request #1671: Add equals() and hashCode() methods to the ImportNode class.

2022-01-13 Thread GitBox
paulk-asert commented on pull request #1671: URL: https://github.com/apache/groovy/pull/1671#issuecomment-1012804336 Given that the `ImportNode` is _slightly_ mutable, via `setType`, you would need to reset the `hashCode` cache in the `setType` method, or not cache, but just resetting