[GitHub] groovy pull request #723: GROOVY-8601: Groovy should have a runner for JUnit...

2018-05-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/723 GROOVY-8601: Groovy should have a runner for JUnit5 tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8601 Alt

[GitHub] groovy pull request #720: GROOVY-8601: Groovy should have a runner for JUnit...

2018-05-24 Thread paulk-asert
Github user paulk-asert closed the pull request at: https://github.com/apache/groovy/pull/720 ---

[GitHub] groovy pull request #722: Request YourKit Java Profiler Open Source License

2018-05-24 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/722 Request YourKit Java Profiler Open Source License Here is the link to YourKit and search "Open source project license" in the page: https://www.yourkit.com/purchase/ **

[GitHub] groovy pull request #721: GROOVY-8604: Cache the parameterized type for bett...

2018-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/721 ---

[GitHub] groovy pull request #721: Cache the parameterized info for better performanc...

2018-05-24 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/721 Cache the parameterized info for better performance Finding the parameterized type is expensive, so it's better to cache it. You can merge this pull request into a Git repository by running:

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/717 ---

[GitHub] groovy pull request #720: GROOVY-8601: Groovy should have a runner for JUnit...

2018-05-24 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/720 GROOVY-8601: Groovy should have a runner for JUnit5 tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy6801 Alt

[GitHub] groovy pull request #714: GROOVY-8586: Support Java 9 ARM blocks

2018-05-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/714 ---

[GitHub] groovy pull request #719: Optimize generation of Groovydoc

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/719 ---

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-23 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/717#discussion_r190359768 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -596,6 +597,26 @@ public void visitVariableExpression(

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-23 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/717#discussion_r190359237 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -596,6 +597,26 @@ public void visitVariableExpression(

[GitHub] groovy pull request #716: GROOVY-8596: SqlGroovyMethods could be moved to av...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/716 ---

[GitHub] groovy pull request #715: GROOVY-8593: DocGenerator could be moved to avoid ...

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/715 ---

[GitHub] groovy pull request #719: Optimize generation of Groovydoc

2018-05-23 Thread melix
GitHub user melix opened a pull request: https://github.com/apache/groovy/pull/719 Optimize generation of Groovydoc There's a lot to say about Groovydoc, but worst of all, its performance is terrible. This PR is an attempt to fix part of it. Before my changes: https://scans

[GitHub] groovy pull request #718: GROOVY-8599: Bump ivy to 2.5.0-rc1

2018-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/718 ---

[GitHub] groovy pull request #718: Bump ivy to 2.5.0-rc1

2018-05-23 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/718 Bump ivy to 2.5.0-rc1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy bump-ivy-2.5.0-rc1 Alternatively you can revie

[GitHub] groovy pull request #717: Groovy 8562 wrong closure delegation for property ...

2018-05-23 Thread MeneDev
GitHub user MeneDev opened a pull request: https://github.com/apache/groovy/pull/717 Groovy 8562 wrong closure delegation for property access and compile static Roundup: The StaticTypeCheckingVisitor would not look consider FieldNode to potentially delegate to a different F

[GitHub] groovy pull request #713: GROOVY-8590: STC incorrectly infers type of nested...

2018-05-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/713 ---

[GitHub] groovy pull request #716: GROOVY-8596: SqlGroovyMethods could be moved to av...

2018-05-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/716 GROOVY-8596: SqlGroovyMethods could be moved to avoid split packages … …- part (1) You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-

[GitHub] groovy pull request #715: GROOVY-8593: DocGenerator could be moved to avoid ...

2018-05-22 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/715 GROOVY-8593: DocGenerator could be moved to avoid split packages You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy85

[GitHub] groovy pull request #:

2018-05-21 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/869c365161457c050d5a54c7ff43d73d3263f34e#commitcomment-29066081 thanks! ---

[GitHub] groovy pull request #:

2018-05-21 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b0d79332a3e897e821e62983ba38e5d926fa7cdd#commitcomment-29062398 author is not blank ;-) ---

[GitHub] groovy pull request #714: GROOVY-8586: Support Java 9 ARM blocks

2018-05-21 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/714 GROOVY-8586: Support Java 9 ARM blocks You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GROOVY-8586 Alternatively you

[GitHub] groovy pull request #:

2018-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/869c365161457c050d5a54c7ff43d73d3263f34e#commitcomment-29055018 I've synchronized your changes to https://github.com/danielsun1106/groovy-parser with your contribution info kept ;-)

[GitHub] groovy pull request #713: GROOVY-8590: STC incorrectly infers type of nested...

2018-05-19 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/713 GROOVY-8590: STC incorrectly infers type of nested method call used i… …n a return stmt You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #712: GROOVY-8171: Escaped dollar slashy difference betw...

2018-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/712 ---

[GitHub] groovy pull request #712: GROOVY-8171: Escaped dollar slashy difference betw...

2018-05-19 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/712 GROOVY-8171: Escaped dollar slashy difference between old and parrot … …parsers You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenl

[GitHub] groovy pull request #711: GROOVY-8589 bugfix: should not show error about mi...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/711 ---

[GitHub] groovy pull request #710: GROOVY-8588 use lowercase -v for --version in groo...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/710 ---

[GitHub] groovy pull request #711: GROOVY-8589 bugfix: should not show error about mi...

2018-05-18 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/711 GROOVY-8589 bugfix: should not show error about missing mandatory args when --help or --version is specified GROOVY-8589 bugfix: should not show error about missing mandatory args when --help or --v

[GitHub] groovy pull request #710: GROOVY-8588 use lowercase -v for --version in groo...

2018-05-18 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/710 GROOVY-8588 use lowercase -v for --version in groovyc to be consistent with other Groovy command line tools GROOVY-8588 use lowercase -v for --version in groovyc to be consistent with other Groovy c

[GitHub] groovy pull request #707: GROOVY-8509: SC error call to protected method fro...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/707 ---

[GitHub] groovy pull request #701: GROOVY-8520 fixes (attempt 3)

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/701 ---

[GitHub] groovy pull request #:

2018-05-18 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c2cea059fecc3bc4a2c01adc6a30d2a1508bd64b#commitcomment-29031873 author is not blank 😉 ---

[GitHub] groovy pull request #709: GROOVY-8579: No bytecode level check is done befor...

2018-05-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/709 ---

[GitHub] groovy pull request #702: GROOVY-8569 GroovyMain picocli migration

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/702 ---

[GitHub] groovy pull request #704: GROOVY-8577 Migrate org.codehaus.groovy.tools.Grap...

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/704 ---

[GitHub] groovy pull request #:

2018-05-17 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c9eea7c30ececdc0a24939fb780c56c27eec798f#commitcomment-29020550 GROOVY-4151 test has been recovered by https://github.com/apache/groovy/commit/ef2fbe68d25ae7dce57ee2580c975c54e3dbaace --

[GitHub] groovy pull request #703: GROOVY-8567 Migrate Groovyc to picocli

2018-05-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/703 ---

[GitHub] groovy pull request #709: GROOVY-8579: No bytecode level check is done befor...

2018-05-17 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/709 GROOVY-8579: No bytecode level check is done before producing JDK8+ b… …ytecode You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-ase

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-17 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188869080 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -4101,13 +4101,17 @@ protected static ClassNode getGroupO

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188837462 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188832656 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188826337 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188825988 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -4101,13 +4101,17 @@ protected static ClassNode getGr

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188822722 --- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy --- @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188821809 --- Diff: src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java --- @@ -4101,13 +4101,17 @@ protected static ClassNode getGroupO

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread blackdrag
Github user blackdrag commented on a diff in the pull request: https://github.com/apache/groovy/pull/708#discussion_r188821671 --- Diff: src/main/java/org/codehaus/groovy/classgen/asm/sc/StaticInvocationWriter.java --- @@ -468,7 +469,11 @@ protected void loadArguments(List argume

[GitHub] groovy pull request #708: GROOVY-6668: Static compiler doesn't coerce GStrin...

2018-05-16 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/708 GROOVY-6668: Static compiler doesn't coerce GString for getAt() call You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy

[GitHub] groovy pull request #707: GROOVY-8509: SC error call to protected method fro...

2018-05-16 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/707 GROOVY-8509: SC error call to protected method from same package Because they were closely related, this PR also includes the following: 1. A change to the fix introduced by GROOVY-788

[GitHub] groovy pull request #:

2018-05-15 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/b1d1232770aade9672668df4dbc6aa2e2076fa9e#commitcomment-28988363 In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java: In subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java

[GitHub] groovy pull request #706: GROOVY-8355: Instanceof inference does not work on...

2018-05-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/706 ---

[GitHub] groovy pull request #706: GROOVY-8355: Instanceof inference does not work on...

2018-05-15 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/706 GROOVY-8355: Instanceof inference does not work on field assigning You can merge this pull request into a Git repository by running: $ git pull https://github.com/danielsun1106/groovy GR

[GitHub] groovy pull request #704: GROOVY-8577 Migrate org.codehaus.groovy.tools.Grap...

2018-05-14 Thread remkop
Github user remkop commented on a diff in the pull request: https://github.com/apache/groovy/pull/704#discussion_r188142573 --- Diff: src/main/groovy/org/codehaus/groovy/tools/GrapeMain.groovy --- @@ -19,290 +19,323 @@ package org.codehaus.groovy.tools import groovy.

[GitHub] groovy pull request #:

2018-05-14 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/62f877abd28c62e3058a383905bb93624ef36130#commitcomment-28966636 Weird, I had to reset again. Seems okay now. I don't know how it keeps coming back. Maybe I just need to do a fresh reinstall

[GitHub] groovy pull request #:

2018-05-14 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/62f877abd28c62e3058a383905bb93624ef36130#commitcomment-28966000 @paulk-asert author is not blank again? o_O ---

[GitHub] groovy pull request #705: GROOVY-7883 Static compiler prefers private constr...

2018-05-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/705 ---

[GitHub] groovy pull request #705: GROOVY-7883 Static compiler prefers private constr...

2018-05-11 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/705#discussion_r187764707 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java --- @@ -3973,7 +3973,7 @@ protected final ResultSet executePreparedQuery(String sql,

[GitHub] groovy pull request #705: GROOVY-7883 Static compiler prefers private constr...

2018-05-11 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/705 GROOVY-7883 Static compiler prefers private constructor over public … …if private matches be You can merge this pull request into a Git repository by running: $ git pull https://gith

[GitHub] groovy pull request #704: GROOVY-8577 Migrate org.codehaus.groovy.tools.Grap...

2018-05-11 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/704 GROOVY-8577 Migrate org.codehaus.groovy.tools.GrapeMain.groovy to picocli GROOVY-8577 Migrate org.codehaus.groovy.tools.GrapeMain.groovy to picocli You can merge this pull request into a Git reposito

[GitHub] groovy pull request #:

2018-05-11 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/3f650cc681cf1702860a47247bfa728c4c793ef8#commitcomment-28943972 It was changed again! Weird, I've never set that field myself. ---

[GitHub] groovy pull request #:

2018-05-11 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/3f650cc681cf1702860a47247bfa728c4c793ef8#commitcomment-28943410 @paulk-asert author field is not blank again? ;-) ---

[GitHub] groovy pull request #700: GROOVY-8576 Remove Java2GroovyMain dependency on c...

2018-05-10 Thread remkop
Github user remkop closed the pull request at: https://github.com/apache/groovy/pull/700 ---

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-10 Thread remkop
Github user remkop closed the pull request at: https://github.com/apache/groovy/pull/694 ---

[GitHub] groovy pull request #703: GROOVY-8567 Migrate Groovyc to picocli

2018-05-10 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/703 GROOVY-8567 Migrate Groovyc to picocli Migrate groovyc to picocli. Rebased and squashed commits. This PR replaces #694. You can merge this pull request into a Git repository by running: $ g

[GitHub] groovy pull request #697: GROOVY-8569 GroovyMain picocli migration

2018-05-10 Thread remkop
Github user remkop closed the pull request at: https://github.com/apache/groovy/pull/697 ---

[GitHub] groovy pull request #702: GROOVY-8569 GroovyMain picocli migration

2018-05-10 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/702 GROOVY-8569 GroovyMain picocli migration Migrate `groovy.ui.GroovyMain` from commons-cli to picocli. Replaces PR #697 You can merge this pull request into a Git repository by running: $ git

[GitHub] groovy pull request #696: GROOVY-8520 fixes (attempt 2)

2018-05-10 Thread remkop
Github user remkop closed the pull request at: https://github.com/apache/groovy/pull/696 ---

[GitHub] groovy pull request #701: GROOVY-8520 fixes (attempt 3)

2018-05-10 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/701 GROOVY-8520 fixes (attempt 3) Rebased on master, replaces PR #696 You can merge this pull request into a Git repository by running: $ git pull https://github.com/remkop/groovy GROOVY-8520-fixes(

[GitHub] groovy pull request #700: GROOVY-8576 Remove Java2GroovyMain dependency on c...

2018-05-10 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/700 GROOVY-8576 Remove Java2GroovyMain dependency on commons-cli `org.codehaus.groovy.antlr.java.Java2GroovyMain` can be simplified by removing its dependency on commons-cli: it does not have any options

[GitHub] groovy pull request #698: Add documentation for metaclasses

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/698 ---

[GitHub] groovy pull request #699: GROOVY-7204: Static type checking and compilation ...

2018-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/699 ---

[GitHub] groovy pull request #699: GROOVY-7204: Static type checking and compilation ...

2018-05-09 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/699 GROOVY-7204: Static type checking and compilation fail when multiple … …generics in use You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #:

2018-05-08 Thread bsideup
Github user bsideup commented on the pull request: https://github.com/apache/groovy/commit/33be1e1d51dd0b238ee551eff0c46a2306b7e339#commitcomment-28897694 In subprojects/groovy-macro/src/main/groovy/org/codehaus/groovy/macro/methods/MacroGroovyMethods.java: In subprojects/groovy-

[GitHub] groovy pull request #698: Add documentation for metaclasses

2018-05-08 Thread ecerulm
GitHub user ecerulm opened a pull request: https://github.com/apache/groovy/pull/698 Add documentation for metaclasses You can merge this pull request into a Git repository by running: $ git pull https://github.com/ecerulm/groovy metaclassdoc2 Alternatively you can review and

[GitHub] groovy pull request #697: GROOVY-8569 GroovyMain picocli migration

2018-05-06 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/697 GROOVY-8569 GroovyMain picocli migration Migrate `groovy.ui.GroovyMain` from commons-cli to picocli. You can merge this pull request into a Git repository by running: $ git pull https://github.c

[GitHub] groovy pull request #696: GROOVY-8520 fixes (attempt 2)

2018-05-06 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/696 GROOVY-8520 fixes (attempt 2) * add CliBuilder.setParser and setFormatter methods that ignore the specified values and print a warning to stderr to easy the transition for existing applications

[GitHub] groovy pull request #695: GROOVY-8520 fixes

2018-05-06 Thread remkop
Github user remkop closed the pull request at: https://github.com/apache/groovy/pull/695 ---

[GitHub] groovy pull request #695: GROOVY-8520 fixes

2018-05-06 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/695 GROOVY-8520 fixes * add CliBuilder.setParser and setFormatter methods that ignore the specified values and print a warning to stderr to easy the transition for existing applications * bugfix: @U

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-06 Thread remkop
Github user remkop commented on a diff in the pull request: https://github.com/apache/groovy/pull/694#discussion_r186292414 --- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java --- @@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception {

[GitHub] groovy pull request #:

2018-05-04 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28863337 That's it! I was wondering how it got in there. I had checked all my git config from the cmd line. I don't remember ever filli

[GitHub] groovy pull request #:

2018-05-04 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28855880 @paulk-asert you can check whether the Author field in the commit dialog of IntelliJ IDEA is blank. ---

[GitHub] groovy pull request #:

2018-05-04 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/c80d02b13005efd87eb69ca66958def9becc56e1#commitcomment-28855805 @paulk-asert I have not contributed the commit... ---

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-04 Thread remkop
Github user remkop commented on a diff in the pull request: https://github.com/apache/groovy/pull/694#discussion_r186035996 --- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java --- @@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception {

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-04 Thread remkop
Github user remkop commented on a diff in the pull request: https://github.com/apache/groovy/pull/694#discussion_r186035195 --- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java --- @@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception {

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-04 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/694#discussion_r186015829 --- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java --- @@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception {

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-04 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/694#discussion_r186015291 --- Diff: src/main/java/org/codehaus/groovy/tools/FileSystemCompiler.java --- @@ -77,18 +73,6 @@ public void compile(File[] files) throws Exception {

[GitHub] groovy pull request #694: GROOVY-8567 Migrate Groovyc to picocli

2018-05-04 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/694 GROOVY-8567 Migrate Groovyc to picocli GROOVY-8567 Migrate Groovyc to picocli See comments in the JIRA ticket. You can merge this pull request into a Git repository by running: $ git pu

[GitHub] groovy pull request #693: Allow methodMissing/propertyMissing to be defined ...

2018-05-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/693 ---

[GitHub] groovy pull request #693: Allow methodMissing/propertyMissing to be defined ...

2018-05-03 Thread ecerulm
Github user ecerulm commented on a diff in the pull request: https://github.com/apache/groovy/pull/693#discussion_r185943651 --- Diff: src/main/groovy/groovy/lang/MetaClassImpl.java --- @@ -945,6 +945,15 @@ private Object invokeMissingMethod(Object instance, String methodName, Obje

[GitHub] groovy pull request #693: Allow methodMissing/propertyMissing to be defined ...

2018-05-03 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/693#discussion_r185901767 --- Diff: src/main/groovy/groovy/lang/MetaClassImpl.java --- @@ -945,6 +945,15 @@ private Object invokeMissingMethod(Object instance, String methodName

[GitHub] groovy pull request #693: Allow methodMissing/propertyMissing to be defined ...

2018-05-03 Thread ecerulm
GitHub user ecerulm opened a pull request: https://github.com/apache/groovy/pull/693 Allow methodMissing/propertyMissing to be defined through category Resolves GROOVY-3867 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ecerulm/g

[GitHub] groovy pull request #:

2018-05-01 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/aa1ad8fe2ab2c37a0b95215e692e73bdc37297f7#commitcomment-28813835 It was me - I am not sure how your name got there. I'll have to check whether my git config is messed up. ---

[GitHub] groovy pull request #:

2018-05-01 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/aa1ad8fe2ab2c37a0b95215e692e73bdc37297f7#commitcomment-28806379 weird... I have not contributed such a change, but the author is me... ---

[GitHub] groovy pull request #692: GROOVY-8520 CliBuilder groovydoc improvements

2018-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/692 ---

[GitHub] groovy pull request #692: GROOVY-8520 CliBuilder groovydoc improvements

2018-04-29 Thread remkop
GitHub user remkop opened a pull request: https://github.com/apache/groovy/pull/692 GROOVY-8520 CliBuilder groovydoc improvements Groovy-doc improvements for CliBuilder. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remkop/groov

[GitHub] groovy pull request #688: GROOVY-8520 add picocli-based CliBuilder

2018-04-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/688 ---

[GitHub] groovy pull request #691: Support java-like array

2018-04-26 Thread danielsun1106
GitHub user danielsun1106 opened a pull request: https://github.com/apache/groovy/pull/691 Support java-like array ## Background In order to improve the compatibility with Java(Copy & Paste), Java array is one of features widely applied in Java projects. The PR will make Groovy

[GitHub] groovy pull request #:

2018-04-24 Thread paulk-asert
Github user paulk-asert commented on the pull request: https://github.com/apache/groovy/commit/5443e87882f9b88169876f6d043ed54b5ae9023b#commitcomment-28711056 In src/main/java/org/codehaus/groovy/control/CompilerConfiguration.java: In src/main/java/org/codehaus/groovy/control/Compi

[GitHub] groovy pull request #690: GROOVY-8558: Add DGM `whichJar` to get the url of ...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/690 ---

<    1   2   3   4   5   6   7   8   9   10   >