[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/679 ---

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178422703 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178422137 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider value

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178421232 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178421035 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -199,20 +208,35 @@ public int size() { return doW

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178421016 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider value

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178419989 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -199,20 +208,35 @@ public int size() { return d

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread danielsun1106
Github user danielsun1106 commented on a diff in the pull request: https://github.com/apache/groovy/pull/679#discussion_r178419950 --- Diff: src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java --- @@ -175,6 +174,11 @@ private V compute(K key, ValueProvider val

[GitHub] groovy pull request #679: GROOVY-8525: Binary compatibility issue for Groovy...

2018-03-30 Thread paulk-asert
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/679 GROOVY-8525: Binary compatibility issue for GroovyClassLoader between… … 2.4 vs later branches (alternative to PR#678) What I haven't yet checked is whether we need to make some of t