Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-27 Thread via GitHub
paulk-asert commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1783659833 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-26 Thread via GitHub
paulk-asert merged PR #1973: URL: https://github.com/apache/groovy/pull/1973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-26 Thread via GitHub
pinicarus commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1780972154 > It would be better if you could provide the related test as well. I added the range bounds to the existing test -- This is an automated message from the Apache Git Service. To

Re: [PR] fix(XmlUtil): escapeControlCharacters off-by-one bug [groovy]

2023-10-22 Thread via GitHub
daniellansun commented on PR #1973: URL: https://github.com/apache/groovy/pull/1973#issuecomment-1774077583 It would be better if you could provide the related test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and