[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-30 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748948#comment-17748948 ] Daniel Sun commented on GROOVY-10931: - [~emilles] I have checked the builds of master, no new

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747148#comment-17747148 ] Eric Milles commented on GROOVY-10931: -- Okay, I see what I did -- "sender" was passed to

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-25 Thread Jochen Theodorou (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747119#comment-17747119 ] Jochen Theodorou commented on GROOVY-10931: --- [~emilles]If a method is not accessible and

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747109#comment-17747109 ] Eric Milles commented on GROOVY-10931: -- Here are the four test cases from {{IllegalAccessTests}}

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-25 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747100#comment-17747100 ] Eric Milles commented on GROOVY-10931: -- [~daniel_sun] [~blackdrag] [~paulk] I was looking over

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-23 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746070#comment-17746070 ] Eric Milles commented on GROOVY-10931: -- Groovy 4's {{MethodSelector}} does this: {code:java} try {

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746006#comment-17746006 ] Daniel Sun commented on GROOVY-10931: - Could you tell me how you make Groovy avoid illegal

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746003#comment-17746003 ] Eric Milles commented on GROOVY-10931: -- Yes that’s the 9586 that I’m looking at next. > Remove

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17746002#comment-17746002 ] Daniel Sun commented on GROOVY-10931: - I found a new warning in the JDK11 build for Groovy 5:

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745997#comment-17745997 ] Eric Milles commented on GROOVY-10931: -- I fixed the array and object clone issue and reduced the

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745965#comment-17745965 ] Eric Milles commented on GROOVY-10931: -- I think I've got the jist of which tests are doing illegal

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745939#comment-17745939 ] Eric Milles commented on GROOVY-10931: -- Here are all the warnings for a Groovy 4 / Java 11 build

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745928#comment-17745928 ] Daniel Sun commented on GROOVY-10931: - Hi Jochen,      Here is the code for transform method, i.e.

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-22 Thread Jochen Theodorou (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745918#comment-17745918 ] Jochen Theodorou commented on GROOVY-10931: --- [~daniel_sun] what do you mean by "transforming

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745870#comment-17745870 ] Daniel Sun commented on GROOVY-10931: - We find to find legal access ways through transforming

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745869#comment-17745869 ] Daniel Sun commented on GROOVY-10931: - As Groovy allows illegal reflection since it borned, Groovy

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745865#comment-17745865 ] Eric Milles commented on GROOVY-10931: -- Thanks for looking over the changes. I do plan to refine

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745863#comment-17745863 ] Eric Milles commented on GROOVY-10931: -- Also, if there are warnings on JDK below 16, are we really

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745861#comment-17745861 ] Eric Milles commented on GROOVY-10931: -- Is there a way to convert this into some kind of test?

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-07-21 Thread Daniel Sun (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745857#comment-17745857 ] Daniel Sun commented on GROOVY-10931: - Hi Eric,      $getLookup implementation can handle all

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-02-13 Thread Paul King (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17688181#comment-17688181 ] Paul King commented on GROOVY-10931: [~emilles] I think Grails would be a good codebase to try. I

[jira] [Commented] (GROOVY-10931) Remove $getLookup method generation (Groovy 4+)

2023-02-12 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17687591#comment-17687591 ] Eric Milles commented on GROOVY-10931: -- [~paulk] [~sunlan] Are you aware of any recent JDK16+ test