Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/176#discussion_r44361127
--- Diff:
subprojects/groovy-nio/src/main/java/org/codehaus/groovy/runtime/NioGroovyMethods.java
---
@@ -1540,12 +1709,33 @@ public static
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/176#discussion_r44361018
--- Diff: src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java
---
@@ -974,11 +1021,30 @@ public static void append(File self
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/176#discussion_r44360244
--- Diff: src/main/org/codehaus/groovy/runtime/ResourceGroovyMethods.java
---
@@ -831,9 +836,8 @@ public static File leftShift(File file
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/180
GROOVY-7524: Document that TupleConstructor and InheritConstructors
shouldn't be mixed
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/176
GROOVY-7465: ResourceGroovyMethods/NioGroovyMethods BOM behavior is
inconsistent
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/108
Document numeric conversions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy doc-num-assignment
Github user keeganwitt closed the pull request at:
https://github.com/apache/incubator-groovy/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/98
document numeric conversions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy doc-num-assignment
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/94#discussion_r37699872
--- Diff: src/spec/doc/core-differences-java.adoc ---
@@ -260,6 +260,19 @@ with exception.
include::{projectdir}/src/spec/test
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/94#discussion_r37699868
--- Diff: src/spec/doc/core-object-orientation.adoc ---
@@ -35,6 +35,51 @@ Groovy supports the same primitive types as those
defined by the {jls
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/94
Document primitive autowrapping
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy doc-primitives
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/89
GROOVY-7553: Path.write() appends when encoding parameter present
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r36213864
--- Diff:
src/test/org/codehaus/groovy/tools/stubgenerator/ImportStaticAliasTest.groovy
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user keeganwitt commented on the pull request:
https://github.com/apache/incubator-groovy/commit/971cee027b34b9e5d92ed6c8cce3c541af0974f6#commitcomment-12485147
In src/test/groovy/bugs/Groovy7520Bug.groovy:
In src/test/groovy/bugs/Groovy7520Bug.groovy on line 1:
Good
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r36015780
--- Diff:
src/test/org/codehaus/groovy/tools/stubgenerator/ImportStaticAliasTest.groovy
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/77#discussion_r35988461
--- Diff: src/spec/doc/core-metaprogramming.adoc ---
@@ -966,6 +966,25 @@
include::{projectdir}/src/spec/test
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r35987130
--- Diff:
src/test/org/codehaus/groovy/tools/stubgenerator/ImportStaticAliasTest.groovy
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r35987069
--- Diff: src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java
---
@@ -925,7 +931,8 @@ private void printImports(PrintWriter out
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/78
GROOVY-7520: Improve unimplemented message for abstract methods
c3a802fe13a6fc7267130db805940bd2be41b4f8 accidentally included #71 instead
of #68 in it's commit message. I'
Github user keeganwitt commented on the pull request:
https://github.com/apache/incubator-groovy/commit/c3a802fe13a6fc7267130db805940bd2be41b4f8#commitcomment-12453858
This commit actually closes #68. I messed up the commit message.
---
If your project is set up for it, you can
Github user keeganwitt closed the pull request at:
https://github.com/apache/incubator-groovy/pull/68
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r35878035
--- Diff: src/main/org/codehaus/groovy/tools/javac/JavaStubGenerator.java
---
@@ -925,7 +931,8 @@ private void printImports(PrintWriter out
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r35874858
--- Diff:
src/test/org/codehaus/groovy/tools/stubgenerator/ImportStaticAliasTest.groovy
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/76#discussion_r35873566
--- Diff:
src/test/org/codehaus/groovy/tools/stubgenerator/ImportStaticAliasTest.groovy
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/71
GROOVY-7520
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy GROOVY-7520
Alternatively you can review
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/68
GROOVY-7241
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy GROOVY-7241
Alternatively you can review
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/67
document ivy.message.logger.level
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy master
Alternatively
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34475088
--- Diff: src/main/groovy/util/Node.java ---
@@ -537,26 +539,40 @@ private NodeList getByName(String name
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34473051
--- Diff: src/main/groovy/util/Node.java ---
@@ -537,26 +539,40 @@ private NodeList getByName(String name
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34468924
--- Diff: src/test/groovy/tree/NavigationTest.groovy ---
@@ -22,29 +22,37 @@ package groovy.tree
* Simple test of tree walking
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34467403
--- Diff: src/test/groovy/tree/NavigationTest.groovy ---
@@ -22,29 +22,37 @@ package groovy.tree
* Simple test of tree walking
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34467023
--- Diff: src/main/groovy/util/Node.java ---
@@ -537,26 +539,40 @@ private NodeList getByName(String name
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34466245
--- Diff: src/test/groovy/tree/NavigationTest.groovy ---
@@ -22,29 +22,37 @@ package groovy.tree
* Simple test of tree walking
Github user keeganwitt commented on a diff in the pull request:
https://github.com/apache/incubator-groovy/pull/59#discussion_r34459936
--- Diff: src/test/groovy/tree/NavigationTest.groovy ---
@@ -57,11 +65,25 @@ class NavigationTest extends GroovyTestCase
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/57
Handled some more less-than and greater-than signs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/56
escaped less-than and greater-than signs in Javadoc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/keeganwitt/incubator-groovy
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/37
Remove NioGroovyMethods.newWriter JavaDoc erroneously stating UTF-16 BOM
will be written
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user keeganwitt opened a pull request:
https://github.com/apache/incubator-groovy/pull/36
fix for GROOVY-7461
I didn't see any unit tests for this method. Feel free to point them out
if I've missed it.
You can merge this pull request into a Git repository
38 matches
Mail list logo
