sanpwc commented on code in PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#discussion_r1371153951
##
modules/placement-driver-api/build.gradle:
##
@@ -28,6 +28,7 @@ dependencies {
implementation libs.jetbrains.annotations
testFixturesImplementation proje
sashapolo commented on code in PR #2747:
URL: https://github.com/apache/ignite-3/pull/2747#discussion_r1371207563
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/storage/InternalTableImpl.java:
##
@@ -306,7 +306,9 @@ private CompletableFuture enlistI
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371201785
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371195890
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371186415
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371185853
##
modules/schema/src/test/java/org/apache/ignite/internal/schema/BinaryTuplePrefixTest.java:
##
@@ -76,6 +78,81 @@ public void testInternalBufferReallocation() {
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1371186032
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,88 @@ public static BinaryTuplePrefix fromBinaryTuple(Binary
1ssqq1lxr opened a new issue, #11013:
URL: https://github.com/apache/ignite/issues/11013
graalvm package error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
ivandasch opened a new pull request, #11012:
URL: https://github.com/apache/ignite/pull/11012
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### T
sashapolo merged PR #2744:
URL: https://github.com/apache/ignite-3/pull/2744
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
vldpyatkov opened a new pull request, #2749:
URL: https://github.com/apache/ignite-3/pull/2749
https://issues.apache.org/jira/browse/IGNITE-20609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
timoninmaxim opened a new pull request, #11011:
URL: https://github.com/apache/ignite/pull/11011
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
##
sashapolo commented on code in PR #2698:
URL: https://github.com/apache/ignite-3/pull/2698#discussion_r1370558536
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##
@@ -2157,6 +2157,16 @@ protected CompletableFuture
handleChangeSta
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370521649
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370143022
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,88 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
alievmirza commented on code in PR #2743:
URL: https://github.com/apache/ignite-3/pull/2743#discussion_r1370471994
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZonesUtil.java:
##
@@ -274,16 +264,25 @@ static ByteArray zoneT
PakhomovAlexander merged PR #2746:
URL: https://github.com/apache/ignite-3/pull/2746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsub
xtern opened a new pull request, #2748:
URL: https://github.com/apache/ignite-3/pull/2748
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
###
rpuch opened a new pull request, #2747:
URL: https://github.com/apache/ignite-3/pull/2747
https://issues.apache.org/jira/browse/IGNITE-20727
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an
ygerzhedovich commented on code in PR #2740:
URL: https://github.com/apache/ignite-3/pull/2740#discussion_r1370359879
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlApiBaseTest.java:
##
@@ -360,18 +360,28 @@ private void checkMixedTransactions
ygerzhedovich commented on code in PR #2740:
URL: https://github.com/apache/ignite-3/pull/2740#discussion_r1370356225
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/QueryTransactionWrapperSelfTest.java:
##
@@ -49,15 +47,6 @@ public class QueryTransacti
AMashenkov commented on code in PR #2740:
URL: https://github.com/apache/ignite-3/pull/2740#discussion_r1370344550
##
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/QueryTransactionWrapperSelfTest.java:
##
@@ -49,15 +47,6 @@ public class QueryTransactionW
AMashenkov commented on code in PR #2740:
URL: https://github.com/apache/ignite-3/pull/2740#discussion_r1370316191
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlApiBaseTest.java:
##
@@ -360,18 +360,28 @@ private void checkMixedTransactions(Ma
valepakh opened a new pull request, #2746:
URL: https://github.com/apache/ignite-3/pull/2746
https://issues.apache.org/jira/browse/IGNITE-20099
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both
vldpyatkov commented on PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#issuecomment-1777234350
I see another issue that is connected with lease prolongation. The
leaseholder and the leaseholder ID represent one node.
But currently, our check does not require that the leashold
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370149962
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370139755
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370114023
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370110801
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffe
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370109038
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370109038
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370086530
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370086037
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Binar
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370084543
##
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java:
##
@@ -82,11 +82,24 @@ public BinaryTupleBuilder(int numElement
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370078996
##
modules/schema/src/test/java/org/apache/ignite/internal/schema/BinaryTuplePrefixTest.java:
##
@@ -76,6 +78,101 @@ public void testInternalBufferReallocation() {
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370077702
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffer
tkalkirill commented on code in PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#discussion_r1370064021
##
modules/placement-driver-api/src/main/java/org/apache/ignite/internal/placementdriver/ReplicaMeta.java:
##
@@ -19,29 +19,19 @@
import java.io.Serializable;
i
tkalkirill commented on code in PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#discussion_r1370062021
##
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java:
##
@@ -54,44 +60,53 @@ public class Lease implements Replica
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370039959
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffer
lowka opened a new pull request, #2745:
URL: https://github.com/apache/ignite-3/pull/2745
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
###
sanpwc commented on code in PR #2698:
URL: https://github.com/apache/ignite-3/pull/2698#discussion_r1370035986
##
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##
@@ -2157,6 +2157,16 @@ protected CompletableFuture
handleChangeStable
sanpwc commented on code in PR #2698:
URL: https://github.com/apache/ignite-3/pull/2698#discussion_r1370024842
##
modules/runner/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceDistributedTest.java:
##
@@ -583,6 +585,59 @@ void testRebalanceWithTheSameNo
sanpwc commented on code in PR #2698:
URL: https://github.com/apache/ignite-3/pull/2698#discussion_r1370022302
##
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##
@@ -482,6 +482,13 @@ public ClusterService clusterService() {
retur
sanpwc merged PR #2660:
URL: https://github.com/apache/ignite-3/pull/2660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@igni
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370011800
##
modules/binary-tuple/src/main/java/org/apache/ignite/internal/binarytuple/BinaryTupleBuilder.java:
##
@@ -82,11 +82,24 @@ public BinaryTupleBuilder(int numElements
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1370004161
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffe
sergeyuttsel commented on code in PR #2743:
URL: https://github.com/apache/ignite-3/pull/2743#discussion_r1369978961
##
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZonesUtil.java:
##
@@ -274,16 +264,25 @@ static ByteArray zon
vldpyatkov commented on code in PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#discussion_r136382
##
modules/placement-driver-api/src/main/java/org/apache/ignite/internal/placementdriver/ReplicaMeta.java:
##
@@ -19,29 +19,19 @@
import java.io.Serializable;
i
vldpyatkov commented on code in PR #2741:
URL: https://github.com/apache/ignite-3/pull/2741#discussion_r1369973246
##
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/Lease.java:
##
@@ -54,44 +60,53 @@ public class Lease implements Replica
AMashenkov merged PR #2734:
URL: https://github.com/apache/ignite-3/pull/2734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
korlov42 commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1369990552
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffer
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1369929444
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -73,6 +97,102 @@ public static BinaryTuplePrefix fromBinaryTuple(Bina
sashapolo commented on code in PR #2728:
URL: https://github.com/apache/ignite-3/pull/2728#discussion_r1369829525
##
modules/schema/src/main/java/org/apache/ignite/internal/schema/BinaryTuplePrefix.java:
##
@@ -51,13 +52,36 @@ public BinaryTuplePrefix(int elementCount, ByteBuffe
ptupitsyn merged PR #2739:
URL: https://github.com/apache/ignite-3/pull/2739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@i
xtern merged PR #2726:
URL: https://github.com/apache/ignite-3/pull/2726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignit
sashapolo opened a new pull request, #2744:
URL: https://github.com/apache/ignite-3/pull/2744
https://issues.apache.org/jira/browse/IGNITE-20720
* Move ClusterPerTestIntegrationTest and ClusterPerClassIntegrationTest to
Test Fixtures
* Extract SQL-specific features into a separate
alievmirza opened a new pull request, #2743:
URL: https://github.com/apache/ignite-3/pull/2743
https://issues.apache.org/jira/browse/IGNITE-20561
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask bot
skorotkov opened a new pull request, #11010:
URL: https://github.com/apache/ignite/pull/11010
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### T
sanpwc opened a new pull request, #2742:
URL: https://github.com/apache/ignite-3/pull/2742
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
###
59 matches
Mail list logo