[PR] IGNITE-21943: Cover SQL F561(Full value expressions) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
lowka opened a new pull request, #3641: URL: https://github.com/apache/ignite-3/pull/3641 Adds some tests related to full row expression support (row data type). https://issues.apache.org/jira/browse/IGNITE-22084 --- Thank you for submitting the pull request. To st

Re: [PR] IGNITE-21435: Sql. Catalog DefaultValue should not depend on Serializable. [ignite-3]

2024-04-19 Thread via GitHub
lowka commented on code in PR #3627: URL: https://github.com/apache/ignite-3/pull/3627#discussion_r1572614292 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogEntrySerializationTest.java: ## @@ -144,6 +174,85 @@ void test(MarshallableEntryType t

Re: [PR] IGNITE-21435: Sql. Catalog DefaultValue should not depend on Serializable. [ignite-3]

2024-04-19 Thread via GitHub
lowka commented on code in PR #3627: URL: https://github.com/apache/ignite-3/pull/3627#discussion_r1572613224 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogEntrySerializationTest.java: ## @@ -144,6 +174,85 @@ void test(MarshallableEntryType t

Re: [PR] IGNITE-22054 Fix ItMultipleLocksTest#test [ignite-3]

2024-04-19 Thread via GitHub
sanpwc merged PR #3632: URL: https://github.com/apache/ignite-3/pull/3632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[PR] Bump net.bytebuddy:byte-buddy from 1.14.12 to 1.14.13 [ignite-3]

2024-04-19 Thread via GitHub
dependabot[bot] opened a new pull request, #3639: URL: https://github.com/apache/ignite-3/pull/3639 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.14.12 to 1.14.13. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy

[PR] Bump com.github.spotbugs from 6.0.8 to 6.0.12 [ignite-3]

2024-04-19 Thread via GitHub
dependabot[bot] opened a new pull request, #3638: URL: https://github.com/apache/ignite-3/pull/3638 Bumps com.github.spotbugs from 6.0.8 to 6.0.12. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spot

[PR] IGNITE-22083 Invalidate fragment mapping cache when logical topology changes [ignite-3]

2024-04-19 Thread via GitHub
valepakh opened a new pull request, #3637: URL: https://github.com/apache/ignite-3/pull/3637 https://issues.apache.org/jira/browse/IGNITE-22083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] IGNITE-21939 Sql. Cover SQL F302-02(INTERSECT [ALL] table operator) feature by tests. [ignite-3]

2024-04-19 Thread via GitHub
xtern opened a new pull request, #3636: URL: https://github.com/apache/ignite-3/pull/3636 https://issues.apache.org/jira/browse/IGNITE-21939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] IGNITE-21940 Sql. Cover SQL F304(EXCEPT ALL table operator) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
xtern opened a new pull request, #3635: URL: https://github.com/apache/ignite-3/pull/3635 https://issues.apache.org/jira/browse/IGNITE-21940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-21763 Adjust TxnResourceVacuumTask in order to vacuum persistent txn state [ignite-3]

2024-04-19 Thread via GitHub
sanpwc commented on code in PR #3591: URL: https://github.com/apache/ignite-3/pull/3591#discussion_r1572498142 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java: ## @@ -406,18 +413,18 @@ private UpdateCommandResult handleUpd

Re: [PR] IGNITE-22080 Fix ConflictResolver fails on debug logging [ignite-extensions]

2024-04-19 Thread via GitHub
timoninmaxim merged PR #261: URL: https://github.com/apache/ignite-extensions/pull/261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-uns

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1572417317 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/rel/ExecutionTest.java: ## @@ -55,14 +57,16 @@ import org.junit.jupiter.params.Parameteri

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#issuecomment-2066643116 @korlov42 seems i complete with all of your issues -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] IGNITE-18647 Sql. Implement missed Statement and StatementBuilder methods. [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich commented on code in PR #3626: URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1572234816 ## modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/threading/ItSqlApiThreadingTest.java: ## @@ -135,7 +125,9 @@ void asyncResultSetFu

Re: [PR] IGNITE-21156 : Custom metrics introduction - renamins, minimal API [ignite]

2024-04-19 Thread via GitHub
Vladsz83 closed pull request #11216: IGNITE-21156 : Custom metrics introduction - renamins, minimal API URL: https://github.com/apache/ignite/pull/11216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] IGNITE-21156 : [IEP-114] Custom metrics introduction [ignite]

2024-04-19 Thread via GitHub
Vladsz83 closed pull request #11145: IGNITE-21156 : [IEP-114] Custom metrics introduction URL: https://github.com/apache/ignite/pull/11145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] IGNITE-21156 : Custom metrics introduction - Two IgniteMetrics interfaces [ignite]

2024-04-19 Thread via GitHub
Vladsz83 closed pull request #11221: IGNITE-21156 : Custom metrics introduction - Two IgniteMetrics interfaces URL: https://github.com/apache/ignite/pull/11221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Ignite\Work folder is getting saved to the path "C:\Windows\System32\ignite\work\log" after dotnet6 upgrade of the project [ignite]

2024-04-19 Thread via GitHub
sk0x50 closed issue #11005: Ignite\Work folder is getting saved to the path "C:\Windows\System32\ignite\work\log" after dotnet6 upgrade of the project URL: https://github.com/apache/ignite/issues/11005 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] Is there a function to obtain hotkeys implemented [ignite]

2024-04-19 Thread via GitHub
sk0x50 closed issue #10836: Is there a function to obtain hotkeys implemented URL: https://github.com/apache/ignite/issues/10836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Is there a function to obtain hotkeys implemented [ignite]

2024-04-19 Thread via GitHub
sk0x50 commented on issue #10836: URL: https://github.com/apache/ignite/issues/10836#issuecomment-2066530568 Hi @lvchongyi , There is no such API. It is unclear what the goal is and what you are trying to achieve, but anyway, the following two topics might be useful: - you c

Re: [PR] IGNITE-22080 Fix ConflictResolver fails on debug logging [ignite-extensions]

2024-04-19 Thread via GitHub
timoninmaxim commented on code in PR #261: URL: https://github.com/apache/ignite-extensions/pull/261#discussion_r1572314189 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/conflictresolve/DebugCacheVersionConflictResolverImpl.java: ## @@ -63,6 +63,16 @@ public DebugCacheV

Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich merged PR #3628: URL: https://github.com/apache/ignite-3/pull/3628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-22080 Fix ConflictResolver fails on debug logging [ignite-extensions]

2024-04-19 Thread via GitHub
dspavlov commented on code in PR #261: URL: https://github.com/apache/ignite-extensions/pull/261#discussion_r1572305786 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/conflictresolve/DebugCacheVersionConflictResolverImpl.java: ## @@ -63,6 +63,16 @@ public DebugCacheVersi

Re: [I] Ignite cluster (both client and server) breaking intermittently with 401 http code in AKS [ignite]

2024-04-19 Thread via GitHub
sk0x50 closed issue #10714: Ignite cluster (both client and server) breaking intermittently with 401 http code in AKS URL: https://github.com/apache/ignite/issues/10714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] IGNITE-22080 Fix ConflictResolver fails on debug logging [ignite-extensions]

2024-04-19 Thread via GitHub
timoninmaxim opened a new pull request, #261: URL: https://github.com/apache/ignite-extensions/pull/261 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] IGNITE-18647 Sql. Implement missed Statement and StatementBuilder methods. [ignite-3]

2024-04-19 Thread via GitHub
xtern commented on code in PR #3626: URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1572295214 ## modules/api/src/main/java/org/apache/ignite/sql/Statement.java: ## @@ -140,16 +113,22 @@ interface StatementBuilder { */ StatementBuilder pageSize(

Re: [PR] IGNITE-18647 Sql. Implement missed Statement and StatementBuilder methods. [ignite-3]

2024-04-19 Thread via GitHub
xtern commented on code in PR #3626: URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1572295214 ## modules/api/src/main/java/org/apache/ignite/sql/Statement.java: ## @@ -140,16 +113,22 @@ interface StatementBuilder { */ StatementBuilder pageSize(

Re: [PR] Bump archunit from 1.2.1 to 1.3.0 [ignite-3]

2024-04-19 Thread via GitHub
ptupitsyn merged PR #3623: URL: https://github.com/apache/ignite-3/pull/3623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump org.apache.calcite.avatica:avatica-core from 1.24.0 to 1.25.0 [ignite-3]

2024-04-19 Thread via GitHub
ptupitsyn merged PR #3624: URL: https://github.com/apache/ignite-3/pull/3624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [I] Is Ignite 2.16.0 impacted by CVE-2024-22243 ? [ignite]

2024-04-19 Thread via GitHub
ptupitsyn closed issue #11322: Is Ignite 2.16.0 impacted by CVE-2024-22243 ? URL: https://github.com/apache/ignite/issues/11322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Is Ignite 2.16.0 impacted by CVE-2024-22243 ? [ignite]

2024-04-19 Thread via GitHub
ptupitsyn commented on issue #11322: URL: https://github.com/apache/ignite/issues/11322#issuecomment-2066419979 > Applications that use `UriComponentsBuilder` Ignite does not use `UriComponentsBuilder` at all, not a single match in the source code: https://github.com/search?q=repo%3A

[PR] next candidate test [ignite-3]

2024-04-19 Thread via GitHub
denis-chudov opened a new pull request, #3634: URL: https://github.com/apache/ignite-3/pull/3634 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-21435: Sql. Catalog DefaultValue should not depend on Serializable. [ignite-3]

2024-04-19 Thread via GitHub
xtern commented on code in PR #3627: URL: https://github.com/apache/ignite-3/pull/3627#discussion_r1572230375 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogEntrySerializationTest.java: ## @@ -144,6 +174,85 @@ void test(MarshallableEntryType t

Re: [PR] IGNITE-21435: Sql. Catalog DefaultValue should not depend on Serializable. [ignite-3]

2024-04-19 Thread via GitHub
xtern commented on code in PR #3627: URL: https://github.com/apache/ignite-3/pull/3627#discussion_r1572234538 ## modules/catalog/src/test/java/org/apache/ignite/internal/catalog/storage/CatalogEntrySerializationTest.java: ## @@ -144,6 +174,85 @@ void test(MarshallableEntryType t

Re: [PR] IGNITE-18647 Sql. Implement missed Statement and StatementBuilder methods. [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich commented on code in PR #3626: URL: https://github.com/apache/ignite-3/pull/3626#discussion_r1572215705 ## modules/api/src/main/java/org/apache/ignite/sql/Statement.java: ## @@ -140,16 +113,22 @@ interface StatementBuilder { */ StatementBuilder p

Re: [PR] IGNITE-21996 Improve test coverage for ALTER COLUMN command. [ignite-3]

2024-04-19 Thread via GitHub
xtern merged PR #3631: URL: https://github.com/apache/ignite-3/pull/3631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich commented on code in PR #3628: URL: https://github.com/apache/ignite-3/pull/3628#discussion_r1572188895 ## modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test: ## @@ -0,0 +1,47 @@ +# name: sql/basic_queries/rename_columns_in _from

Re: [PR] IGNITE-21923: Cover SQL E051-09(Basic query specification, Rename columns in the FROM clause) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich commented on code in PR #3628: URL: https://github.com/apache/ignite-3/pull/3628#discussion_r1572188600 ## modules/sql-engine/src/integrationTest/sql/basic_queries/rename_columns_in _from.test: ## @@ -0,0 +1,47 @@ +# name: sql/basic_queries/rename_columns_in _from

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
ibessonov commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572170160 ## modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/recovery/ItDisasterRecoveryControllerTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the

[I] Is there any plan to support window aggregation in Calcite Query Engine [ignite]

2024-04-19 Thread via GitHub
asdfgh19 opened a new issue, #11321: URL: https://github.com/apache/ignite/issues/11321 ``` select "deptno", rank() over (order by "deptno") as r from "hr"."emps" ``` Calcite supports the above Sql, but Ignite's Calcite Query Engine does not support window aggregation syntax

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
ibessonov commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572157617 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/recovery/DisasterRecoveryApi.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-22072 : Fix the extensions for Custom Metrics [ignite-extensions]

2024-04-19 Thread via GitHub
NSAmelchev merged PR #260: URL: https://github.com/apache/ignite-extensions/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

Re: [PR] IGNITE-21935: Cover SQL E153(Updatable queries with subqueries) feature by tests [ignite-3]

2024-04-19 Thread via GitHub
ygerzhedovich merged PR #3630: URL: https://github.com/apache/ignite-3/pull/3630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572113222 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/disaster/DisasterRecoveryManager.java: ## @@ -357,36 +402,94 @@ private static LocalPartition

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572086692 ## modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/recovery/ItDisasterRecoveryControllerTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572079960 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/recovery/DisasterRecoveryApi.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572082418 ## modules/rest/src/integrationTest/java/org/apache/ignite/internal/rest/recovery/ItDisasterRecoveryControllerTest.java: ## @@ -0,0 +1,169 @@ +/* + * Licensed to the Apa

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572081388 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/recovery/GlobalPartitionStateResponse.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Soft

Re: [PR] IGNITE-21257 Introduce REST API for viewing partition states [ignite-3]

2024-04-19 Thread via GitHub
rpuch commented on code in PR #3614: URL: https://github.com/apache/ignite-3/pull/3614#discussion_r1572079536 ## modules/rest-api/src/main/java/org/apache/ignite/internal/rest/api/recovery/DisasterRecoveryApi.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foun

Re: [I] we need go client sdk [ignite]

2024-04-19 Thread via GitHub
ptupitsyn commented on issue #11313: URL: https://github.com/apache/ignite/issues/11313#issuecomment-2066093824 > are there any other usage scenarios for this in memory database? 1. It is not only in-memory, you can enable persistence or use third-party storage 2. All other use cas

Re: [I] we need go client sdk [ignite]

2024-04-19 Thread via GitHub
Linuxlovers commented on issue #11313: URL: https://github.com/apache/ignite/issues/11313#issuecomment-2066043299 So, after removing the transaction, are there any other usage scenarios for this in memory database? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] IGNITE-18991 Move stable/planned/pending assignments from table to distribution zone root keys [ignite-3]

2024-04-19 Thread via GitHub
alievmirza commented on code in PR #3422: URL: https://github.com/apache/ignite-3/pull/3422#discussion_r1571989887 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -99,6 +109,8 @@ public class LeaseTracker exten

Re: [PR] IGNITE-22069 Optimize entries expiration [ignite]

2024-04-19 Thread via GitHub
alex-plekhanov commented on code in PR #11319: URL: https://github.com/apache/ignite/pull/11319#discussion_r1571976486 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/tree/BPlusTree.java: ## @@ -2169,6 +2169,20 @@ public List remove(L lower,

Re: [PR] IGNITE-22069 Optimize entries expiration [ignite]

2024-04-19 Thread via GitHub
alex-plekhanov commented on code in PR #11319: URL: https://github.com/apache/ignite/pull/11319#discussion_r1571975582 ## modules/core/src/test/java/org/apache/ignite/internal/processors/cache/expiry/IgniteCacheExpiryPolicyTestSuite.java: ## @@ -57,7 +57,8 @@ IgniteCacheE

Re: [PR] IGNITE-22026 Fix incorrect retry logic in GridCacheIoManager send method [ignite]

2024-04-19 Thread via GitHub
timoninmaxim merged PR #11311: URL: https://github.com/apache/ignite/pull/11311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

Re: [PR] IGNITE-22069 Optimize entries expiration [ignite]

2024-04-19 Thread via GitHub
alex-plekhanov commented on code in PR #11319: URL: https://github.com/apache/ignite/pull/11319#discussion_r1571975220 ## modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheOffheapManager.java: ## @@ -1108,7 +1110,30 @@ private Metas getO

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1571932369 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/HashJoinPlannerTest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software F

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1571920626 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/IgniteHashJoin.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1571920426 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rel/IgniteHashJoin.java: ## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] IGNITE-21720 Sql. Implement hash join [ignite-3]

2024-04-19 Thread via GitHub
zstan commented on code in PR #3608: URL: https://github.com/apache/ignite-3/pull/3608#discussion_r1571919793 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/BaseSqlIntegrationTest.java: ## @@ -111,19 +111,29 @@ protected enum JoinType { NESTE