Re: [PR] IGNITE-22999 Fix NPE in the cache distribution command [ignite]

2024-09-19 Thread via GitHub
NSAmelchev merged PR #11490: URL: https://github.com/apache/ignite/pull/11490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2362020049 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
nizhikov commented on code in PR #11438: URL: https://github.com/apache/ignite/pull/11438#discussion_r1767488499 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -474,6 +446,9 @@ public void testNumericCon

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
nizhikov commented on code in PR #11438: URL: https://github.com/apache/ignite/pull/11438#discussion_r1767480551 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/AbstractTransactionalSqlTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to the A

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2362007983 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
nizhikov commented on code in PR #11438: URL: https://github.com/apache/ignite/pull/11438#discussion_r1767481113 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/ServerStatisticsIntegrationTest.java: ## @@ -484,23 +485,29 @@ protec

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2361927770 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
alex-plekhanov commented on code in PR #11438: URL: https://github.com/apache/ignite/pull/11438#discussion_r1767346588 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/AbstractTransactionalSqlTest.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
sanpwc merged PR #4425: URL: https://github.com/apache/ignite-3/pull/4425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

[PR] Bump net.java.dev.jna:jna from 5.14.0 to 5.15.0 [ignite-3]

2024-09-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4428: URL: https://github.com/apache/ignite-3/pull/4428 Bumps [net.java.dev.jna:jna](https://github.com/java-native-access/jna) from 5.14.0 to 5.15.0. Changelog Sourced from https://github.com/java-native-access/jna/blob/master/CHANGES.md

[PR] Bump com.netflix.nebula.ospackage from 11.9.1 to 11.10.0 [ignite-3]

2024-09-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4427: URL: https://github.com/apache/ignite-3/pull/4427 Bumps com.netflix.nebula.ospackage from 11.9.1 to 11.10.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.

[PR] Bump org.threeten:threetenbp from 1.6.9 to 1.7.0 [ignite-3]

2024-09-19 Thread via GitHub
dependabot[bot] opened a new pull request, #4426: URL: https://github.com/apache/ignite-3/pull/4426 Bumps [org.threeten:threetenbp](https://github.com/ThreeTen/threetenbp) from 1.6.9 to 1.7.0. Release notes Sourced from https://github.com/ThreeTen/threetenbp/releases";>org.threeten

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2361380210 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
denis-chudov commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1767061013 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -609,17 +608,14 @@ private CompletableFuture stopLeaseProlon

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
denis-chudov commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1767061013 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -609,17 +608,14 @@ private CompletableFuture stopLeaseProlon

Re: [PR] IGNITE-23179 : Calcite. Wrong numeric type coercion with 'IS DISTINCT FROM' [ignite]

2024-09-19 Thread via GitHub
alex-plekhanov commented on code in PR #11525: URL: https://github.com/apache/ignite/pull/11525#discussion_r1766783910 ## modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/DataTypesTest.java: ## @@ -450,6 +453,105 @@ public void testDe

Re: [PR] IGNITE-23202 Fix server node fail when nodeFilter class unknown [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11539: URL: https://github.com/apache/ignite/pull/11539#issuecomment-2361063581 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23181 Rename "affinity" to "partition distribution algorithm" [ignite-3]

2024-09-19 Thread via GitHub
sanpwc merged PR #4394: URL: https://github.com/apache/ignite-3/pull/4394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
sanpwc commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766863467 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -609,17 +608,14 @@ private CompletableFuture stopLeaseProlongation

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360994743 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [I] Question - Events vs Continuous query [ignite]

2024-09-19 Thread via GitHub
sk0x50 closed issue #11529: Question - Events vs Continuous query URL: https://github.com/apache/ignite/issues/11529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [I] Correct documentation for DFLT_REBALANCE_THREAD_POOL_SIZE [ignite]

2024-09-19 Thread via GitHub
sk0x50 closed issue #11484: Correct documentation for DFLT_REBALANCE_THREAD_POOL_SIZE URL: https://github.com/apache/ignite/issues/11484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] IGNITE-23149 Updated rebalance thread pool doc [ignite]

2024-09-19 Thread via GitHub
sk0x50 merged PR #11543: URL: https://github.com/apache/ignite/pull/11543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
denis-chudov commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766815011 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -95,12 +95,16 @@ private HybridTimestamp(long time) { } /** -

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360934018 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23149 Updated rebalance thread pool doc [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11543: URL: https://github.com/apache/ignite/pull/11543#issuecomment-2360933493 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
denis-chudov commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766795700 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -609,17 +608,14 @@ private CompletableFuture stopLeaseProlon

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
sanpwc commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766787596 ## modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java: ## @@ -609,17 +608,14 @@ private CompletableFuture stopLeaseProlongation

[PR] IGNITE-23149 Updated rebalance thread pool doc [ignite]

2024-09-19 Thread via GitHub
IgGusev opened a new pull request, #11543: URL: https://github.com/apache/ignite/pull/11543 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The

Re: [PR] IGNITE-22999 Fix NPE in the cache distribution command [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11490: URL: https://github.com/apache/ignite/pull/11490#issuecomment-2360897423 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
sanpwc commented on code in PR #4425: URL: https://github.com/apache/ignite-3/pull/4425#discussion_r1766770053 ## modules/core/src/main/java/org/apache/ignite/internal/hlc/HybridTimestamp.java: ## @@ -95,12 +95,16 @@ private HybridTimestamp(long time) { } /** - *

Re: [PR] IGNITE-23235 SQL Calcite: Fix not-null count calculation if index reb… [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11542: URL: https://github.com/apache/ignite/pull/11542#issuecomment-2360838385 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360773628 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23229 Fixed StopLeaseProlongationMessageResponse#deniedLeaseExpirationTime may unbox a null value and cause NPE [ignite-3]

2024-09-19 Thread via GitHub
denis-chudov opened a new pull request, #4425: URL: https://github.com/apache/ignite-3/pull/4425 https://issues.apache.org/jira/browse/IGNITE-23229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-23190 Fix local class deployments cache cleanup on reconnect [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11541: URL: https://github.com/apache/ignite/pull/11541#issuecomment-2360368030 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23235 SQL Calcite: Fix not-null count calculation if index reb… [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11542: URL: https://github.com/apache/ignite/pull/11542#issuecomment-2360738242 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

[PR] IGNITE-23133 Java thin: fix NPE in handshakeRes [ignite-3]

2024-09-19 Thread via GitHub
ptupitsyn opened a new pull request, #4423: URL: https://github.com/apache/ignite-3/pull/4423 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[PR] IGNITE-23235 SQL Calcite: Fix not-null count calculation if index reb… [ignite]

2024-09-19 Thread via GitHub
alex-plekhanov opened a new pull request, #11542: URL: https://github.com/apache/ignite/pull/11542 …uild is in progress Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following st

[PR] IGNITE-23041: Sql. Add planner test to verify numeric type coercion for function arguments [ignite-3]

2024-09-19 Thread via GitHub
lowka opened a new pull request, #4424: URL: https://github.com/apache/ignite-3/pull/4424 --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-23133 Java thin: fix NPE in handshakeRes [ignite-3]

2024-09-19 Thread via GitHub
ptupitsyn merged PR #4423: URL: https://github.com/apache/ignite-3/pull/4423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360608745 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360582692 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360491495 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360435871 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23190 Fix local class deployments cache cleanup on reconnect [ignite]

2024-09-19 Thread via GitHub
alex-plekhanov opened a new pull request, #11541: URL: https://github.com/apache/ignite/pull/11541 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-19 Thread via GitHub
sanpwc commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1766405572 ## modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java: ## @@ -856,4 +860,54 @@ public void onLeaderStart(long term) {

Re: [PR] IGNITE-23225 add logging to LogManagerImpl [ignite-3]

2024-09-19 Thread via GitHub
vldpyatkov merged PR #4411: URL: https://github.com/apache/ignite-3/pull/4411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-22991 SQL Calcite: Bump Calcite version 1.37 [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11478: URL: https://github.com/apache/ignite/pull/11478#issuecomment-2360223952 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22991 SQL Calcite: Bump Calcite version 1.37 [ignite]

2024-09-19 Thread via GitHub
asfgit closed pull request #11478: IGNITE-22991 SQL Calcite: Bump Calcite version 1.37 URL: https://github.com/apache/ignite/pull/11478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360195830 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

[PR] IGNITE-23192 Sql. Arithmetic operations failed with "out of range" exception [ignite-3]

2024-09-19 Thread via GitHub
zstan opened a new pull request, #4422: URL: https://github.com/apache/ignite-3/pull/4422 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: ###

Re: [PR] IGNITE-22530 CDC: Add regex filters for cache names [ignite-extensions]

2024-09-19 Thread via GitHub
NSAmelchev commented on code in PR #286: URL: https://github.com/apache/ignite-extensions/pull/286#discussion_r1766283310 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerConfiguration.java: ## @@ -175,6 +184,34 @@ public void setCaches(Collec

Re: [PR] Bump NUnit3TestAdapter from 4.5.0 to 4.6.0 in /modules/platforms/dotnet [ignite-3]

2024-09-19 Thread via GitHub
ptupitsyn merged PR #4421: URL: https://github.com/apache/ignite-3/pull/4421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-22732 Transaction aware SQL [ignite]

2024-09-19 Thread via GitHub
sonarcloud[bot] commented on PR #11438: URL: https://github.com/apache/ignite/pull/11438#issuecomment-2360164819 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-22530 CDC: Add regex filters for cache names [ignite-extensions]

2024-09-19 Thread via GitHub
NSAmelchev commented on code in PR #286: URL: https://github.com/apache/ignite-extensions/pull/286#discussion_r1766278455 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteCdcStreamerApplier.java: ## @@ -260,7 +278,44 @@ private boolean filterAndPossibly