Re: [PR] IGNITE-25865 Reduce metastorage watch notification executor to 1 thread [ignite-3]

2025-07-08 Thread via GitHub
rpuch merged PR #6216: URL: https://github.com/apache/ignite-3/pull/6216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25843 Shade ignite commons deps into ignite-core.jar [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12173: URL: https://github.com/apache/ignite/pull/12173#issuecomment-3051388194 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] Bump io.swagger.parser.v3:swagger-parser from 2.1.30 to 2.1.31 [ignite-3]

2025-07-08 Thread via GitHub
sashapolo merged PR #6218: URL: https://github.com/apache/ignite-3/pull/6218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump okhttp from 4.12.0 to 5.0.0 [ignite-3]

2025-07-08 Thread via GitHub
sashapolo merged PR #6183: URL: https://github.com/apache/ignite-3/pull/6183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump org.junit.platform:junit-platform-testkit from 1.13.2 to 1.13.3 [ignite-3]

2025-07-08 Thread via GitHub
sashapolo merged PR #6195: URL: https://github.com/apache/ignite-3/pull/6195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump junit5 from 5.13.2 to 5.13.3 [ignite-3]

2025-07-08 Thread via GitHub
sashapolo merged PR #6197: URL: https://github.com/apache/ignite-3/pull/6197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25843 Shade ignite commons deps into ignite-core.jar [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12173: URL: https://github.com/apache/ignite/pull/12173#issuecomment-3050001159 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-25163 .NET: Fix MetricsTests flakiness [ignite-3]

2025-07-08 Thread via GitHub
Copilot commented on code in PR #6221: URL: https://github.com/apache/ignite-3/pull/6221#discussion_r2192966380 ## modules/platforms/dotnet/Apache.Ignite.Tests/MetricsTests.cs: ## @@ -397,22 +416,13 @@ public void AssertMetric(string name, int value, int timeoutMs = 1000)

[PR] IGNITE-25860 fix NoSuchElementException when get partition states. [ignite-3]

2025-07-08 Thread via GitHub
alievmirza opened a new pull request, #6222: URL: https://github.com/apache/ignite-3/pull/6222 https://issues.apache.org/jira/browse/IGNITE-25860 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

[PR] IGNITE-25163 .NET: Fix MetricsTests flakiness [ignite-3]

2025-07-08 Thread via GitHub
ptupitsyn opened a new pull request, #6221: URL: https://github.com/apache/ignite-3/pull/6221 Add RecordObservableInstruments and WaitForCondition to AssertTaggedMetric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] IGNITE-25843 Shade ignite commons deps into ignite-core.jar [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12173: URL: https://github.com/apache/ignite/pull/12173#issuecomment-3049552184 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-25843 Shade ignite commons deps into ignite-core.jar [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12173: URL: https://github.com/apache/ignite/pull/12173#issuecomment-3049527742 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-25867 Catalog compaction never happens after zone was dropped with all its tables. [ignite-3]

2025-07-08 Thread via GitHub
AMashenkov opened a new pull request, #6220: URL: https://github.com/apache/ignite-3/pull/6220 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
vadimkolodingg commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192891361 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStar

Re: [PR] Ignite 23856 thin cln channels duplication + connection retry logic [ignite]

2025-07-08 Thread via GitHub
timoninmaxim commented on code in PR #12169: URL: https://github.com/apache/ignite/pull/12169#discussion_r2192884360 ## modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java: ## @@ -243,27 +247,29 @@ private void handleServiceAsync( Lis

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
vadimkolodingg commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192882052 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStar

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
vadimkolodingg commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192880657 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStar

Re: [PR] Ignite 23856 thin cln channels duplication + connection retry logic [ignite]

2025-07-08 Thread via GitHub
timoninmaxim commented on code in PR #12169: URL: https://github.com/apache/ignite/pull/12169#discussion_r2192878478 ## modules/core/src/main/java/org/apache/ignite/internal/client/thin/ReliableChannel.java: ## @@ -68,7 +68,11 @@ final class ReliableChannel implements AutoClosea

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
vadimkolodingg commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192878492 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStar

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
vadimkolodingg commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192878026 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStar

[PR] IGNITE-25863 Deduplicate awaitAssignmentsStabilization() [ignite-3]

2025-07-08 Thread via GitHub
rpuch opened a new pull request, #6219: URL: https://github.com/apache/ignite-3/pull/6219 https://issues.apache.org/jira/browse/IGNITE-25863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] Bump io.swagger.parser.v3:swagger-parser from 2.1.30 to 2.1.31 [ignite-3]

2025-07-08 Thread via GitHub
dependabot[bot] opened a new pull request, #6218: URL: https://github.com/apache/ignite-3/pull/6218 Bumps [io.swagger.parser.v3:swagger-parser](https://github.com/swagger-api/swagger-parser) from 2.1.30 to 2.1.31. Release notes Sourced from https://github.com/swagger-api/swagger-p

[PR] IGNITE-25866 Fix critical system error on node stopping [ignite-3]

2025-07-08 Thread via GitHub
denis-chudov opened a new pull request, #6217: URL: https://github.com/apache/ignite-3/pull/6217 https://issues.apache.org/jira/browse/IGNITE-25866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] IGNITE-25641 Fix discrepancy with CacheStore in case of an error during tx commit phase [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12178: URL: https://github.com/apache/ignite/pull/12178#issuecomment-3049230178 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

[PR] IGNITE-25865 Reduce metastorage watch notification executor to 1 thread [ignite-3]

2025-07-08 Thread via GitHub
rpuch opened a new pull request, #6216: URL: https://github.com/apache/ignite-3/pull/6216 https://issues.apache.org/jira/browse/IGNITE-25865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] IGNITE-25641 Fix discrepancy with CacheStore in case of an error during tx commit phase [ignite]

2025-07-08 Thread via GitHub
sergey-chugunov-1985 opened a new pull request, #12178: URL: https://github.com/apache/ignite/pull/12178 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

Re: [PR] IGNITE-25582 Sql. Partition awareness for implicit tx [ignite-3]

2025-07-08 Thread via GitHub
korlov42 merged PR #6191: URL: https://github.com/apache/ignite-3/pull/6191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-25036 Fix an issue shows column names instead of aliases for results of SQL queries in CLI [ignite-3]

2025-07-08 Thread via GitHub
ygerzhedovich merged PR #6215: URL: https://github.com/apache/ignite-3/pull/6215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
rpuch merged PR #6211: URL: https://github.com/apache/ignite-3/pull/6211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch merged PR #6199: URL: https://github.com/apache/ignite-3/pull/6199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-24068 Read-only requests can read data from learners [ignite-3]

2025-07-08 Thread via GitHub
denis-chudov commented on code in PR #6192: URL: https://github.com/apache/ignite-3/pull/6192#discussion_r2192320647 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItReplicasTest.java: ## @@ -101,7 +139,65 @@ void testLearnerReplicaCreatedAfterStarti

[PR] IGNITE-25036 Fix an issue shows column names instead of aliases for results of SQL queries in CLI [ignite-3]

2025-07-08 Thread via GitHub
ygerzhedovich opened a new pull request, #6215: URL: https://github.com/apache/ignite-3/pull/6215 https://issues.apache.org/jira/browse/IGNITE-25036 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192388259 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngine.java: ## @@ -78,4 +80,12 @@ static long defaultDataRegionSize() { /

Re: [PR] IGNITE-25843 Shade ignite commons deps into ignite-core.jar [ignite]

2025-07-08 Thread via GitHub
sonarqubecloud[bot] commented on PR #12173: URL: https://github.com/apache/ignite/pull/12173#issuecomment-3048673116 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://son

Re: [PR] IGNITE-25774 Extension to write CDC data to PostgreSQL [ignite-extensions]

2025-07-08 Thread via GitHub
timoninmaxim commented on code in PR #311: URL: https://github.com/apache/ignite-extensions/pull/311#discussion_r2192332556 ## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/IgniteToPostgreSqlCdcApplier.java: ## @@ -0,0 +1,575 @@ +package org.apache.ignite.cdc.po

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
ibessonov commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192232214 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngineTest.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache S

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
ibessonov commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192231765 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngine.java: ## @@ -78,4 +80,12 @@ static long defaultDataRegionSize() {

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192208547 ## modules/storage-api/src/main/java/org/apache/ignite/internal/storage/engine/StorageEngine.java: ## @@ -78,4 +80,12 @@ static long defaultDataRegionSize() { /

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192202422 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/impl/TestStorageEngineTest.java: ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softw

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2192201067 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManager.java: ## @@ -500,4 +505,32 @@ public void destroyGroupI

Re: [PR] IGNITE-25582 Sql. Partition awareness for implicit tx [ignite-3]

2025-07-08 Thread via GitHub
zstan commented on code in PR #6191: URL: https://github.com/apache/ignite-3/pull/6191#discussion_r2192161316 ## modules/client/src/main/java/org/apache/ignite/internal/client/sql/PartitionMappingProvider.java: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] IGNITE-25841 .NET: Fix null handling in AssertJobStatus [ignite-3]

2025-07-08 Thread via GitHub
ptupitsyn merged PR #6208: URL: https://github.com/apache/ignite-3/pull/6208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25839 Support client credentials in migration tools [ignite-3]

2025-07-08 Thread via GitHub
isapego merged PR #6189: URL: https://github.com/apache/ignite-3/pull/6189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-25842 Propagate exceptions in LeaseTracker.awaitPrimaryReplica [ignite-3]

2025-07-08 Thread via GitHub
sashapolo merged PR #6198: URL: https://github.com/apache/ignite-3/pull/6198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2192079185 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/NotificationEnqueuedListener.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-25728 DB API Driver 3: Remove unixODBC dependency [ignite-3]

2025-07-08 Thread via GitHub
isapego merged PR #6212: URL: https://github.com/apache/ignite-3/pull/6212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ign

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
tkalkirill commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2192038363 ## modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/ItCatalogApiThreadingTest.java: ## @@ -49,12 +62,49 @@ protected int initialNodes

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
tkalkirill commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2192028022 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/NotificationEnqueuedListener.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Ap

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
tkalkirill commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2192020093 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -224,36 +227,34 @@ public CompletableFuture notifyWatc

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
tkalkirill commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2192015883 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/WatchProcessorTest.java: ## @@ -288,6 +289,48 @@ void nodeStoppingExceptionDoesNo

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
tkalkirill commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191862888 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/WatchProcessorTest.java: ## @@ -288,6 +289,48 @@ void nodeStoppingExceptionDoesNo

Re: [PR] IGNITE-25366 Documentation. Describe output of EXPLAIN command [ignite-3]

2025-07-08 Thread via GitHub
korlov42 merged PR #6163: URL: https://github.com/apache/ignite-3/pull/6163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ig

Re: [PR] IGNITE-25842 Propagate exceptions in LeaseTracker.awaitPrimaryReplica [ignite-3]

2025-07-08 Thread via GitHub
denis-chudov commented on code in PR #6198: URL: https://github.com/apache/ignite-3/pull/6198#discussion_r2192003686 ## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ## @@ -255,63 +256,77 @@ private void enqueuePrimar

[PR] IGNITE-25858 Review and update documentation [ignite-3]

2025-07-08 Thread via GitHub
jinxxxoid opened a new pull request, #6214: URL: https://github.com/apache/ignite-3/pull/6214 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-23120 Improve inline index feature [ignite]

2025-07-08 Thread via GitHub
Phillippko commented on code in PR #12155: URL: https://github.com/apache/ignite/pull/12155#discussion_r2191965896 ## modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java: ## @@ -349,6 +349,14 @@ public abstract class IgniteUtils extends CommonUtils {

Re: [PR] IGNITE-25366 Documentation. Describe output of EXPLAIN command [ignite-3]

2025-07-08 Thread via GitHub
korlov42 commented on code in PR #6163: URL: https://github.com/apache/ignite-3/pull/6163#discussion_r2191936959 ## docs/_docs/sql-reference/explain-statement.adoc: ## @@ -0,0 +1,294 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor licens

Re: [PR] IGNITE-25366 Documentation. Describe output of EXPLAIN command [ignite-3]

2025-07-08 Thread via GitHub
korlov42 commented on code in PR #6163: URL: https://github.com/apache/ignite-3/pull/6163#discussion_r2191936330 ## docs/_docs/sql-reference/explain-operators-list.adoc: ## @@ -0,0 +1,505 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor l

Re: [PR] IGNITE-25366 Documentation. Describe output of EXPLAIN command [ignite-3]

2025-07-08 Thread via GitHub
korlov42 commented on code in PR #6163: URL: https://github.com/apache/ignite-3/pull/6163#discussion_r2191935806 ## docs/_docs/sql-reference/explain-operators-list.adoc: ## @@ -0,0 +1,505 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor l

Re: [PR] IGNITE-25366 Documentation. Describe output of EXPLAIN command [ignite-3]

2025-07-08 Thread via GitHub
IgGusev commented on code in PR #6163: URL: https://github.com/apache/ignite-3/pull/6163#discussion_r2191734835 ## docs/_docs/sql-reference/explain-operators-list.adoc: ## @@ -0,0 +1,505 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor li

Re: [PR] IGNITE-25850 Implement method to get non-destroyed pagemem tables IDs [ignite-3]

2025-07-08 Thread via GitHub
ibessonov commented on code in PR #6211: URL: https://github.com/apache/ignite-3/pull/6211#discussion_r2191812923 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreManager.java: ## @@ -500,4 +505,32 @@ public void destroyGr

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191800565 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/SchemaSafeTimeTracker.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191774902 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/WatchProcessorTest.java: ## @@ -288,6 +289,48 @@ void nodeStoppingExceptionDoesNotTrig

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191795840 ## modules/runner/src/main/java/org/apache/ignite/internal/schema/SchemaSafeTimeTrackerImpl.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191776295 ## modules/network-api/src/main/java/org/apache/ignite/internal/network/MessagingService.java: ## @@ -34,7 +34,7 @@ public interface MessagingService { * Send the

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191766953 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/WatchProcessorTest.java: ## @@ -288,6 +289,48 @@ void nodeStoppingExceptionDoesNotTrig

Re: [PR] IGNITE-22703 Sql. Low performance for select with mixed projection [ignite-3]

2025-07-08 Thread via GitHub
zstan commented on code in PR #6187: URL: https://github.com/apache/ignite-3/pull/6187#discussion_r2191729302 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/RowTypeUtils.java: ## @@ -46,24 +47,26 @@ public static RelDataType rowType(TableDescripto

Re: [PR] IGNITE-25851 Allow read-only node configuration files [ignite-3]

2025-07-08 Thread via GitHub
sashapolo commented on code in PR #6209: URL: https://github.com/apache/ignite-3/pull/6209#discussion_r2191711894 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/LocalFileConfigurationStorage.java: ## @@ -353,18 +360,25 @@ private static String r

Re: [PR] IGNITE-25851 Allow read-only node configuration files [ignite-3]

2025-07-08 Thread via GitHub
ibessonov commented on code in PR #6209: URL: https://github.com/apache/ignite-3/pull/6209#discussion_r2191703430 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/LocalFileConfigurationStorage.java: ## @@ -365,6 +371,13 @@ private void checkAndRes

Re: [PR] IGNITE-25851 Allow read-only node configuration files [ignite-3]

2025-07-08 Thread via GitHub
sashapolo commented on code in PR #6209: URL: https://github.com/apache/ignite-3/pull/6209#discussion_r2191694010 ## modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/LocalFileConfigurationStorage.java: ## @@ -365,6 +371,13 @@ private void checkAndRes

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191698962 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -224,36 +227,34 @@ public CompletableFuture notifyWatches(l

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191698962 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/WatchProcessor.java: ## @@ -224,36 +227,34 @@ public CompletableFuture notifyWatches(l

Re: [PR] IGNITE-25526 Add node name to JMX bean names [ignite-3]

2025-07-08 Thread via GitHub
sk0x50 merged PR #6180: URL: https://github.com/apache/ignite-3/pull/6180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@igni

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191687302 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/NotificationEnqueuedListener.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-25286 Only concern Catalog updates application for Schema sync [ignite-3]

2025-07-08 Thread via GitHub
rpuch commented on code in PR #6199: URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191675367 ## modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/ItCatalogApiThreadingTest.java: ## @@ -49,12 +62,49 @@ protected int initialNodes() {

Re: [PR] IGNITE-25582 Sql. Partition awareness for implicit tx [ignite-3]

2025-07-08 Thread via GitHub
korlov42 commented on code in PR #6191: URL: https://github.com/apache/ignite-3/pull/6191#discussion_r2191662396 ## modules/client/src/main/java/org/apache/ignite/internal/client/sql/ClientSql.java: ## @@ -295,12 +312,39 @@ public CompletableFuture> executeAsync( };