[PR] IGNITE-23308 : Calcite. Wrong numeric type coercion with set-op operations. [ignite]

2024-09-28 Thread via GitHub
Vladsz83 opened a new pull request, #11557: URL: https://github.com/apache/ignite/pull/11557 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[PR] IGNITE-23281 Fix for long holding of write lock on Metastorage Compaction [ignite-3]

2024-09-28 Thread via GitHub
tkalkirill opened a new pull request, #4473: URL: https://github.com/apache/ignite-3/pull/4473 https://issues.apache.org/jira/browse/IGNITE-23281 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

[PR] IGNITE-23197 Store lease holder node ID as 2 longs in MvPartitionStorage implementations [ignite-3]

2024-09-28 Thread via GitHub
rpuch opened a new pull request, #4472: URL: https://github.com/apache/ignite-3/pull/4472 https://issues.apache.org/jira/browse/IGNITE-23197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-23015 Support IgniteCatalog transparency with respect to node restart [ignite-3]

2024-09-28 Thread via GitHub
rpuch merged PR #4468: URL: https://github.com/apache/ignite-3/pull/4468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-23290 Save and set a compaction revision into Metastorage [ignite-3]

2024-09-28 Thread via GitHub
tkalkirill opened a new pull request, #4471: URL: https://github.com/apache/ignite-3/pull/4471 https://issues.apache.org/jira/browse/IGNITE-23290 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-28 Thread via GitHub
tkalkirill merged PR #4465: URL: https://github.com/apache/ignite-3/pull/4465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23015 Support IgniteCatalog transparency with respect to node restart [ignite-3]

2024-09-28 Thread via GitHub
tkalkirill commented on code in PR #4468: URL: https://github.com/apache/ignite-3/pull/4468#discussion_r1779451902 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/app/Pojo.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-28 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2380577505 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-15119 Use UUID as the ClusterNode ID [ignite-3]

2024-09-27 Thread via GitHub
rpuch merged PR #4466: URL: https://github.com/apache/ignite-3/pull/4466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778555274 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1026,104 +1027,41 @@ private bool

Re: [PR] IGNITE-16707 Unify table API integration tests [ignite-3]

2024-09-27 Thread via GitHub
AMashenkov commented on code in PR #4430: URL: https://github.com/apache/ignite-3/pull/4430#discussion_r1778810911 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewSimpleSchemaApiTest.java: ## @@ -0,0 +1,783 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-16707 Unify table API integration tests [ignite-3]

2024-09-27 Thread via GitHub
AMashenkov commented on code in PR #4430: URL: https://github.com/apache/ignite-3/pull/4430#discussion_r1778750143 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewApiTest.java: ## @@ -0,0 +1,621 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-16707 Unify table API integration tests [ignite-3]

2024-09-27 Thread via GitHub
AMashenkov commented on code in PR #4430: URL: https://github.com/apache/ignite-3/pull/4430#discussion_r1778810911 ## modules/table/src/integrationTest/java/org/apache/ignite/internal/table/ItKeyValueViewSimpleSchemaApiTest.java: ## @@ -0,0 +1,783 @@ +/* + * Licensed to the Apac

Re: [PR] IGNITE-22783 Handle CMG-related network messages in CMG thread pool [ignite-3]

2024-09-27 Thread via GitHub
rpuch merged PR #4467: URL: https://github.com/apache/ignite-3/pull/4467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.1 to 1.15.2 [ignite-3]

2024-09-27 Thread via GitHub
dependabot[bot] commented on PR #4460: URL: https://github.com/apache/ignite-3/pull/4460#issuecomment-2379511867 Superseded by #4470. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump net.bytebuddy:byte-buddy from 1.15.1 to 1.15.3 [ignite-3]

2024-09-27 Thread via GitHub
dependabot[bot] opened a new pull request, #4470: URL: https://github.com/apache/ignite-3/pull/4470 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.15.1 to 1.15.3. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b

Re: [PR] Bump net.bytebuddy:byte-buddy from 1.15.1 to 1.15.2 [ignite-3]

2024-09-27 Thread via GitHub
dependabot[bot] closed pull request #4460: Bump net.bytebuddy:byte-buddy from 1.15.1 to 1.15.2 URL: https://github.com/apache/ignite-3/pull/4460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] Bump jackson from 2.17.2 to 2.18.0 [ignite-3]

2024-09-27 Thread via GitHub
dependabot[bot] opened a new pull request, #4469: URL: https://github.com/apache/ignite-3/pull/4469 Bumps `jackson` from 2.17.2 to 2.18.0. Updates `com.fasterxml.jackson.core:jackson-core` from 2.17.2 to 2.18.0 Commits https://github.com/FasterXML/jackson-core/commit/e78545c5

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
rpuch commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778708128 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java: ## @@ -17,186 +17,150 @@ package org.ap

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778704196 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1026,104 +1027,41 @@ private bool

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778491732 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorageUtils.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Sof

[PR] IGNITE-23015 Support IgniteCatalog transparency wrt node restart [ignite-3]

2024-09-27 Thread via GitHub
rpuch opened a new pull request, #4468: URL: https://github.com/apache/ignite-3/pull/4468 https://issues.apache.org/jira/browse/IGNITE-23015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-27 Thread via GitHub
korlov42 commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1778603431 ## modules/catalog-compaction/src/main/java/org/apache/ignite/internal/catalog/compaction/CatalogCompactionRunner.java: ## @@ -211,12 +203,24 @@ public void updateCoo

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2379356723 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778555274 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1026,104 +1027,41 @@ private bool

Re: [PR] IGNITE-15119 Use UUID as the ClusterNode ID [ignite-3]

2024-09-27 Thread via GitHub
ibessonov commented on code in PR #4466: URL: https://github.com/apache/ignite-3/pull/4466#discussion_r1778649579 ## modules/core/src/testFixtures/java/org/apache/ignite/internal/testframework/IgniteTestUtils.java: ## @@ -1045,4 +1046,14 @@ public boolean matches(Object o) {

[PR] IGNITE-22783 Handle CMG-related network messages in CMG thread pool [ignite-3]

2024-09-27 Thread via GitHub
rpuch opened a new pull request, #4467: URL: https://github.com/apache/ignite-3/pull/4467 https://issues.apache.org/jira/browse/IGNITE-22783 Handling of CMG network messages may cause I/O and hence must be offloaded to its own thread pool to avoid blocking network threads -- This i

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2379274006 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2379214462 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778519891 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java: ## @@ -17,186 +17,150 @@ package o

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2379085031 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23188: Incorporate table size estimation in query optimizer. [ignite-3]

2024-09-27 Thread via GitHub
ygerzhedovich commented on code in PR #4434: URL: https://github.com/apache/ignite-3/pull/4434#discussion_r1778498328 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java: ## @@ -101,10 +109,12 @@ public SqlSchemaManagerImpl(

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778499597 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java: ## @@ -17,186 +17,150 @@ package o

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778493214 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorageUtils.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Sof

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778477733 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/KeyValueStorageUtilsTest.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778478258 ## modules/metastorage/src/testFixtures/java/org/apache/ignite/internal/metastorage/server/SimpleInMemoryKeyValueStorage.java: ## @@ -547,78 +557,42 @@ private bool

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778477216 ## modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/KeyValueStorageUtilsTest.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778475814 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java: ## @@ -1026,104 +1027,41 @@ private bool

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778474552 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorageUtils.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Sof

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778473500 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -272,4 +274,31 @@ public interface MetaStorageManager

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778473990 ## modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/KeyValueStorage.java: ## @@ -233,13 +234,31 @@ boolean invoke( void removeWa

Re: [PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
rpuch commented on code in PR #4465: URL: https://github.com/apache/ignite-3/pull/4465#discussion_r1778381727 ## modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/MetaStorageManager.java: ## @@ -272,4 +274,31 @@ public interface MetaStorageManager exte

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2379020142 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23299 Sql. Fix invalid inflight transaction tracking. [ignite-3]

2024-09-27 Thread via GitHub
AMashenkov merged PR #4464: URL: https://github.com/apache/ignite-3/pull/4464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-27 Thread via GitHub
lowka commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1778351861 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Ap

Re: [PR] IGNITE-22879 Add CLI for migrating running nodes to new CMG [ignite-3]

2024-09-27 Thread via GitHub
rpuch merged PR #4458: URL: https://github.com/apache/ignite-3/pull/4458 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-23291 Improve the local compaction mechanism of Metastorage [ignite-3]

2024-09-27 Thread via GitHub
tkalkirill opened a new pull request, #4465: URL: https://github.com/apache/ignite-3/pull/4465 https://issues.apache.org/jira/browse/IGNITE-23291 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask bot

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-27 Thread via GitHub
sanpwc commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1778233954 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the A

[PR] IGNITE-23299 Sql. Fix invalid inflight transaction tracking. [ignite-3]

2024-09-27 Thread via GitHub
AMashenkov opened a new pull request, #4464: URL: https://github.com/apache/ignite-3/pull/4464 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-27 Thread via GitHub
sashapolo merged PR #4462: URL: https://github.com/apache/ignite-3/pull/4462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23202 Fix server node fail when nodeFilter class unknown [ignite]

2024-09-27 Thread via GitHub
sonarcloud[bot] commented on PR #11539: URL: https://github.com/apache/ignite/pull/11539#issuecomment-2378630143 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-27 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778037375 ## modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/persistence/replacement/AbstractPageReplacementTest.java: ## @@ -68,18 +68

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-27 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778083981 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImplem

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778074259 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImplem

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778083981 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImplem

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
tkalkirill commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778070582 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImple

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
tkalkirill commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778071189 ## modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/persistence/replacement/AbstractPageReplacementTest.java: ## @@ -68,18 +6

[PR] IGNITE-23073 [ignite-3]

2024-09-26 Thread via GitHub
xtern opened a new pull request, #4463: URL: https://github.com/apache/ignite-3/pull/4463 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778037787 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImplem

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778037375 ## modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/persistence/replacement/AbstractPageReplacementTest.java: ## @@ -68,18 +68

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1778036658 ## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/ReplaceCandidate.java: ## @@ -29,13 +29,13 @@ */ public class ReplaceCandid

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1777992667 ## modules/table/src/test/java/org/apache/ignite/internal/table/MinimumRequiredTimeCollectorServiceSelfTest.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Soft

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1777994608 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the Ap

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1777992800 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorServiceImpl.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to th

Re: [PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
tkalkirill commented on code in PR #4462: URL: https://github.com/apache/ignite-3/pull/4462#discussion_r1777976397 ## modules/page-memory/build.gradle: ## @@ -59,6 +59,7 @@ dependencies { integrationTestImplementation project(':ignite-storage-api') integrationTestImple

Re: [I] Question: DateTime Conversion Issue with different server [ignite]

2024-09-26 Thread via GitHub
ratadepally commented on issue #11546: URL: https://github.com/apache/ignite/issues/11546#issuecomment-2377371420 Hi @ygerzhedovich - thank you for the update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[PR] IGNITE-22950 Implement local events about zone replica start in PartitionReplicaLifecycleManager. [ignite-3]

2024-09-26 Thread via GitHub
kgusakov opened a new pull request, #4459: URL: https://github.com/apache/ignite-3/pull/4459 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following: #

Re: [PR] IGNITE-22637: Catalog compaction. Implement remote node part of compaction flow [ignite-3]

2024-09-26 Thread via GitHub
sanpwc commented on code in PR #4256: URL: https://github.com/apache/ignite-3/pull/4256#discussion_r1777349331 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/MinimumRequiredTimeCollectorService.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the A

[PR] IGNITE-23103 Sync RandomLruPageReplacementPolicy with Ignite 2 [ignite-3]

2024-09-26 Thread via GitHub
sashapolo opened a new pull request, #4462: URL: https://github.com/apache/ignite-3/pull/4462 https://issues.apache.org/jira/browse/IGNITE-23103 Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both

[PR] Bump org.jetbrains:annotations from 24.1.0 to 25.0.0 [ignite-3]

2024-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #4461: URL: https://github.com/apache/ignite-3/pull/4461 Bumps [org.jetbrains:annotations](https://github.com/JetBrains/java-annotations) from 24.1.0 to 25.0.0. Release notes Sourced from https://github.com/JetBrains/java-annotations/rele

[PR] Bump net.bytebuddy:byte-buddy from 1.15.1 to 1.15.2 [ignite-3]

2024-09-26 Thread via GitHub
dependabot[bot] opened a new pull request, #4460: URL: https://github.com/apache/ignite-3/pull/4460 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.15.1 to 1.15.2. Release notes Sourced from https://github.com/raphw/byte-buddy/releases";>net.bytebuddy:b

Re: [PR] IGNITE-23016 ducktape tests for dev branch implicitly use direct-io [ignite]

2024-09-26 Thread via GitHub
okreda1 commented on code in PR #11554: URL: https://github.com/apache/ignite/pull/11554#discussion_r1777068674 ## modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py: ## @@ -245,12 +245,16 @@ def envs(self): """ :return: environment set.

Re: [PR] IGNITE-23016 ducktape tests for dev branch implicitly use direct-io [ignite]

2024-09-26 Thread via GitHub
okreda1 commented on code in PR #11554: URL: https://github.com/apache/ignite/pull/11554#discussion_r1777067504 ## modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py: ## @@ -245,12 +245,16 @@ def envs(self): """ :return: environment set.

Re: [PR] IGNITE-23016 ducktape tests for dev branch implicitly use direct-io [ignite]

2024-09-26 Thread via GitHub
okreda1 commented on code in PR #11554: URL: https://github.com/apache/ignite/pull/11554#discussion_r1777067504 ## modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py: ## @@ -245,12 +245,16 @@ def envs(self): """ :return: environment set.

Re: [PR] IGNITE-22812 Add CLI for initiating CMG repair [ignite-3]

2024-09-26 Thread via GitHub
rpuch merged PR #: URL: https://github.com/apache/ignite-3/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] IGNITE-23019 Research before IGNITE-23010 [ignite-3]

2024-09-26 Thread via GitHub
JAkutenshi opened a new pull request, #4457: URL: https://github.com/apache/ignite-3/pull/4457 --- Thank you for submitting the pull request. To streamline the review process of the patch and ensure better code quality we ask both an author and a reviewer to verify the following:

Re: [I] Question: DateTime Conversion Issue with different server [ignite]

2024-09-26 Thread via GitHub
ygerzhedovich commented on issue #11546: URL: https://github.com/apache/ignite/issues/11546#issuecomment-2376602154 @ratadepally It doesn't matter which distro you used. It just Java application which run in JVM. What here can be matter - it's timezone on both of servers or parameters JVM r

Re: [I] Forcefully specify the number of CPUs [ignite]

2024-09-26 Thread via GitHub
sk0x50 closed issue #11472: Forcefully specify the number of CPUs URL: https://github.com/apache/ignite/issues/11472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] IGNITE-23188: Incorporate table size estimation in query optimizer. [ignite-3]

2024-09-26 Thread via GitHub
ygerzhedovich commented on code in PR #4434: URL: https://github.com/apache/ignite-3/pull/4434#discussion_r1776808579 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java: ## @@ -101,10 +109,12 @@ public SqlSchemaManagerImpl(

Re: [PR] IGNITE-23188: Incorporate table size estimation in query optimizer. [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4434: URL: https://github.com/apache/ignite-3/pull/4434#discussion_r1776801784 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java: ## @@ -101,10 +109,12 @@ public SqlSchemaManagerImpl(CatalogM

Re: [PR] IGNITE-23188: Incorporate table size estimation in query optimizer. [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4434: URL: https://github.com/apache/ignite-3/pull/4434#discussion_r1776801784 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/schema/SqlSchemaManagerImpl.java: ## @@ -101,10 +109,12 @@ public SqlSchemaManagerImpl(CatalogM

Re: [PR] IGNITE-23185 Add methods to access table and zone definitions [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn commented on code in PR #4452: URL: https://github.com/apache/ignite-3/pull/4452#discussion_r1776707848 ## modules/api/src/main/java/org/apache/ignite/catalog/ColumnType.java: ## @@ -352,4 +352,6 @@ private ColumnType length_(Integer length) { this.length = le

Re: [PR] IGNITE-23185 Add methods to access table and zone definitions [ignite-3]

2024-09-26 Thread via GitHub
korlov42 commented on code in PR #4452: URL: https://github.com/apache/ignite-3/pull/4452#discussion_r1776644840 ## modules/cli/src/main/java/org/apache/ignite/internal/cli/Main.java: ## @@ -60,7 +60,7 @@ public static void main(String[] args) { AnsiConsole.systemIn

Re: [PR] IGNITE-23265 Update ignite dependency jtdi in ignite-urideploy module [ignite]

2024-09-26 Thread via GitHub
ivandasch merged PR #11556: URL: https://github.com/apache/ignite/pull/11556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23265 Update ignite dependency jtdi in ignite-urideploy module [ignite]

2024-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #11556: URL: https://github.com/apache/ignite/pull/11556#issuecomment-2376484730 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23188: Incorporate table size estimation in query optimizer. [ignite-3]

2024-09-26 Thread via GitHub
lowka commented on code in PR #4434: URL: https://github.com/apache/ignite-3/pull/4434#discussion_r1776735237 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/statistic/SqlStatisticManagerImpl.java: ## @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache Sof

[PR] IGNITE-23092 Nested tuple serialization [ignite-3]

2024-09-26 Thread via GitHub
myskov opened a new pull request, #4456: URL: https://github.com/apache/ignite-3/pull/4456 https://issues.apache.org/jira/browse/IGNITE-23092 ### The Review Checklist - [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:

Re: [PR] IGNITE-23249 update janino [ignite]

2024-09-26 Thread via GitHub
sonarcloud[bot] commented on PR #11551: URL: https://github.com/apache/ignite/pull/11551#issuecomment-2376430237 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcl

Re: [PR] IGNITE-23249 update janino [ignite]

2024-09-26 Thread via GitHub
alex-plekhanov merged PR #11551: URL: https://github.com/apache/ignite/pull/11551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

Re: [PR] IGNITE-23091 Java Client: Automatic Pojo Serialization [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn commented on code in PR #4438: URL: https://github.com/apache/ignite-3/pull/4438#discussion_r1776670271 ## modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/pojo/PojoConverter.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

Re: [PR] IGNITE-23091 Java Client: Automatic Pojo Serialization [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn commented on code in PR #4438: URL: https://github.com/apache/ignite-3/pull/4438#discussion_r1776650459 ## modules/client-common/src/main/java/org/apache/ignite/internal/client/proto/pojo/PojoConverter.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the Apache Software

Re: [PR] Bump com.google.guava:guava from 33.3.0-jre to 33.3.1-jre [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn merged PR #4445: URL: https://github.com/apache/ignite-3/pull/4445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump com.github.spotbugs from 6.0.22 to 6.0.23 [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn merged PR #4455: URL: https://github.com/apache/ignite-3/pull/4455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] Bump io.swagger.core.v3:swagger-annotations from 2.2.23 to 2.2.24 [ignite-3]

2024-09-26 Thread via GitHub
ptupitsyn merged PR #4440: URL: https://github.com/apache/ignite-3/pull/4440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@i

Re: [PR] IGNITE-23042 Sql. Forbid implicit casts between different type families [ignite-3]

2024-09-26 Thread via GitHub
xtern commented on code in PR #4409: URL: https://github.com/apache/ignite-3/pull/4409#discussion_r1776528503 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -286,6 +290,120 @@ public CalciteContextException newVal

Re: [PR] IGNITE-23202 Fix server node fail when nodeFilter class unknown [ignite]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #11539: URL: https://github.com/apache/ignite/pull/11539#issuecomment-2376028371 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23090 Support SQL transactions in thin JDBC [ignite]

2024-09-25 Thread via GitHub
sonarcloud[bot] commented on PR #11528: URL: https://github.com/apache/ignite/pull/11528#issuecomment-2375236401 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcl

Re: [PR] IGNITE-23132 fix NullPointerException in LogManagerImpl [ignite-3]

2024-09-25 Thread via GitHub
vldpyatkov merged PR #4395: URL: https://github.com/apache/ignite-3/pull/4395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

Re: [PR] IGNITE-23273 Use a ConversionService per Ignite node [ignite-3]

2024-09-25 Thread via GitHub
rpuch merged PR #4451: URL: https://github.com/apache/ignite-3/pull/4451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignit

[PR] Bump com.github.spotbugs from 6.0.22 to 6.0.23 [ignite-3]

2024-09-25 Thread via GitHub
dependabot[bot] opened a new pull request, #4455: URL: https://github.com/apache/ignite-3/pull/4455 Bumps com.github.spotbugs from 6.0.22 to 6.0.23. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.github.spo

  1   2   3   4   5   6   7   8   9   10   >