[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example: "SqlS

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081445505 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -594,7 +598,8 @@ data: { # Return type of method implementation should be 'SqlNode'. # Example: "SqlS

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081440348 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-19 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1081438594 ## modules/sql-engine/src/main/codegen/config.fmpp: ## @@ -29,6 +29,7 @@ data: { imports: [ "org.apache.calcite.sql.SqlCreate", "org.apache.calcite.sq

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072072004 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072066793 ## modules/sql-engine/src/main/codegen/includes/parserImpls.ftl: ## @@ -532,3 +532,96 @@ SqlDrop SqlDropZone(Span s, boolean replace) : return new IgniteSqlDrop

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-17 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1072065179 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteSqlAlterZoneRenameTo.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [ignite-3] lowka commented on a diff in pull request #1521: IGNITE-18254: Sql. Extend SQL grammar with ALTER ZONE statement

2023-01-16 Thread GitBox
lowka commented on code in PR #1521: URL: https://github.com/apache/ignite-3/pull/1521#discussion_r1071837306 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/sql/IgniteAbstractSqlAlterZone.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Softwar