[GitHub] [ignite-3] lowka commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-20 Thread via GitHub
lowka commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082958726 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -363,27 +365,54 @@ public QueryChecker planEquals(String p

[GitHub] [ignite-3] lowka commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-20 Thread via GitHub
lowka commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082957978 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -459,15 +459,23 @@ private boolean isSystemFieldName(Str

[GitHub] [ignite-3] lowka commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-20 Thread via GitHub
lowka commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082915985 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java: ## @@ -114,6 +119,35 @@ public IgniteSqlValidator(SqlOperatorT

[GitHub] [ignite-3] lowka commented on a diff in pull request #1528: IGNITE-18422: Sql. Match number of dynamic parameters with given parameters

2023-01-20 Thread GitBox
lowka commented on code in PR #1528: URL: https://github.com/apache/ignite-3/pull/1528#discussion_r1082340129 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/util/QueryChecker.java: ## @@ -251,6 +251,8 @@ public static Matcher containsAnyScan(fin