[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-18 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1073735758 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-17 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1072139004 ## modules/schema/src/main/java/org/apache/ignite/internal/schema/TableRow.java: ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-13 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069449286 ## modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java: ## @@ -1931,19 +1944,19 @@ private HybridTimesta

[GitHub] [ignite-3] valepakh commented on a diff in pull request #1479: IGNITE-18360 Migrate storage to new Binary Tuple format

2023-01-13 Thread GitBox
valepakh commented on code in PR #1479: URL: https://github.com/apache/ignite-3/pull/1479#discussion_r1069400175 ## modules/storage-api/src/testFixtures/java/org/apache/ignite/internal/storage/BaseMvStoragesTest.java: ## @@ -102,23 +104,20 @@ static void afterAll() { kB