[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071289825 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071287538 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple concurrent

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071286076 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -36,49 +35,52 @@ * * Merges multiple concurrent

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071261364 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071260952 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071259733 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/OrderedMergePublisher.java: ## @@ -107,14 +109,20 @@ public void subscribe(Subscriber

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-16 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1071259421 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software

[GitHub] [ignite-3] xtern commented on a diff in pull request #1511: IGNITE-18510: Make composite publisher thread safe.

2023-01-12 Thread GitBox
xtern commented on code in PR #1511: URL: https://github.com/apache/ignite-3/pull/1511#discussion_r1068092636 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/ConcatPublisher.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software