[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2023-01-24 Thread via GitHub
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1085175526 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/util/SubscriptionUtils.java: ## @@ -49,6 +50,31 @@ public static Publisher

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2023-01-24 Thread via GitHub
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1085174737 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/IndexScanNode.java: ## @@ -119,282 +91,122 @@ public IndexScanNode(

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2023-01-20 Thread GitBox
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1082583163 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,58 @@ public void

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2022-12-28 Thread GitBox
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r105847 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,59 @@ public void

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2022-12-28 Thread GitBox
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1058438361 ## modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/api/ItSqlAsynchronousApiTest.java: ## @@ -343,37 +346,59 @@ public void

[GitHub] [ignite-3] ygerzhedovich commented on a diff in pull request #1469: IGNITE-18227: refactoring scan nodes and add support RO index scans.

2022-12-28 Thread GitBox
ygerzhedovich commented on code in PR #1469: URL: https://github.com/apache/ignite-3/pull/1469#discussion_r1058317496 ## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/StorageScanNode.java: ## @@ -0,0 +1,303 @@ +/* + * Licensed to the Apache