Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-16 Thread via GitHub
ygerzhedovich merged PR #4045: URL: https://github.com/apache/ignite-3/pull/4045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-15 Thread via GitHub
korlov42 commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1677725265 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + * Licensed to

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-10 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1672169302 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/UpdateSourcesCoercionTest.java: ## @@ -0,0 +1,687 @@ +/* + *

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-10 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1672168983 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + *

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-10 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1672168676 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java: ## @@ -351,4 +355,50 @@ public static RexNode

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-10 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1672136825 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/BaseTypeCoercionTest.java: ## @@ -51,6 +53,14 @@ static Stream

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-10 Thread via GitHub
korlov42 commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1672098248 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -675,7 +676,16 @@ protected void

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1670247930 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r166993 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + *

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669916020 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669912429 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669912429 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669899583 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669893119 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/InsertSourcesCoercionTest.java: ## @@ -0,0 +1,665 @@ +/* + * Licensed to the

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669883521 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java: ## @@ -351,4 +355,50 @@ public static RexNode

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669878184 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669878184 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669873741 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningPredicateSelfTest.java: ## @@ -118,12 +120,20 @@

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
ygerzhedovich commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669871584 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669846842 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractPlannerTest.java: ## @@ -499,8 +499,6 @@ protected void assertPlan(

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669844300 ## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningPredicateSelfTest.java: ## @@ -118,12 +120,20 @@ public void

Re: [PR] IGNITE-22581 Add planner test to verify numeric type coercion of source for INSERT, UPDATE and MERGE operators [ignite-3]

2024-07-09 Thread via GitHub
lowka commented on code in PR #4045: URL: https://github.com/apache/ignite-3/pull/4045#discussion_r1669842572 ## modules/sql-engine/src/testFixtures/java/org/apache/ignite/internal/sql/engine/util/SqlTestUtils.java: ## @@ -351,4 +355,50 @@ public static RexNode