[GitHub] [james-project] amichair commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
amichair commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248929382 Sure, sounds like a good plan. Would be great to let it run in production for a bit. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [james-project] chibenwa commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
chibenwa commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248927825 > btw is there an ETA for this release? The main issue that remains to be fixed is IMO https://github.com/apache/james-project/pull/1185 Once merged I'd like to go

[GitHub] [james-project] amichair commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
amichair commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248927750 oh it's all squashed into one, I intended to do the jpamailrepository separately in one commit and the file/jdbc/jpaurl cleanup in separate commits as they are. Too late I

[GitHub] [james-project] amichair commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
amichair commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248925664 Ooops I was about to sqash but I see it's already merged :-) btw is there an ETA for this release? Regarding that log, I'm not convinced the problem is with the

[GitHub] [james-project] chibenwa commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
chibenwa commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248803848 We quite like having the JIRA in all commit messages. Anyway here I think it makes sense to squash. Thanks a lot for the great contribution. If there is some things

[james-project] branch master updated: JAMES-2656 - Add initial JPAMailRepository implementation (#1176)

2022-09-15 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 066e2c98e7 JAMES-2656 - Add initial

[GitHub] [james-project] chibenwa merged pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
chibenwa merged PR #1176: URL: https://github.com/apache/james-project/pull/1176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] amichair commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
amichair commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1248604363 Rebased again. I'm not sure what you mean about the prefix - I added it to the initial commit of the jpa repository implementation, do you want it on all the commits? or to squash

[james-project] branch master updated: Adding myself to developpers

2022-09-15 Thread jhelou
This is an automated email from the ASF dual-hosted git repository. jhelou pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 3e02affabb Adding myself to developpers

[GitHub] [james-project] jeantil commented on pull request #1190: James 3805 fix PulsarMailQueueTest.dequeueShouldBeConcurrent and a few other unstability

2022-09-15 Thread GitBox
jeantil commented on PR #1190: URL: https://github.com/apache/james-project/pull/1190#issuecomment-1248143352 So I'm at 70 runs of `PulsarMailqueueFactoryTest` and it doesn't seem to want to fail, I'll assume a CI fluke and try

[GitHub] [james-project] chibenwa commented on pull request #1190: James 3805 fix PulsarMailQueueTest.dequeueShouldBeConcurrent and a few other unstability

2022-09-15 Thread GitBox
chibenwa commented on PR #1190: URL: https://github.com/apache/james-project/pull/1190#issuecomment-1247911486 Fails on pulsar: ``` org.apache.pulsar.client.admin.PulsarAdminException$NotFoundException: Tenant does not exist Caused by:

[GitHub] [james-project] chibenwa commented on pull request #1176: JAMES-2656 - Add initial JPAMailRepository implementation

2022-09-15 Thread GitBox
chibenwa commented on PR #1176: URL: https://github.com/apache/james-project/pull/1176#issuecomment-1247907468 Can I ask you to rebase one more time and put the JIRA in the commit messages as a prefix? `JAMES-2656 My message...` Also

[GitHub] [james-project] chibenwa closed pull request #1157: JAMES-3775 Experiment with Rspamd `Deliver-To` header

2022-09-15 Thread GitBox
chibenwa closed pull request #1157: JAMES-3775 Experiment with Rspamd `Deliver-To` header URL: https://github.com/apache/james-project/pull/1157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[james-project] branch master updated: [CHANGELOG] Mention CVE-2022-28220 STARTTLS command injection in Apache JAMES (#1188)

2022-09-15 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 670dd9da47 [CHANGELOG] Mention

[GitHub] [james-project] chibenwa merged pull request #1188: [CHANGELOG] Mention CVE-2022-28220 STARTTLS command injection in Apac…

2022-09-15 Thread GitBox
chibenwa merged PR #1188: URL: https://github.com/apache/james-project/pull/1188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[james-project] branch master updated: [REFACTORING] Cleanup OidcJwtTokenVerifier (#1186)

2022-09-15 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 75bd56c246 [REFACTORING] Cleanup

[GitHub] [james-project] chibenwa merged pull request #1186: [REFACTORING] Cleanup OidcJwtTokenVerifier

2022-09-15 Thread GitBox
chibenwa merged PR #1186: URL: https://github.com/apache/james-project/pull/1186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1185: JAMES-3816 Limit IMAP concurrent requests

2022-09-15 Thread GitBox
chibenwa commented on code in PR #1185: URL: https://github.com/apache/james-project/pull/1185#discussion_r971804093 ## server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/ReactiveThrottler.java: ## @@ -0,0 +1,91 @@

[GitHub] [james-project] vttranlina commented on pull request #1157: JAMES-3775 Experiment with Rspamd `Deliver-To` header

2022-09-15 Thread GitBox
vttranlina commented on PR #1157: URL: https://github.com/apache/james-project/pull/1157#issuecomment-1247656532 I created a issue on rspamd repository for help: https://github.com/rspamd/rspamd/issues/4269 -- This is an automated message from the Apache Git Service. To respond to the