Arsnael commented on PR #1760:
URL: https://github.com/apache/james-project/pull/1760#issuecomment-1776393230
```
[ERROR] Failed to execute goal
io.github.evis:scalafix-maven-plugin_2.13:0.1.6_0.9.34:scalafix
(scala-check-style) on project jmap-rfc-8621-integration-tests-common:
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368509311
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -158,15 +159,15 @@ void
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368509311
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -158,15 +159,15 @@ void
chibenwa commented on PR #1758:
URL: https://github.com/apache/james-project/pull/1758#issuecomment-1774975409
Tests should be way easier to read.
I did let a few comments on how to achieve this.
--
This is an automated message from the Apache Git Service.
To respond to the
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368507018
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,248 @@
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368505095
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/FilterForwardIntegrationTest.java:
##
@@ -0,0 +1,204 @@
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368504561
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/FilterForwardIntegrationTest.java:
##
@@ -0,0 +1,204 @@
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368503382
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/FilterForwardIntegrationTest.java:
##
@@ -0,0 +1,204 @@
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368504123
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/FilterForwardIntegrationTest.java:
##
@@ -0,0 +1,204 @@
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368438671
##
mailet/api/src/main/java/org/apache/mailet/LoopPrevention.java:
##
@@ -0,0 +1,66 @@
+/
+ *
Arsnael commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368336490
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,247 @@
Arsnael commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368334183
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -158,15 +159,15 @@ void
This is an automated email from the ASF dual-hosted git repository.
git-site-role pushed a commit to branch asf-staging
in repository https://gitbox.apache.org/repos/asf/james-site.git
The following commit(s) were added to refs/heads/asf-staging by this push:
new d61b88b7f Site checkin for
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368280416
##
mailet/api/src/main/java/org/apache/mailet/LoopPrevention.java:
##
@@ -0,0 +1,66 @@
+/
+ *
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368275999
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,247 @@
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368275745
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,247 @@
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368273724
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,247 @@
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368271781
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -0,0 +1,247 @@
thanhbv200585 commented on PR #1759:
URL: https://github.com/apache/james-project/pull/1759#issuecomment-1774635035
> Please rebase this work on top of
https://github.com/apache/james-project/pull/1743
@chibenwa Already rebased
--
This is an automated message from the Apache Git
thanhbv200585 commented on PR #1759:
URL: https://github.com/apache/james-project/pull/1759#issuecomment-1774633924
> Please rebase this work on top of
https://github.com/apache/james-project/pull/1743
--
This is an automated message from the Apache Git Service.
To respond to the
chibenwa opened a new pull request, #1760:
URL: https://github.com/apache/james-project/pull/1760
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368266335
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -157,7 +158,7 @@ void
hungphan227 commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368265123
##
mailet/api/src/main/java/org/apache/mailet/LoopPrevention.java:
##
@@ -0,0 +1,66 @@
+/
+ *
thanhbv200585 commented on PR #1759:
URL: https://github.com/apache/james-project/pull/1759#issuecomment-1774533163
> A little demo perhaps? :)
https://github.com/apache/james-project/assets/87489927/c5c22850-8a19-4032-94e2-fa9e483fc2f8
--
This is an automated message
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368180824
##
mailet/api/src/main/java/org/apache/mailet/LoopPrevention.java:
##
@@ -0,0 +1,66 @@
+/
+ *
chibenwa commented on code in PR #1758:
URL: https://github.com/apache/james-project/pull/1758#discussion_r1368181096
##
server/mailet/integration-testing/src/test/java/org/apache/james/mailets/ForwardLoopIntegrationTest.java:
##
@@ -157,7 +158,7 @@ void
26 matches
Mail list logo