Re: [PR] JAMES-3946 removals [james-project]

2024-06-13 Thread via GitHub
Maxxx873 commented on PR #2299: URL: https://github.com/apache/james-project/pull/2299#issuecomment-2167362783 > With that we can likely close the JAMES-3946 topic, right? I think the task can be closed after merging: https://github.com/apache/james-project/pull/2289 -- This is an au

Re: [PR] JAMES-3946 removals [james-project]

2024-06-13 Thread via GitHub
chibenwa commented on PR #2299: URL: https://github.com/apache/james-project/pull/2299#issuecomment-2167342158 With that we can likely close the JAMES-3946 topic, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] JAMES-3946 removals [james-project]

2024-06-13 Thread via GitHub
chibenwa merged PR #2299: URL: https://github.com/apache/james-project/pull/2299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

(james-project) branch master updated: JAMES-3946 WhiteList manager removals (#2299)

2024-06-13 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 2af30eeb26 JAMES-3946 WhiteList manager

Re: [PR] JAMES-3946 removals [james-project]

2024-06-13 Thread via GitHub
chibenwa commented on code in PR #2299: URL: https://github.com/apache/james-project/pull/2299#discussion_r1638778943 ## upgrade-instructions.md: ## @@ -31,6 +31,18 @@ Change list: - [javax -> jakarta](#javax---jakarta) - [Make all queues on RabbitMQ quorum queue when `quor

[PR] JAMES-3946 removals [james-project]

2024-06-13 Thread via GitHub
Maxxx873 opened a new pull request, #2299: URL: https://github.com/apache/james-project/pull/2299 https://issues.apache.org/jira/browse/JAMES-3946 At this point, I have completed everything I have planned for this task, and this PR is final. If anyone has additional thoughts please le

[PR] Shn27 web admin authentication dynamic check for webAdminGroup routes.Tested. [james-project]

2024-06-13 Thread via GitHub
shn27 opened a new pull request, #2298: URL: https://github.com/apache/james-project/pull/2298 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Shn27 web admin authentication dynamic check for webAdminGroup routes.Tested. [james-project]

2024-06-13 Thread via GitHub
shn27 closed pull request #2298: Shn27 web admin authentication dynamic check for webAdminGroup routes.Tested. URL: https://github.com/apache/james-project/pull/2298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] [UPGRADE] Opensearch libraries [james-project]

2024-06-13 Thread via GitHub
vttranlina opened a new pull request, #2297: URL: https://github.com/apache/james-project/pull/2297 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] JAMES-2586 Refactor/Cleanup JamesPostgresConnectionFactory [james-project]

2024-06-13 Thread via GitHub
vttranlina commented on code in PR #2292: URL: https://github.com/apache/james-project/pull/2292#discussion_r1637768951 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/SinglePostgresConnectionFactory.java: ## Review Comment: it is no longe

Re: [PR] JAMES-2586 Fixup PoolBackedPostgresConnectionFactory - set domain attribute value even empty domain [james-project]

2024-06-13 Thread via GitHub
vttranlina commented on PR #2292: URL: https://github.com/apache/james-project/pull/2292#issuecomment-2164901165 After discussing with @hungphan227 @quantranhong1999 we should not try to set an empty value for `app.current_domain` when input is empty Domain - About test cases fai

[PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]

2024-06-13 Thread via GitHub
hungphan227 opened a new pull request, #2296: URL: https://github.com/apache/james-project/pull/2296 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [FIX] registrations multimap made fully thread safe [james-project]

2024-06-13 Thread via GitHub
chibenwa commented on PR #2291: URL: https://github.com/apache/james-project/pull/2291#issuecomment-2164746782 > (not sure why it wasn't already before). Likely by mistake... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git