Arsnael commented on PR #2746:
URL: https://github.com/apache/james-project/pull/2746#issuecomment-2998529979
> (If it is squash and merge, which we would not do, then it is fine)
I cleaned up the history btw when I rebased yesterday so should be fine on
that end. Feel free to double
quantranhong1999 commented on PR #2746:
URL: https://github.com/apache/james-project/pull/2746#issuecomment-2998521454
> I do not understand what issue github has now, I did rebase there was no
conflict...
https://github.com/user-attachments/assets/508ebf5d-4282-4682-a96f-a4da46a0a7c9
quantranhong1999 commented on PR #2750:
URL: https://github.com/apache/james-project/pull/2750#issuecomment-2998528573
> but ThreadIdGuessingAlgorithmContract is absolute garbage and deserves a
complete rewrite using directly and only MailboxManager and higher APIs.
I agree TBH. I str
Arsnael commented on PR #2746:
URL: https://github.com/apache/james-project/pull/2746#issuecomment-2998527956
@quantranhong1999 weird it looks fine on your end... That's how it looks on
mine:
 but ThreadIdGuessingAlgorithmContract is absolute
garbage and deserves a complete rewrite using directly and only MailboxManage
chibenwa commented on PR #2750:
URL: https://github.com/apache/james-project/pull/2750#issuecomment-2996416368
Thanks. I'll polish that tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chibenwa commented on code in PR #2750:
URL: https://github.com/apache/james-project/pull/2750#discussion_r2161578658
##
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraThreadIdGuessingAlgorithm.java:
##
@@ -88,17 +86,17 @@ public Flux getMessageIdsIn
quantranhong1999 commented on code in PR #2750:
URL: https://github.com/apache/james-project/pull/2750#discussion_r2161577181
##
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraThreadIdGuessingAlgorithm.java:
##
@@ -88,17 +86,17 @@ public Flux getMess
chibenwa commented on code in PR #2750:
URL: https://github.com/apache/james-project/pull/2750#discussion_r2161571784
##
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraThreadIdGuessingAlgorithm.java:
##
@@ -88,17 +86,17 @@ public Flux getMessageIdsIn
amichair commented on PR #2744:
URL: https://github.com/apache/james-project/pull/2744#issuecomment-2996388323
Does anything else need explaining or discussion or improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Arsnael commented on PR #2746:
URL: https://github.com/apache/james-project/pull/2746#issuecomment-2995381602
I do not understand why github tells me there is a conflict... I just
rebased on latest master
Or is it like last time?
--
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
The following commit(s) were added to refs/heads/master by this push:
new 0a40a91ebd [ENHANCEMENT] DKIMVerify out
quantranhong1999 commented on PR #2750:
URL: https://github.com/apache/james-project/pull/2750#issuecomment-2995872892
> Is it enough for passing mailbox/Cassandra tests?
There are 2 tests failing. I added review comments.
I would love to help on this too if you want.
--
This
quantranhong1999 commented on code in PR #2750:
URL: https://github.com/apache/james-project/pull/2750#discussion_r2161265303
##
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraThreadIdGuessingAlgorithm.java:
##
@@ -88,17 +86,17 @@ public Flux getMess
quantranhong1999 commented on code in PR #2750:
URL: https://github.com/apache/james-project/pull/2750#discussion_r2161265303
##
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/CassandraThreadIdGuessingAlgorithm.java:
##
@@ -88,17 +86,17 @@ public Flux getMess
chibenwa commented on PR #2750:
URL: https://github.com/apache/james-project/pull/2750#issuecomment-2995858160
+1 for quan changes.
Is it enough for passing mailbox/Cassandra tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
hqtran pushed a change to branch JAMES-3516-bte
in repository https://gitbox.apache.org/repos/asf/james-project.git
from 2337eb3429 JAMES-3516 Rely on Cassandra for Thread lookups
add 3c04d5a74f JAMES-3516 Rework Thread
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch JAMES-3516-bte
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 2337eb3429df3761b4771a5584cd3c75a830d0d5
Author: Benoit TELLIER
AuthorDate: Mon Jun 23 08:16:57 2025 +0
19 matches
Mail list logo
