[GitHub] [james-project] chibenwa opened a new pull request, #1405: JAMES-3756 DelegationStoreAuthorizator should not fail on bad admin v…

2023-01-19 Thread GitBox
chibenwa opened a new pull request, #1405: URL: https://github.com/apache/james-project/pull/1405 …irtualHosting It is preferable to fallback to forbidden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [james-project] chibenwa merged pull request #1397: [ENHANCEMENT] Use provided scope for James dependencies in extensions

2023-01-19 Thread GitBox
chibenwa merged PR #1397: URL: https://github.com/apache/james-project/pull/1397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] jeantil commented on pull request #1400: [boyscout] logs bound port when webmin server starts

2023-01-19 Thread GitBox
jeantil commented on PR #1400: URL: https://github.com/apache/james-project/pull/1400#issuecomment-1396956193 build was green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] jeantil merged pull request #1400: [boyscout] logs bound port when webmin server starts

2023-01-19 Thread GitBox
jeantil merged PR #1400: URL: https://github.com/apache/james-project/pull/1400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] AdBuch commented on a diff in pull request #1403: JAMES-3876 Load-balancing flag for Remote Delivery Gateways

2023-01-19 Thread GitBox
AdBuch commented on code in PR #1403: URL: https://github.com/apache/james-project/pull/1403#discussion_r1081233432 ## server/apps/spring-app/src/main/resources/mailetcontainer.xml: ## @@ -354,6 +354,11 @@ Regards, Postmaster XXX.YYY otherserver.mydomain.com

[GitHub] [james-project] AdBuch commented on a diff in pull request #1403: JAMES-3876 Load-balancing flag for Remote Delivery Gateways

2023-01-19 Thread GitBox
AdBuch commented on code in PR #1403: URL: https://github.com/apache/james-project/pull/1403#discussion_r1081231566 ## server/apps/spring-app/src/main/resources/mailetcontainer.xml: ## @@ -354,6 +354,11 @@ Regards, Postmaster XXX.YYY otherserver.mydomain.com

[GitHub] [james-project] AdBuch commented on a diff in pull request #1403: JAMES-3876 Load-balancing flag for Remote Delivery Gateways

2023-01-19 Thread GitBox
AdBuch commented on code in PR #1403: URL: https://github.com/apache/james-project/pull/1403#discussion_r1081230664 ## server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/remote/delivery/RemoteDeliveryConfiguration.java: ## @@ -281,6 +288,14 @@ public

[GitHub] [james-project] chibenwa commented on a diff in pull request #1403: JAMES-3876 Load-balancing flag for Remote Delivery Gateways

2023-01-19 Thread GitBox
chibenwa commented on code in PR #1403: URL: https://github.com/apache/james-project/pull/1403#discussion_r1081137417 ## server/apps/spring-app/src/main/resources/mailetcontainer.xml: ## @@ -354,6 +354,11 @@ Regards, Postmaster XXX.YYY otherserver.mydomain.com

[GitHub] [james-project] AdBuch opened a new pull request, #1404: james-3875 for 3.7.4

2023-01-19 Thread GitBox
AdBuch opened a new pull request, #1404: URL: https://github.com/apache/james-project/pull/1404 fix james-3875 for 3.7.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] AdBuch opened a new pull request, #1403: JAMES-3876 Load-balancing flag for Remote Delivery Gateways

2023-01-19 Thread GitBox
AdBuch opened a new pull request, #1403: URL: https://github.com/apache/james-project/pull/1403 Implement round robin loadbalancing if multiple gateways are defined Add new Remote Delivery property loadBalancing. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [james-project] chibenwa commented on pull request #1402: JAMES-3875 JPAMailRepository fix

2023-01-19 Thread GitBox
chibenwa commented on PR #1402: URL: https://github.com/apache/james-project/pull/1402#issuecomment-1396806780 I think you can also open this PR against 3.7.x if you want to benefit from a potential 3.7.4. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [james-project] chibenwa merged pull request #1395: JAMES-3756 - Update Delegate/get, DelegatedAccount/get - return DelegationId in response

2023-01-18 Thread GitBox
chibenwa merged PR #1395: URL: https://github.com/apache/james-project/pull/1395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa merged pull request #1394: JAMES-3756 Delegate/set - destroy

2023-01-18 Thread GitBox
chibenwa merged PR #1394: URL: https://github.com/apache/james-project/pull/1394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa merged pull request #1392: JAMES-3867 Allow IMAP extensions configuration

2023-01-18 Thread GitBox
chibenwa merged PR #1392: URL: https://github.com/apache/james-project/pull/1392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1400: [boyscout] logs bound port when webmin server starts

2023-01-18 Thread GitBox
chibenwa commented on PR #1400: URL: https://github.com/apache/james-project/pull/1400#issuecomment-1396315384 Yes it looks like it... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [james-project] jeantil commented on pull request #1400: [boyscout] logs bound port when webmin server starts

2023-01-18 Thread GitBox
jeantil commented on PR #1400: URL: https://github.com/apache/james-project/pull/1400#issuecomment-1387744175 are these known flaky tests ? run 1 ``` redeliverShouldWorkAfterRestartForNewRegistration – org.apache.james.events.RabbitMQEventBusTest$LifeCycleTest$SingleEventBus

[GitHub] [james-project] jeantil opened a new pull request, #1400: [boyscout] logs bound port when webmin server starts

2023-01-18 Thread GitBox
jeantil opened a new pull request, #1400: URL: https://github.com/apache/james-project/pull/1400 Logging bound port at startup helps make sure the ops setup is correct. The idea was lifted from `AbstractConfigurableAsyncServer` which is used for the SMTP server. -- This is an automated

[GitHub] [james-project] jeantil commented on pull request #1399: [JAMES-3877] enables configuration of jdbc pool max connections

2023-01-18 Thread GitBox
jeantil commented on PR #1399: URL: https://github.com/apache/james-project/pull/1399#issuecomment-1386649495 Sorry about the checkstyle issue, I fixed it in a fixup :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [james-project] vttranlina commented on pull request #1397: [ENHANCEMENT] Use provided scope for James dependencies in extensions

2023-01-17 Thread GitBox
vttranlina commented on PR #1397: URL: https://github.com/apache/james-project/pull/1397#issuecomment-1386579794 My result before ``` -rw-rw-r-- 1 tungtv tungtv16322 Thg 1 18 13:43 apache-james-clamav-3.8.0-SNAPSHOT.jar -rw-rw-r-- 1 tungtv tungtv 37880037 Thg 1 18 13:43

[GitHub] [james-project] chibenwa merged pull request #1398: JAMES-3756 DelegatedAccount/set destroy

2023-01-17 Thread GitBox
chibenwa merged PR #1398: URL: https://github.com/apache/james-project/pull/1398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] vttranlina commented on a diff in pull request #1394: JAMES-3756 Delegate/set - destroy

2023-01-17 Thread GitBox
vttranlina commented on code in PR #1394: URL: https://github.com/apache/james-project/pull/1394#discussion_r1073068197 ##

[GitHub] [james-project] vttranlina commented on pull request #1395: JAMES-3756 - Update Delegate/get, DelegatedAccount/get - return DelegationId in response

2023-01-17 Thread GitBox
vttranlina commented on PR #1395: URL: https://github.com/apache/james-project/pull/1395#issuecomment-1386439509 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] chibenwa commented on pull request #1399: [JAMES-3877] enables configuration of jdbc pool max connections

2023-01-17 Thread GitBox
chibenwa commented on PR #1399: URL: https://github.com/apache/james-project/pull/1399#issuecomment-1386353126 ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (check-style) on project james-server-jpa-common-guice: You have 1 Checkstyle

[GitHub] [james-project] quantranhong1999 commented on pull request #1397: [ENHANCEMENT] Use provided scope for James dependencies in extensions

2023-01-17 Thread GitBox
quantranhong1999 commented on PR #1397: URL: https://github.com/apache/james-project/pull/1397#issuecomment-1385035864 ```java 06:01:56,157 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-assembly-plugin:3.1.1:single (default) on project apache-james-clamav: Failed to

[GitHub] [james-project] chibenwa merged pull request #1396: [REFACTORING] pretty print MaybeSender when spooling mail

2023-01-16 Thread GitBox
chibenwa merged PR #1396: URL: https://github.com/apache/james-project/pull/1396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1394: JAMES-3756 Delegate/set - destroy

2023-01-16 Thread GitBox
chibenwa commented on PR #1394: URL: https://github.com/apache/james-project/pull/1394#issuecomment-1383956331 Please solve conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] chibenwa merged pull request #1391: JAMES-3756 Align the forbidden response when delegate users access ow…

2023-01-16 Thread GitBox
chibenwa merged PR #1391: URL: https://github.com/apache/james-project/pull/1391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1394: JAMES-3756 Delegate/set - destroy

2023-01-16 Thread GitBox
quantranhong1999 commented on code in PR #1394: URL: https://github.com/apache/james-project/pull/1394#discussion_r1071031091 ##

[GitHub] [james-project] chibenwa merged pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-16 Thread GitBox
chibenwa merged PR #1386: URL: https://github.com/apache/james-project/pull/1386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] vttranlina opened a new pull request, #1395: JAMES-3756 - Update Delegate/get, DelegatedAccount/get - return DelegationId in response

2023-01-16 Thread GitBox
vttranlina opened a new pull request, #1395: URL: https://github.com/apache/james-project/pull/1395 Currently, the get method returns AccountId as an id of delegation in response. => Update: use DelegationId, which is already (Same id as Delegate/Set method) -- This is an

[GitHub] [james-project] quantranhong1999 commented on pull request #1393: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
quantranhong1999 commented on PR #1393: URL: https://github.com/apache/james-project/pull/1393#issuecomment-1383485020 Hi, please cherry-pick https://github.com/quantranhong1999/james-project/commit/bf1461a9dc0f75d9ed1eb72cba13631fd9a5bd96 where I provide some fixes for this. -- This

[GitHub] [james-project] chibenwa closed pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
chibenwa closed pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source URL: https://github.com/apache/james-project/pull/1388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [james-project] chibenwa opened a new pull request, #1393: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
chibenwa opened a new pull request, #1393: URL: https://github.com/apache/james-project/pull/1393 Co-authored-by: Benoit TELLIER -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] quantranhong1999 commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
quantranhong1999 commented on PR #1388: URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383462694 > Ok, just I would need it for some other topics. For you: https://github.com/quantranhong1999/james-project/tree/rebase-poc-session-translator -- This is an

[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
chibenwa commented on PR #1388: URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383446688 Ok, just I would need it for some other topics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [james-project] quantranhong1999 commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
quantranhong1999 commented on PR #1388: URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383442939 > (I will do) I can do it, no worry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [james-project] chibenwa opened a new pull request, #1392: JAMES-3867 Allow IMAP extensions configuration

2023-01-15 Thread GitBox
chibenwa opened a new pull request, #1392: URL: https://github.com/apache/james-project/pull/1392 One can define custom, per-IMAP server configuration values. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-15 Thread GitBox
chibenwa commented on PR #1388: URL: https://github.com/apache/james-project/pull/1388#issuecomment-1383417966 TODO rebase https://github.com/chibenwa/james-project/tree/poc-refacto-delegation (I will do) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [james-project] chibenwa merged pull request #1390: [REFACTOING] Improve SessionProvider API

2023-01-15 Thread GitBox
chibenwa merged PR #1390: URL: https://github.com/apache/james-project/pull/1390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] vttranlina commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
vttranlina commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070752381 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/EventSourceRoutes.scala: ## @@ -188,10 +190,11 @@ class

[GitHub] [james-project] vttranlina commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
vttranlina commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070763285 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushListener.scala: ## @@ -58,15 +59,18 @@ object PushListener { }

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070761070 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushListener.scala: ## @@ -58,15 +59,18 @@ object PushListener {

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070761070 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushListener.scala: ## @@ -58,15 +59,18 @@ object PushListener {

[GitHub] [james-project] vttranlina commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
vttranlina commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070752381 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/EventSourceRoutes.scala: ## @@ -188,10 +190,11 @@ class

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1391: JAMES-3756 Align the forbidden response when delegate users access ow…

2023-01-12 Thread GitBox
quantranhong1999 opened a new pull request, #1391: URL: https://github.com/apache/james-project/pull/1391 …ner users delegation settings -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-12 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1068914331 ## event-bus/api/src/main/java/org/apache/james/events/EventBus.java: ## @@ -54,6 +55,13 @@ default Publisher register(EventListener listener,

[GitHub] [james-project] chibenwa merged pull request #1295: [UPGRADE] JSPF 1.0.1 -> 1.0.3

2023-01-12 Thread GitBox
chibenwa merged PR #1295: URL: https://github.com/apache/james-project/pull/1295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa merged pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-12 Thread GitBox
chibenwa merged PR #1382: URL: https://github.com/apache/james-project/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] vttranlina commented on pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-12 Thread GitBox
vttranlina commented on PR #1382: URL: https://github.com/apache/james-project/pull/1382#issuecomment-1379948717 green -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] chibenwa opened a new pull request, #1390: [REFACTOING] Improve SessionProvider API

2023-01-11 Thread GitBox
chibenwa opened a new pull request, #1390: URL: https://github.com/apache/james-project/pull/1390 - Decrease method cardinality for login / delegation methods - Remove uneeded methods - getPathDelimiter() - can be carried by the MailboxSession instead. No need to enforce the

[GitHub] [james-project] chibenwa closed pull request #1389: [REFACTOING] Improve SessionProvider API

2023-01-11 Thread GitBox
chibenwa closed pull request #1389: [REFACTOING] Improve SessionProvider API URL: https://github.com/apache/james-project/pull/1389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] chibenwa merged pull request #1384: [CLEAN CODE] JMAP QuotaGet, VacationResponseGet - remove dangling method

2023-01-11 Thread GitBox
chibenwa merged PR #1384: URL: https://github.com/apache/james-project/pull/1384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-11 Thread GitBox
chibenwa commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1067652828 ## event-bus/api/src/main/java/org/apache/james/events/EventBus.java: ## @@ -54,6 +55,13 @@ default Publisher register(EventListener listener, RegistrationKey

[GitHub] [james-project] chibenwa merged pull request #1387: JAMES-3756 DelegatedAccount/get

2023-01-11 Thread GitBox
chibenwa merged PR #1387: URL: https://github.com/apache/james-project/pull/1387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa merged pull request #1385: JAMES-3756 Delegate/get

2023-01-11 Thread GitBox
chibenwa merged PR #1385: URL: https://github.com/apache/james-project/pull/1385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa closed pull request #1374: POC support delegation for JMAP API

2023-01-11 Thread GitBox
chibenwa closed pull request #1374: POC support delegation for JMAP API URL: https://github.com/apache/james-project/pull/1374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [james-project] chibenwa opened a new pull request, #1389: [REFACTOING] Improve SessionProvider API

2023-01-11 Thread GitBox
chibenwa opened a new pull request, #1389: URL: https://github.com/apache/james-project/pull/1389 - Decrease method cardinality for login / delegation methods - Remove uneeded methods - getPathDelimiter() - can be carried by the MailboxSession instead. No need to enforce the

[GitHub] [james-project] chibenwa commented on pull request #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-11 Thread GitBox
chibenwa commented on PR #1388: URL: https://github.com/apache/james-project/pull/1388#issuecomment-1378571262 I have two major issues wit this design: - 1. the naming suck (): too long, not precise - 2. with this change SessionProvider exposes the APIs to bypass its own role

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1388: JAMES-3756 SessionTranslator should only ask 1 delegation source

2023-01-11 Thread GitBox
quantranhong1999 opened a new pull request, #1388: URL: https://github.com/apache/james-project/pull/1388 Instead of two sources with the same truth (https://github.com/linagora/james-project/issues/4673). (`sessionProvider.authenticate(session.getUser).as(targetUser)` called the 2nd

[GitHub] [james-project] quantranhong1999 commented on pull request #1384: [CLEAN CODE] JMAP QuotaGet, VacationResponseGet - remove dangling method

2023-01-11 Thread GitBox
quantranhong1999 commented on PR #1384: URL: https://github.com/apache/james-project/pull/1384#issuecomment-1378367747 conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1385: JAMES-3756 Delegate/get

2023-01-10 Thread GitBox
quantranhong1999 commented on code in PR #1385: URL: https://github.com/apache/james-project/pull/1385#discussion_r108856 ##

[GitHub] [james-project] chibenwa commented on a diff in pull request #1387: JAMES-3756 DelegatedAccount/get

2023-01-10 Thread GitBox
chibenwa commented on code in PR #1387: URL: https://github.com/apache/james-project/pull/1387#discussion_r1066634179 ##

[GitHub] [james-project] chibenwa commented on pull request #1385: JAMES-3756 Delegate/get

2023-01-10 Thread GitBox
chibenwa commented on PR #1385: URL: https://github.com/apache/james-project/pull/1385#issuecomment-1378315394 I find it hard to read those tests because I just do not know whose accountId that is. Suggestion: do, in all delegation method tests : ``` "accountId":

[GitHub] [james-project] chibenwa merged pull request #1381: [PERF] Handle range in UnseenSearchOverride

2023-01-10 Thread GitBox
chibenwa merged PR #1381: URL: https://github.com/apache/james-project/pull/1381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1381: [PERF] Handle range in UnseenSearchOverride

2023-01-10 Thread GitBox
chibenwa commented on PR #1381: URL: https://github.com/apache/james-project/pull/1381#issuecomment-1378308780 Perf tests shows a 3x speedup despite onging degraded performance on OVH side (mean 49ms p99 236 ms while before this was mean 286 ms p99 742 ms) -- This is an automated

[GitHub] [james-project] vttranlina commented on pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-10 Thread GitBox
vttranlina commented on PR #1382: URL: https://github.com/apache/james-project/pull/1382#issuecomment-1378246667 rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] chibenwa merged pull request #1383: [PERF] Avoid converting mailbox list to map for all mailboxes

2023-01-10 Thread GitBox
chibenwa merged PR #1383: URL: https://github.com/apache/james-project/pull/1383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-10 Thread GitBox
chibenwa commented on PR #1382: URL: https://github.com/apache/james-project/pull/1382#issuecomment-1378194960 Please rebase @vttranlina -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [james-project] chibenwa commented on pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
chibenwa commented on PR #1386: URL: https://github.com/apache/james-project/pull/1386#issuecomment-1378195100 Don't forget to rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] chibenwa merged pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-10 Thread GitBox
chibenwa merged PR #1380: URL: https://github.com/apache/james-project/pull/1380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa merged pull request #1375: JAMES-3756 Delegate/set create

2023-01-10 Thread GitBox
chibenwa merged PR #1375: URL: https://github.com/apache/james-project/pull/1375 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
chibenwa commented on PR #1386: URL: https://github.com/apache/james-project/pull/1386#issuecomment-1378147640 Alternative design idea: Allow the event bus to register several key for a listener: ``` default Publisher register(EventListener.ReactiveEventListener

[GitHub] [james-site] dependabot[bot] opened a new pull request, #30: Bump convict, @antora/cli and @antora/site-generator-default in /doc-sites

2023-01-10 Thread GitBox
dependabot[bot] opened a new pull request, #30: URL: https://github.com/apache/james-site/pull/30 Bumps [convict](https://github.com/mozilla/node-convict) to 6.2.4 and updates ancestor dependencies [convict](https://github.com/mozilla/node-convict),

[GitHub] [james-project] chibenwa commented on a diff in pull request #1385: JAMES-3756 Delegate/get

2023-01-10 Thread GitBox
chibenwa commented on code in PR #1385: URL: https://github.com/apache/james-project/pull/1385#discussion_r1065963481 ##

[GitHub] [james-project] chibenwa commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
chibenwa commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1065957779 ##

[GitHub] [james-project] chibenwa commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
chibenwa commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1065956696 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala: ## @@ -134,6 +136,12 @@ class WebSocketRoutes @Inject()

[GitHub] [james-project] chibenwa commented on pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
chibenwa commented on PR #1386: URL: https://github.com/apache/james-project/pull/1386#issuecomment-1377475151 SSE ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1065631209 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala: ## @@ -134,6 +136,12 @@ class WebSocketRoutes

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
quantranhong1999 opened a new pull request, #1386: URL: https://github.com/apache/james-project/pull/1386 TODO: - [x] web push - [x] websocket - [ ] sse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [james-project] vttranlina opened a new pull request, #1384: [CLEAN CODE] JMAP QuotaGet, VacationResponseGet - remove dangling method

2023-01-10 Thread GitBox
vttranlina opened a new pull request, #1384: URL: https://github.com/apache/james-project/pull/1384 - method `handleRequestValidationErrors` is already in the abstract class (JmapAPI & Method) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [james-project] vttranlina commented on a diff in pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
vttranlina commented on code in PR #1382: URL: https://github.com/apache/james-project/pull/1382#discussion_r1065408878 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala: ## @@ -297,14 +298,14 @@ class DownloadRoutes

[GitHub] [james-project] quantranhong1999 commented on pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
quantranhong1999 commented on PR #1380: URL: https://github.com/apache/james-project/pull/1380#issuecomment-1376693874 Rebased to solve conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [james-project] quantranhong1999 commented on pull request #1375: JAMES-3756 Delegate/set create

2023-01-09 Thread GitBox
quantranhong1999 commented on PR #1375: URL: https://github.com/apache/james-project/pull/1375#issuecomment-1376688078 Rebased to solve conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [james-project] chibenwa merged pull request #1376: JAMES-3756 Show the list of accounts being delegated accounts in JMAP session

2023-01-09 Thread GitBox
chibenwa merged PR #1376: URL: https://github.com/apache/james-project/pull/1376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on pull request #1376: JAMES-3756 Show the list of accounts being delegated accounts in JMAP session

2023-01-09 Thread GitBox
chibenwa commented on PR #1376: URL: https://github.com/apache/james-project/pull/1376#issuecomment-1376593217 Are you OK with this, @quantranhong1999 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [james-project] chibenwa merged pull request #1377: [UPGRADE] January 2023 dependency upgrades

2023-01-09 Thread GitBox
chibenwa merged PR #1377: URL: https://github.com/apache/james-project/pull/1377 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1382: URL: https://github.com/apache/james-project/pull/1382#discussion_r1064750069 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/UploadRoutes.scala: ## @@ -113,27 +115,30 @@ class UploadRoutes

[GitHub] [james-project] chibenwa commented on a diff in pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1382: URL: https://github.com/apache/james-project/pull/1382#discussion_r1064748692 ## server/protocols/jmap-rfc-8621-integration-tests/memory-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/memory/MemoryUploadTest.java:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1382: URL: https://github.com/apache/james-project/pull/1382#discussion_r1064747554 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/DownloadRoutes.scala: ## @@ -297,14 +298,14 @@ class DownloadRoutes

[GitHub] [james-project] chibenwa commented on a diff in pull request #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1382: URL: https://github.com/apache/james-project/pull/1382#discussion_r1064742796 ## server/protocols/jmap-rfc-8621-integration-tests/memory-jmap-rfc-8621-integration-tests/src/test/java/org/apache/james/jmap/rfc8621/memory/MemoryDownloadTest.java:

[GitHub] [james-project] vttranlina opened a new pull request, #1382: JAMES-3756 JMAP endpoint (upload/download) should support being called with accountIds of delegated accounts

2023-01-09 Thread GitBox
vttranlina opened a new pull request, #1382: URL: https://github.com/apache/james-project/pull/1382 resolve https://github.com/linagora/james-project/issues/4679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [james-project] chibenwa commented on a diff in pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1380: URL: https://github.com/apache/james-project/pull/1380#discussion_r1064451688 ##

[GitHub] [james-project] chibenwa commented on a diff in pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1380: URL: https://github.com/apache/james-project/pull/1380#discussion_r1064450688 ##

[GitHub] [james-project] vttranlina commented on a diff in pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
vttranlina commented on code in PR #1380: URL: https://github.com/apache/james-project/pull/1380#discussion_r1064422457 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/SessionTranslator.scala: ## @@ -0,0 +1,51 @@

[GitHub] [james-project] chibenwa merged pull request #1363: SMTP AuthCmdHandler support doDelegation method

2023-01-09 Thread GitBox
chibenwa merged PR #1363: URL: https://github.com/apache/james-project/pull/1363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
chibenwa commented on code in PR #1380: URL: https://github.com/apache/james-project/pull/1380#discussion_r1064381254 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/SessionTranslator.scala: ## @@ -0,0 +1,51 @@

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-09 Thread GitBox
quantranhong1999 commented on code in PR #1380: URL: https://github.com/apache/james-project/pull/1380#discussion_r1064372844 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/SessionTranslator.scala: ## @@ -0,0 +1,51 @@

[GitHub] [james-project] quantranhong1999 commented on pull request #1375: JAMES-3756 Delegate/set create

2023-01-09 Thread GitBox
quantranhong1999 commented on PR #1375: URL: https://github.com/apache/james-project/pull/1375#issuecomment-1375247199 Fix some tiny comments, and rebase with a separate commit for `DelegationProbe` (so ones could use cherry pick if they need). -- This is an automated message from the

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1380: JAMES-3756 JMAP API endpoint should support delegation

2023-01-08 Thread GitBox
quantranhong1999 opened a new pull request, #1380: URL: https://github.com/apache/james-project/pull/1380 - [x] Delegation for JMAP API (QUAN) - [ ] Delegate/set only be called by primaryAccount (QUAN) Others (could be in diff PRs): - [ ] Delegation for upload (TUNG) -

[GitHub] [james-project] chibenwa commented on a diff in pull request #1375: JAMES-3756 Delegate/set create

2023-01-08 Thread GitBox
chibenwa commented on code in PR #1375: URL: https://github.com/apache/james-project/pull/1375#discussion_r1064342645 ##

  1   2   3   4   5   6   7   8   9   10   >