[GitHub] [james-project] Arsnael commented on pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-22 Thread via GitHub
Arsnael commented on PR #1673: URL: https://github.com/apache/james-project/pull/1673#issuecomment-1687888268 ``` 09:50:13,857 [INFO] There is 1 error reported by Checkstyle 10.12.1 with checkstyle.xml ruleset. 09:50:13,859 [ERROR]

[GitHub] [james-project] Arsnael commented on pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-22 Thread via GitHub
Arsnael commented on PR #1673: URL: https://github.com/apache/james-project/pull/1673#issuecomment-1687781816 Approved but remembered this is still not solved: https://github.com/apache/james-project/pull/1673#discussion_r1295402581 Just put String for identifier , and I will be

[GitHub] [james-project] Arsnael commented on pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-17 Thread via GitHub
Arsnael commented on PR #1673: URL: https://github.com/apache/james-project/pull/1673#issuecomment-1681759228 Please rebase :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific