[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070761070 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushListener.scala: ## @@ -58,15 +59,18 @@ object PushListener {

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-15 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1070761070 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushListener.scala: ## @@ -58,15 +59,18 @@ object PushListener {

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-12 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1068914331 ## event-bus/api/src/main/java/org/apache/james/events/EventBus.java: ## @@ -54,6 +55,13 @@ default Publisher register(EventListener listener,

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1386: JAMES-3756 JMAP pushes should support delegation

2023-01-10 Thread GitBox
quantranhong1999 commented on code in PR #1386: URL: https://github.com/apache/james-project/pull/1386#discussion_r1065631209 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala: ## @@ -134,6 +136,12 @@ class WebSocketRoutes