Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-09 Thread via GitHub
chibenwa merged PR #1979: URL: https://github.com/apache/james-project/pull/1979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-06 Thread via GitHub
chibenwa commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1479820413 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
Arsnael commented on PR #1979: URL: https://github.com/apache/james-project/pull/1979#issuecomment-1928688139 Looks related: https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1979/4/testReport/org.apache.james.lmtpserver/LmtpServerTest$DSNTest/lhloShouldAdvertizeDSN/ -- This

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
Arsnael commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1479147227 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478908693 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
chibenwa commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478558838 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478512997 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
chibenwa commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478510601 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478508830 ## server/protocols/protocols-smtp/src/test/java/org/apache/james/smtpserver/SMTPServerTest.java: ## @@ -492,6 +494,80 @@ public void testReceivedHeader() throws

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478508830 ## server/protocols/protocols-smtp/src/test/java/org/apache/james/smtpserver/SMTPServerTest.java: ## @@ -492,6 +494,80 @@ public void testReceivedHeader() throws

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478506167 ## server/protocols/protocols-smtp/src/test/java/org/apache/james/smtpserver/SMTPServerTest.java: ## @@ -492,6 +494,80 @@ public void testReceivedHeader() throws

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478501786 ## server/protocols/protocols-smtp/src/test/java/org/apache/james/smtpserver/SMTPServerTest.java: ## @@ -492,6 +494,80 @@ public void testReceivedHeader() throws

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478500620 ## server/protocols/protocols-smtp/src/test/java/org/apache/james/smtpserver/SMTPServerTest.java: ## @@ -351,7 +353,7 @@ public void

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478497385 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

Re: [PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
jeantil commented on code in PR #1979: URL: https://github.com/apache/james-project/pull/1979#discussion_r1478497385 ## protocols/netty/src/main/java/org/apache/james/protocols/netty/NettyServer.java: ## @@ -88,6 +88,8 @@ private NettyServer(Protocol protocol, Encryption

[PR] [FIX] Apply RFC-5321 syntax validation for EHLO [james-project]

2024-02-05 Thread via GitHub
chibenwa opened a new pull request, #1979: URL: https://github.com/apache/james-project/pull/1979 https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.1 Syntax: ehlo = "EHLO" SP ( Domain / address-literal ) CRLF helo = "HELO" SP Domain CRLF