Arsnael merged PR #2068:
URL: https://github.com/apache/james-project/pull/2068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vttranlina commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-2005489321
> Or I will cherry-pick a commit from the master
I did cherry-pick commits from master
vttranlina commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-2003776940
> Can we merge this @vttranlina ?
This PR is using some code from master
I'm waiting for the task
https://github.com/linagora/james-project/issues/5110 done, then
quantranhong1999 commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-2003432012
Can we merge this @vttranlina ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Arsnael commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-1977957384
Why need to rebase after rebasing postgres branch with master btw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vttranlina commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-1975648269
- [ ] todo rebase after:
- https://github.com/linagora/james-project/issues/5110
--
This is an automated message from the Apache Git Service.
To respond to the message,
vttranlina commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1507204312
##
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/upload/UploadDAO.java:
##
@@ -171,6 +171,7 @@ public UploadDAO(CqlSession
vttranlina commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1507204312
##
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/upload/UploadDAO.java:
##
@@ -171,6 +171,7 @@ public UploadDAO(CqlSession
vttranlina commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1507168902
##
server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/upload/UploadServiceContract.scala:
##
@@ -126,6 +127,7 @@ trait UploadServiceContract {
chibenwa commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1507140243
##
server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/upload/UploadServiceContract.scala:
##
@@ -126,6 +127,7 @@ trait UploadServiceContract {
chibenwa commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1507139870
##
server/data/data-jmap-cassandra/src/main/java/org/apache/james/jmap/cassandra/upload/UploadDAO.java:
##
@@ -171,6 +171,7 @@ public UploadDAO(CqlSession
vttranlina commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-1970327221
> Can we contribute the non postgres enhancement on jmap upload to master
branch as well?
I've split it into the master branch here:
vttranlina commented on PR #2068:
URL: https://github.com/apache/james-project/pull/2068#issuecomment-1970314736
The CI failed looks like not related to this pr
I tried to test it on local, the test passed
Arsnael commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1506935821
##
server/data/data-jmap/src/test/java/org/apache/james/jmap/api/upload/UploadRepositoryContract.scala:
##
@@ -206,4 +206,17 @@
.isNotNull
}
+
vttranlina commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1506928950
##
server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/upload/UploadServiceContract.scala:
##
@@ -108,6 +108,7 @@ trait UploadServiceContract {
quantranhong1999 commented on code in PR #2068:
URL: https://github.com/apache/james-project/pull/2068#discussion_r1506918214
##
server/data/data-jmap/src/test/scala/org/apache/james/jmap/api/upload/UploadServiceContract.scala:
##
@@ -108,6 +108,7 @@ trait UploadServiceContract
vttranlina opened a new pull request, #2068:
URL: https://github.com/apache/james-project/pull/2068
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
17 matches
Mail list logo
