Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-03-03 Thread via GitHub
vttranlina commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1510547524 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailSubmissionSetMethod.scala: ## @@ -337,6 +338,24 @@ class

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-03-01 Thread via GitHub
chibenwa commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1509204762 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/EmailSubmissionSetMethod.scala: ## @@ -337,6 +338,24 @@ class

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-25 Thread via GitHub
chibenwa merged PR #2040: URL: https://github.com/apache/james-project/pull/2040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-25 Thread via GitHub
chibenwa commented on PR #2040: URL: https://github.com/apache/james-project/pull/2040#issuecomment-1963077030 org.apache.james.jmap.rfc8621.memory.MemoryEmailSubmissionSetMethodTest.emailSubmissionSetCanBeChainedAfterEmailSet(GuiceJamesServer) Failing for the past 1 build (Since

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-25 Thread via GitHub
chibenwa commented on PR #2040: URL: https://github.com/apache/james-project/pull/2040#issuecomment-1963077075 Related? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
chibenwa commented on PR #2040: URL: https://github.com/apache/james-project/pull/2040#issuecomment-1961129004 https://github.com/linagora/james-project/issues/5086#issuecomment-1961127529 How about by the time we get this fixed we filter in the JMAP stack the lone > email? Not clean

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
chibenwa commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500481449 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
vttranlina commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500471673 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
vttranlina commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500468033 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
vttranlina commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500465538 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
chibenwa commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500466503 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
chibenwa commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500467085 ##

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-23 Thread via GitHub
vttranlina commented on PR #2040: URL: https://github.com/apache/james-project/pull/2040#issuecomment-1961065817 > * Please add a test to ensure that `EmailSubmission/set` is not able to send a mail with invalid addresses... updated it in last commit

Re: [PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-22 Thread via GitHub
Arsnael commented on code in PR #2040: URL: https://github.com/apache/james-project/pull/2040#discussion_r1500165669 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/EmailSet.scala: ## @@ -316,6 +350,24 @@ case class EmailCreationRequest(mailboxIds:

[PR] JAMES-4008 JMAP - Email/set - Should be able to save a draft with invalid email address [james-project]

2024-02-22 Thread via GitHub
vttranlina opened a new pull request, #2040: URL: https://github.com/apache/james-project/pull/2040 jira https://issues.apache.org/jira/browse/JAMES-4008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above