chibenwa merged PR #1963:
URL: https://github.com/apache/james-project/pull/1963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-2006058834
> Let's merge?
We could I guess. Don't forget to conclude the decision on the mailing list
^^.
--
This is an automated message from the Apache Git Service.
To
chibenwa commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-2005958146
Let's merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-2005678592
Green :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1975660958
There was a minor conflict in pom.xml, so I rebased and force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chibenwa commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1961528452
Rebase needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1490687230
##
server/container/lifecycle-api/src/test/java/org/apache/james/lifecycle/api/LeakAwareTest.java:
##
@@ -76,18 +73,13 @@ public static ListAppender
jeantil commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1945645279
thanks I'll try and review again over lunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1945639458
CC @jeantil I reworked a bit the commit history and brought back the RRT
data-file test.
--
This is an automated message from the Apache Git Service.
To respond to the
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1490570258
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
> Are you
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1490565847
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
Are you 100% sure that
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1490494180
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
> only the
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1481022806
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
the commit comment
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1481016757
##
pom.xml:
##
@@ -3514,7 +3514,7 @@
-
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480849236
##
pom.xml:
##
@@ -3514,7 +3514,7 @@
-
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480837904
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
> i wouldn't
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480837904
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
> i wouldn't
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480833691
##
mailbox/jpa/pom.xml:
##
@@ -31,6 +31,10 @@
jar
Apache James :: Mailbox :: JPA
+
Review Comment:
> does it mean we need to have
quantranhong1999 commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480834101
##
pom.xml:
##
@@ -3514,7 +3514,7 @@
-
Arsnael commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1931127842
> well spark maybe, I saw in the other PR that it was not a great upgrade,
but reverting security patches really sounds weird
As said by @chibenwa, need a good rebase.
chibenwa commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1930893024
> I don't understand commits
>>Revert "[UPDATE] Update spark version: Jetty update"
>>Revert "[UPDATE] BouncyCastle 1.70 -> 1.77 (fixes multiple minor CVEs)"
>>
chibenwa commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480625284
##
pom.xml:
##
@@ -2962,6 +2962,21 @@
+
+
+
+false
+
+
+true
+
jeantil commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1930748074
I don't understand commits
- Revert "[UPDATE] Update spark version: Jetty update"
- Revert "[UPDATE] BouncyCastle 1.70 -> 1.77 (fixes multiple minor CVEs)"
well spark
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480535904
##
pom.xml:
##
@@ -2831,11 +2831,6 @@
mockito-core
${mockito.version}
-
Review Comment:
hmm maybe
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480533860
##
pom.xml:
##
@@ -621,7 +621,7 @@
1.3.4
4.21
4.1.101.Final
-7.14.1
+7.15.0
Review Comment:
seems like a fixup!
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480529668
##
mailbox/memory/pom.xml:
##
@@ -72,6 +72,7 @@
${james.groupId}
james-json
+test-jar
Review Comment:
fixup!
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480529287
##
mailbox/jpa/pom.xml:
##
@@ -91,6 +91,7 @@
${james.groupId}
james-json
+test-jar
Review Comment:
fixup!
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480521828
##
pom.xml:
##
@@ -2962,6 +2962,21 @@
+
+
+
+false
+
+
+true
+
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480519018
##
pom.xml:
##
@@ -3514,7 +3514,7 @@
-
jeantil commented on code in PR #1963:
URL: https://github.com/apache/james-project/pull/1963#discussion_r1480517633
##
mailbox/jpa/pom.xml:
##
@@ -31,6 +31,10 @@
jar
Apache James :: Mailbox :: JPA
+
Review Comment:
How does this behave in IDEs ? does it
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1920492131
The LDAP test failures seems not related to me (green locally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chibenwa commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1917024702
> so we can fasten the JDK21-related
Why need to fasten? Likely a vote on the mailing list would be a
pre-requisite to a merge...
> fix the broken master also)
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1916650538
> Please take the time to investigate...
Yes, for sure. But are you ok with investigating the unstable tests in
another PR? (so we can fasten the JDK21-related work
chibenwa commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1916625103
Please take the time to investigate...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1916563049
Green.
Some unstable tests failing though:
https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-1963/2/tests/
```java
Arsnael commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1916171548
I'm trying to get a green build for master but I think the commits here
should do the trick: https://github.com/apache/james-project/pull/1957
Feel free to cherry-pick them
quantranhong1999 commented on PR #1963:
URL: https://github.com/apache/james-project/pull/1963#issuecomment-1916163930
The failed webadmin tests, I guess it is related to current master issue.
`JPARecomputeCurrentQuotasServiceTest` and
`MemoryRecomputeCurrentQuotasServiceTest`
quantranhong1999 opened a new pull request, #1963:
URL: https://github.com/apache/james-project/pull/1963
continuation of https://github.com/apache/james-project/pull/1939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
38 matches
Mail list logo
