Re: [PR] Create AttachmentIdFactory [james-project]

2024-03-19 Thread via GitHub
quantranhong1999 commented on PR #2133: URL: https://github.com/apache/james-project/pull/2133#issuecomment-2008600988 > Should I put JAMES-2586 to this? The purpose of this PR is only refactoring code in master and creating AttachmentIdFactory so that I can implement new AttachmentId for

Re: [PR] Create AttachmentIdFactory [james-project]

2024-03-19 Thread via GitHub
hungphan227 commented on PR #2133: URL: https://github.com/apache/james-project/pull/2133#issuecomment-2008598263 > Any ticket number or tag for this work? Should I put JAMES-2586 to this? The purpose of this PR is only refactoring code in master and creating AttachmentIdFactory so

Re: [PR] Create AttachmentIdFactory [james-project]

2024-03-19 Thread via GitHub
quantranhong1999 commented on PR #2133: URL: https://github.com/apache/james-project/pull/2133#issuecomment-2008584603 Any ticket number or tag for this work? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Create AttachmentIdFactory [james-project]

2024-03-19 Thread via GitHub
Arsnael commented on PR #2133: URL: https://github.com/apache/james-project/pull/2133#issuecomment-2008569245 ``` 12:15:19,569 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.3.0:check (check-style) on project apache-james-mailbox-jpa: You have 2