[GitHub] [james-project] Arsnael commented on a diff in pull request #1623: JAMES-3924 RabbitMQ mail queue updates: not performed

2023-07-02 Thread via GitHub
Arsnael commented on code in PR #1623: URL: https://github.com/apache/james-project/pull/1623#discussion_r1250230235 ## server/queue/queue-rabbitmq/src/test/java/org/apache/james/queue/rabbitmq/RabbitMQMailQueueTest.java: ## @@ -678,9 +705,13 @@ void

[GitHub] [james-project] Arsnael commented on pull request #1624: JAMES 3551 - implement naive mailbox query changes

2023-07-02 Thread via GitHub
Arsnael commented on PR #1624: URL: https://github.com/apache/james-project/pull/1624#issuecomment-1617312429 The commit description needs to have the JIRA ticket number as well and it should precise it's for Mailbox/queryChanges as well, not just any query changes method :) -- This is

[GitHub] [james-project] hungphan227 opened a new pull request, #1624: JAMES 3551 - implement naive mailbox query changes

2023-07-02 Thread via GitHub
hungphan227 opened a new pull request, #1624: URL: https://github.com/apache/james-project/pull/1624 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1624: JAMES 3551 - implement naive mailbox query changes

2023-07-02 Thread via GitHub
quantranhong1999 commented on code in PR #1624: URL: https://github.com/apache/james-project/pull/1624#discussion_r1250170069 ## server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/method/QueryChangesMethod.scala: ## @@ -0,0 +1,51 @@

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1624: JAMES 3551 - implement naive mailbox query changes

2023-07-02 Thread via GitHub
quantranhong1999 commented on code in PR #1624: URL: https://github.com/apache/james-project/pull/1624#discussion_r1250142718 ## server/container/guice/protocols/jmap/src/main/java/org/apache/james/jmap/rfc8621/RFC8621MethodsModule.java: ## @@ -46,39 +46,7 @@ import

[GitHub] [james-project] Arsnael commented on a diff in pull request #1624: JAMES 3551 - implement naive mailbox query changes

2023-07-02 Thread via GitHub
Arsnael commented on code in PR #1624: URL: https://github.com/apache/james-project/pull/1624#discussion_r1250210078 ##