vttranlina commented on code in PR #1804:
URL: https://github.com/apache/james-project/pull/1804#discussion_r1400159207
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresUidProvider.java:
##
@@ -0,0 +1,93 @@
chibenwa opened a new pull request, #1805:
URL: https://github.com/apache/james-project/pull/1805
CF https://github.com/linagora/james-project/issues/4943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Arsnael commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400277167
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
hungphan227 commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400298722
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
Arsnael opened a new pull request, #1807:
URL: https://github.com/apache/james-project/pull/1807
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
hungphan227 commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400189167
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
chibenwa commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400199332
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
quantranhong1999 opened a new pull request, #1806:
URL: https://github.com/apache/james-project/pull/1806
resolve https://github.com/linagora/james-project/issues/4939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vttranlina commented on PR #1804:
URL: https://github.com/apache/james-project/pull/1804#issuecomment-1820652425
A lot of test classes depend on `JPAMessageMapper`, `JPAMailboxMapper` .
Special is JPAMessageMapper is using JPA MAILBOX for query some logic.
When I tried to "only"
chibenwa commented on code in PR #1806:
URL: https://github.com/apache/james-project/pull/1806#discussion_r1400411787
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##
@@ -51,6 +60,19 @@
public class PostgresMailboxDAO {
Arsnael commented on code in PR #1804:
URL: https://github.com/apache/james-project/pull/1804#discussion_r1400272851
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/PostgresUidProvider.java:
##
@@ -0,0 +1,93 @@
vttranlina commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400270234
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
chibenwa commented on code in PR #1806:
URL: https://github.com/apache/james-project/pull/1806#discussion_r1400413280
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##
@@ -88,6 +110,34 @@ private Mono update(Mailbox
Arsnael commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400266741
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
quantranhong1999 commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400309455
##
server/apps/postgres-app/src/main/java/org/apache/james/PostgresJamesServerMain.java:
##
@@ -85,6 +86,7 @@ public class PostgresJamesServerMain
chibenwa commented on code in PR #1806:
URL: https://github.com/apache/james-project/pull/1806#discussion_r1400409579
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresTableManager.java:
##
@@ -58,6 +58,14 @@ public
chibenwa commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1400274158
##
server/data/data-postgres/src/main/java/org/apache/james/user/postgres/PostgresUsersDAO.java:
##
@@ -0,0 +1,137 @@
vttranlina commented on code in PR #1806:
URL: https://github.com/apache/james-project/pull/1806#discussion_r1400386900
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresTableManager.java:
##
@@ -58,6 +58,14 @@ public
vttranlina commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1400393445
##
server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java:
##
@@ -0,0 +1,86 @@
chibenwa commented on code in PR #1804:
URL: https://github.com/apache/james-project/pull/1804#discussion_r1400405712
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##
@@ -140,4 +143,38 @@ private Mailbox asMailbox(Record
chibenwa commented on code in PR #1806:
URL: https://github.com/apache/james-project/pull/1806#discussion_r1400413280
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##
@@ -88,6 +110,34 @@ private Mono update(Mailbox
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 351cc273fd2e12770d2d69b2306992940e8ac6c3
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:09:20 2023 +0100
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 2932ca8b4521fbcf200fa242d2169bfb9c47a39f
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:07:55 2023 +0100
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit b15787fa343a85c377bdb0bb3500d6598c57cfe9
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:10:11 2023 +0100
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 9263c2076931b44ac9c6be2c3cf19e9456e80757
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:08:40 2023 +0100
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 5da0b15180c3e85b8d480ba8c5e98b3a5094c85d
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:07:07 2023 +0100
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
from ccbc4b26d2 JAMES-3962 JMAP Email/set: specific headers for body parts
(#1801)
new 5da0b15180 [UPGRADE]
chibenwa merged PR #1805:
URL: https://github.com/apache/james-project/pull/1805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 3dd1b53612f44a2c92c814325204142c7f30f298
Author: Benoit TELLIER
AuthorDate: Tue Nov 21 10:10:50 2023 +0100
chibenwa commented on code in PR #1804:
URL: https://github.com/apache/james-project/pull/1804#discussion_r1400722052
##
mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxDAO.java:
##
@@ -140,4 +143,38 @@ private Mailbox asMailbox(Record
vttranlina opened a new pull request, #1808:
URL: https://github.com/apache/james-project/pull/1808
jira https://issues.apache.org/jira/browse/JAMES-2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vttranlina commented on PR #1808:
URL: https://github.com/apache/james-project/pull/1808#issuecomment-1821918796
I think we can hang it because JPA Message Mapper still depends on JPA
Mailbox, It should be continued after Postgres Message Mapper completed
--
This is an automated message
Arsnael commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1401419033
##
server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java:
##
@@ -0,0 +1,86 @@
Arsnael commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-1821979136
```
Unable to create injector, see the following errors:
1) [Guice/MissingImplementation]: No implementation for Mono was
bound.
Requested by:
1 :
thanhbv200585 commented on code in PR #1788:
URL: https://github.com/apache/james-project/pull/1788#discussion_r1401427256
##
third-party/crowdsec/pom.xml:
##
@@ -49,6 +55,22 @@
jackson-datatype-jdk8
test
+
+
hungphan227 commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1401482610
##
server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java:
##
@@ -0,0 +1,86 @@
Arsnael commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1401571908
##
server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java:
##
@@ -0,0 +1,86 @@
Arsnael commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-187871
```
SQL [select *
from domains
where domain = $1]; relation "domains" does not exist
```
Hmmm maybe we dont create well tables when starting James?
quantranhong1999 commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-1822237529
> EDIT: forget it those tests use empty postgres modules... (not normal
though :) )
Hmm, we do not inject Postgres module into the extension in Integration
tests
Arsnael commented on code in PR #1804:
URL: https://github.com/apache/james-project/pull/1804#discussion_r1401581265
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PostgresExecutor.java:
##
@@ -39,13 +41,30 @@
public class PostgresExecutor
chibenwa commented on code in PR #1788:
URL: https://github.com/apache/james-project/pull/1788#discussion_r1401599115
##
third-party/crowdsec/src/main/java/org/apache/james/model/CrowdsecHttpClient.java:
##
@@ -0,0 +1,96 @@
Arsnael commented on PR #1803:
URL: https://github.com/apache/james-project/pull/1803#issuecomment-1822231762
Looks overall ok, but I suspect something hiding underneath, like in the
domain list PR. I think should remove the JPA binding for UserRepository in the
persistence.xml file. I
vttranlina commented on PR #1804:
URL: https://github.com/apache/james-project/pull/1804#issuecomment-1822025189
rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
quantranhong1999 commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1401552884
##
server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java:
##
@@ -0,0 +1,86 @@
hungphan227 commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1401457070
##
server/apps/postgres-app/src/main/java/org/apache/james/PostgresJamesServerMain.java:
##
@@ -85,6 +86,7 @@ public class PostgresJamesServerMain implements
Arsnael commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-1822160882
I still have that binding issue with the Monofrom
PostgresExecutor... Seems tricky
--
This is an automated message from the Apache Git Service.
To respond to the message, please
quantranhong1999 commented on code in PR #1803:
URL: https://github.com/apache/james-project/pull/1803#discussion_r1401547772
##
server/apps/postgres-app/src/main/java/org/apache/james/PostgresJamesServerMain.java:
##
@@ -114,8 +114,6 @@ public static void main(String[] args)
Arsnael commented on PR #1806:
URL: https://github.com/apache/james-project/pull/1806#issuecomment-1822205724
Related:
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1806/1/testReport/
--
This is an automated message from the Apache Git Service.
To respond to the message,
chibenwa commented on code in PR #1807:
URL: https://github.com/apache/james-project/pull/1807#discussion_r1401640852
##
server/apps/postgres-app/src/test/java/org/apache/james/PostgresJamesServerWithAuthenticatedDatabaseSqlValidationTest.java:
##
@@ -35,7 +37,7 @@ class
Arsnael commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-1822197260
Also I noticed that our test setup in postgres app is wrong... we still run
a derby it seems aside postgres for the jpa logic. We for sure just want one
postgres for the ixed
chibenwa commented on PR #1808:
URL: https://github.com/apache/james-project/pull/1808#issuecomment-183426
How does it depend on it?
Cascading deletes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Arsnael commented on PR #1807:
URL: https://github.com/apache/james-project/pull/1807#issuecomment-1822250642
@quantranhong1999 Was it? Alright yes my next step is to check if domain is
created... I agree it should not be added and James should create the tables.
The last commit makes this
52 matches
Mail list logo
