Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
chibenwa commented on PR #1900: URL: https://github.com/apache/james-project/pull/1900#issuecomment-1884297277 Please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(james-project) 03/05: JAMES-2586 Plug DeletedMessageVaultDeletionCallback into DeleteMessageListener

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit de96f76fd9f562cfd2dfebacee7b3858a3716af5 Author: Quan Tran AuthorDate: Mon Jan 8 10:27:48 2024 +0700

(james-project) 02/05: JAMES-2586 Guice binding + module chooser + sample config for Postgres DeletedMessageVault

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit 55a09898a5c7501c3460ce37d847ed38f133d593 Author: Quan Tran AuthorDate: Tue Jan 2 16:09:28 2024 +0700

(james-project) 04/05: JAMES-2586 PostgresDeletedMessageVaultIntegrationTest

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit bf9a4b1d00594219269665232ea05de80edc3d8f Author: Quan Tran AuthorDate: Mon Jan 8 14:43:47 2024 +0700

(james-project) branch postgresql updated (c43b2c544e -> bf5f99e455)

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a change to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git from c43b2c544e JAMES-2586 Refactor the way initPostgres of PostgresTableManager new c2dbfc579f

(james-project) 01/05: JAMES-2586 Implement PostgresDeletedMessageMetadataVault

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit c2dbfc579f41e6aef0475da24f804d9cb21b59d5 Author: Quan Tran AuthorDate: Tue Jan 2 15:05:05 2024 +0700

(james-project) 05/05: JAMES-2586 Plug PreDeletionHooks

2024-01-09 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit bf5f99e4556e82221289a14eee9995987680447c Author: Quan Tran AuthorDate: Mon Jan 8 15:39:09 2024 +0700

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-09 Thread via GitHub
chibenwa merged PR #1891: URL: https://github.com/apache/james-project/pull/1891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1900: URL: https://github.com/apache/james-project/pull/1900#discussion_r1445754030 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresConfiguration.java: ## @@ -99,36 +162,22 @@ public Builder

[PR] [SITE] for 3.7.5 and 3.8.1 releases [james-project]

2024-01-09 Thread via GitHub
chibenwa opened a new pull request, #1907: URL: https://github.com/apache/james-project/pull/1907 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] JAMES-3953 Performance enhancements [james-project]

2024-01-09 Thread via GitHub
chibenwa opened a new pull request, #1906: URL: https://github.com/apache/james-project/pull/1906 Avoid partial reads and array concatenations. CF: https://github.com/linagora/james-project/pull/5032 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1900: URL: https://github.com/apache/james-project/pull/1900#discussion_r1445754802 ## backends-common/postgres/src/test/java/org/apache/james/backends/postgres/PostgresExtension.java: ## @@ -114,23 +114,22 @@ private void

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1900: URL: https://github.com/apache/james-project/pull/1900#discussion_r1445804169 ## server/data/data-postgres/src/main/java/org/apache/james/mailrepository/postgres/PostgresMailRepositoryContentDAO.java: ## @@ -0,0 +1,356 @@

[PR] JAMES-3897 CrowdSec integration test for SMTP [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 opened a new pull request, #1908: URL: https://github.com/apache/james-project/pull/1908 resolve https://github.com/linagora/james-project/issues/5003 SMTP proxy support with CrowdSec should already be the case. -- This is an automated message from the Apache Git

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on PR #1900: URL: https://github.com/apache/james-project/pull/1900#issuecomment-1882878444 > > where is the document? > > sorry, I rechecked it again, now we haven't documented for it, just add a new property and comment in the sample configuration file

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1900: URL: https://github.com/apache/james-project/pull/1900#discussion_r1445808639 ## server/data/data-postgres/src/main/java/org/apache/james/mailrepository/postgres/PostgresMailRepositoryContentDAO.java: ## @@ -0,0 +1,356 @@

Re: [PR] JAMES-2586 - Set blobStorage implementation is postgres by default [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1905: URL: https://github.com/apache/james-project/pull/1905#discussion_r1445861864 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJamesConfiguration.java: ## @@ -42,9 +42,9 @@ public class

Re: [PR] JAMES-2586 - Set blobStorage implementation is postgres by default [james-project]

2024-01-09 Thread via GitHub
vttranlina commented on code in PR #1905: URL: https://github.com/apache/james-project/pull/1905#discussion_r1445879056 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJamesConfiguration.java: ## @@ -42,9 +42,9 @@ public class PostgresJamesConfiguration

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on PR #1900: URL: https://github.com/apache/james-project/pull/1900#issuecomment-1882842562 > CI fail > > ``` > shouldPreserveDsnParameters – org.apache.james.mailrepository.postgres.PostgresMailRepositoryTest > > javax.mail.internet.AddressException:

Re: [PR] JAMES-2586 - Set blobStorage implementation is postgres by default [james-project]

2024-01-09 Thread via GitHub
vttranlina commented on PR #1905: URL: https://github.com/apache/james-project/pull/1905#issuecomment-1882623170 > Sorry for being picky but the `FileBlobStoreDAO` was obviously suboptimal and not leveraging correctly data available to it. > > May you run one more time the bench with

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
vttranlina commented on PR #1900: URL: https://github.com/apache/james-project/pull/1900#issuecomment-1882817437 CI fail ``` shouldPreserveDsnParameters – org.apache.james.mailrepository.postgres.PostgresMailRepositoryTest javax.mail.internet.AddressException: Out of data at

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
vttranlina commented on code in PR #1900: URL: https://github.com/apache/james-project/pull/1900#discussion_r1445793965 ## server/data/data-postgres/src/main/java/org/apache/james/mailrepository/postgres/PostgresMailRepositoryContentDAO.java: ## @@ -0,0 +1,355 @@

Re: [PR] JAMES-2586 Implement BlobReferenceSource(s) for postgres-app [james-project]

2024-01-09 Thread via GitHub
vttranlina commented on PR #1900: URL: https://github.com/apache/james-project/pull/1900#issuecomment-1882847800 > where is the document? sorry, I rechecked it again, now we haven't documented for it, just add a new property and comment in the sample configuration file

Re: [PR] JAMES-3897 CrowdSec integration test for SMTP [james-project]

2024-01-09 Thread via GitHub
thanhbv200585 commented on PR #1908: URL: https://github.com/apache/james-project/pull/1908#issuecomment-1884092335 There is also integration test for IMAP as well, should we put it CrowdsecIntegrationTest with SMTP or separate them? -- This is an automated message from the Apache Git

Re: [PR] JAMES-3897 CrowdSec integration test for SMTP [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on PR #1908: URL: https://github.com/apache/james-project/pull/1908#issuecomment-1884094619 > There is also integration test for IMAP as well, should we put it CrowdsecIntegrationTest with SMTP or separate them? The ticket name says it all. -- This is an

Re: [PR] JAMES-3897 CrowdSec integration test for SMTP [james-project]

2024-01-09 Thread via GitHub
thanhbv200585 commented on PR #1908: URL: https://github.com/apache/james-project/pull/1908#issuecomment-1884102910 Read it. Look good to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] JAMES-3897 CrowdSec integration test for SMTP [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on PR #1908: URL: https://github.com/apache/james-project/pull/1908#issuecomment-1884120336 > Just remove the third-party/crowdsec/src/test/resources/log/james.log empty file and we are good :) That empty file was intended. During tests, it is used to store

[PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 opened a new pull request, #1909: URL: https://github.com/apache/james-project/pull/1909 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on PR #1909: URL: https://github.com/apache/james-project/pull/1909#issuecomment-1884148268 the PostgresJmapModule contains things that I have to copy from MemoryMailboxModule and MemoryDataModule to make PostgresJamesServerTest pass Currently the only webamdin

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446853591 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446858067 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446857572 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446861437 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446861750 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
hungphan227 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446861750 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446864513 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Webadmin integration tests for postgres [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on code in PR #1909: URL: https://github.com/apache/james-project/pull/1909#discussion_r1446865684 ## server/apps/postgres-app/src/main/java/org/apache/james/PostgresJmapModule.java: ## @@ -0,0 +1,79 @@

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-09 Thread via GitHub
quantranhong1999 commented on PR #1891: URL: https://github.com/apache/james-project/pull/1891#issuecomment-1884166806 @Arsnael Can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to