[GitHub] [james-project] chibenwa commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

chibenwa commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295403024 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaLimitDao.java: ## @@ -0,0 +1,209 @@

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295402594 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] chibenwa commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

chibenwa commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295402581 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaCurrentValueDao.java: ## @@ -0,0 +1,192 @@

[GitHub] [james-project] chibenwa commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

chibenwa commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295401819 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaCurrentValueDao.java: ## @@ -0,0 +1,192 @@

[GitHub] [james-project] chibenwa commented on pull request #1674: JAMES-3927 Improve mailbox subscription management for JMAP

chibenwa commented on PR #1674: URL: https://github.com/apache/james-project/pull/1674#issuecomment-1679991718 With pleasure! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[james-project] branch master updated (2b16647fd3 -> 00849bd72f)

This is an automated email from the ASF dual-hosted git repository. btellier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git from 2b16647fd3 Exclude old JMS spec from dependencies to fix NoSuchMethodError when sending a message via SMTP

[GitHub] [james-project] chibenwa merged pull request #1674: JAMES-3927 Improve mailbox subscription management for JMAP

chibenwa merged PR #1674: URL: https://github.com/apache/james-project/pull/1674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] chibenwa commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

chibenwa commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1295396341 ## core/src/main/java/org/apache/james/core/quota/QuotaComponent.java: ## @@ -0,0 +1,70 @@ +/ +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

chibenwa commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1295395667 ## core/src/main/java/org/apache/james/core/quota/QuotaComponent.java: ## @@ -0,0 +1,70 @@ +/ +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1671: JAMES-3693 RedisHealthCheck

chibenwa commented on code in PR #1671: URL: https://github.com/apache/james-project/pull/1671#discussion_r1295394799 ## server/mailet/rate-limiter-redis/src/main/scala/org/apache/james/rate/limiter/redis/RedisHealthCheck.scala: ## @@ -20,33 +20,43 @@ package

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295392847 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295389512 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295380244 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1295377805 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] quantranhong1999 commented on pull request #1674: JAMES-3927 Improve mailbox subscription management for JMAP

quantranhong1999 commented on PR #1674: URL: https://github.com/apache/james-project/pull/1674#issuecomment-1679871948 > Green build, can you squash? I think squash upon Github merge is ok. -- This is an automated message from the Apache Git Service. To respond to the message,

[james-project] branch master updated (b990ccdfe9 -> 2b16647fd3)

This is an automated email from the ASF dual-hosted git repository. rcordier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git from b990ccdfe9 [FIX] Some S3 like object storage, like MinIO, don't accept underscores in their bucket names

[GitHub] [james-project] Arsnael merged pull request #1668: Exclude old JMS spec from dependencies

Arsnael merged PR #1668: URL: https://github.com/apache/james-project/pull/1668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] Arsnael commented on pull request #1674: JAMES-3927 Improve mailbox subscription management for JMAP

Arsnael commented on PR #1674: URL: https://github.com/apache/james-project/pull/1674#issuecomment-1679865809 Green build, can you squash? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [james-project] Arsnael commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

Arsnael commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294418962 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] Arsnael commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

Arsnael commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1294402151 ## core/src/main/java/org/apache/james/core/quota/QuotaCurrentValue.java: ## @@ -0,0 +1,124 @@ +/

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294396353 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

hungphan227 commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1294390742 ## core/src/main/java/org/apache/james/core/quota/QuotaCurrentValue.java: ## @@ -0,0 +1,124 @@

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294386375 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294385161 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaLimitDao.java: ## @@ -0,0 +1,145 @@

[GitHub] [james-project] Arsnael commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

Arsnael commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1294384775 ## core/src/main/java/org/apache/james/core/quota/QuotaCurrentValue.java: ## @@ -0,0 +1,124 @@ +/

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294377864 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaLimitDao.java: ## @@ -0,0 +1,145 @@

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294376099 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaLimitDao.java: ## @@ -0,0 +1,145 @@

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294370522 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraQuotaModule.java: ## @@ -68,5 +70,26 @@ public interface

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

quantranhong1999 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1294260475 ## mailbox/cassandra/src/test/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaLimitDaoTest.java: ## @@ -0,0 +1,94 @@

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

hungphan227 commented on code in PR #1670: URL: https://github.com/apache/james-project/pull/1670#discussion_r1294278686 ## core/src/main/java/org/apache/james/core/quota/QuotaCurrentValue.java: ## @@ -0,0 +1,124 @@

[GitHub] [james-project] Arsnael opened a new pull request, #1679: [BUILD] Increase timeout of Cassandra Docker container wait strategy …

Arsnael opened a new pull request, #1679: URL: https://github.com/apache/james-project/pull/1679 …to 3 minutes 5 minutes seemed too much previously and created issues on test execution times, blocking potentially threads used by maven-surefire-plugin when testing in parallel.