[GitHub] [james-project] chibenwa commented on a diff in pull request #1688: ADR-67 Quota for JMAP uploads

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1688: URL: https://github.com/apache/james-project/pull/1688#discussion_r1298016740 ## src/adr/0067-quota-for-jmap-uploads.md: ## @@ -0,0 +1,90 @@ +# 67. Quota for JMAP uploads + +Date: 2023-08-17 + +## Status + +Accepted (lazy consensus). +

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297990131 ## server/apps/distributed-app/docker-compose.yml: ## @@ -54,13 +44,9 @@ services: networks: - james - tika: -image:

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1688: ADR-67 Quota for JMAP uploads

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1688: URL: https://github.com/apache/james-project/pull/1688#discussion_r1297950130 ## src/adr/0067-quota-for-jmap-uploads.md: ## @@ -0,0 +1,90 @@ +# 67. Quota for JMAP uploads + +Date: 2023-08-17 + +## Status + +Accepted (lazy

[GitHub] [james-project] Arsnael commented on a diff in pull request #1688: ADR-67 Quota for JMAP uploads

2023-08-17 Thread via GitHub
Arsnael commented on code in PR #1688: URL: https://github.com/apache/james-project/pull/1688#discussion_r1297930188 ## src/adr/0067-quota-for-jmap-uploads.md: ## @@ -0,0 +1,90 @@ +# 67. Quota for JMAP uploads + +Date: 2023-08-17 + +## Status + +Accepted (lazy consensus). +

[GitHub] [james-project] vttranlina commented on pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
vttranlina commented on PR #1651: URL: https://github.com/apache/james-project/pull/1651#issuecomment-1683260423 if you "force push" all commit, can you squash fixup commit to easier follow?

[GitHub] [james-project] vttranlina closed pull request #1683: [NO_REVIEW] [DO_NOT_MERGE] test jenkin ci

2023-08-17 Thread via GitHub
vttranlina closed pull request #1683: [NO_REVIEW] [DO_NOT_MERGE] test jenkin ci URL: https://github.com/apache/james-project/pull/1683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [james-project] vttranlina commented on pull request #1683: [NO_REVIEW] [DO_NOT_MERGE] test jenkin ci

2023-08-17 Thread via GitHub
vttranlina commented on PR #1683: URL: https://github.com/apache/james-project/pull/1683#issuecomment-1683242258 The single thread when mvn test was not fix the unstable of ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [james-project] vttranlina opened a new pull request, #1689: Fix jvm-*.options when upgrade Docker Cassandra 3 -> 4...

2023-08-17 Thread via GitHub
vttranlina opened a new pull request, #1689: URL: https://github.com/apache/james-project/pull/1689 Time to start up the Cassandra container on my pc Before: 67 seconds After: 13 seconds -- This is an automated message from the Apache Git Service. To respond to the message,

[james-project] branch master updated: [BUILD] Changing OpenSearch waiting strategy (#1681)

2023-08-17 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new be816d0779 [BUILD] Changing OpenSearch

[GitHub] [james-project] chibenwa merged pull request #1681: [BUILD] Changing OpenSearch waiting strategy

2023-08-17 Thread via GitHub
chibenwa merged PR #1681: URL: https://github.com/apache/james-project/pull/1681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[james-site] branch asf-staging updated: Site checkin for project Apache James: Jenkins Tools

2023-08-17 Thread git-site-role
This is an automated email from the ASF dual-hosted git repository. git-site-role pushed a commit to branch asf-staging in repository https://gitbox.apache.org/repos/asf/james-site.git The following commit(s) were added to refs/heads/asf-staging by this push: new a4cfe25df Site checkin for

[GitHub] [james-project] chibenwa opened a new pull request, #1688: ADR-67 Quota for JMAP uploads

2023-08-17 Thread via GitHub
chibenwa opened a new pull request, #1688: URL: https://github.com/apache/james-project/pull/1688 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] chibenwa commented on pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads

2023-08-17 Thread via GitHub
chibenwa commented on PR #1686: URL: https://github.com/apache/james-project/pull/1686#issuecomment-1682246164 Ticket number in PR titl and from commits is taken from the ASF JIRA, NOT from github issues. MUST BE [JAMES-3925](https://issues.apache.org/jira/browse/JAMES-3925) --

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297149300 ## server/apps/distributed-app/docker-compose-with-pulsar.yml: ## @@ -0,0 +1,97 @@ +version: '3' + +services: + + james: +depends_on: +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1686: URL: https://github.com/apache/james-project/pull/1686#discussion_r1297125878 ## server/protocols/webadmin/webadmin-mailbox/src/main/java/org/apache/james/webadmin/routes/QuotaRoutes.java: ## @@ -0,0 +1,130 @@

[GitHub] [james-project] chibenwa commented on a diff in pull request #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1686: URL: https://github.com/apache/james-project/pull/1686#discussion_r1297125326 ## server/container/guice/protocols/webadmin-mailbox/src/main/java/org/apache/james/modules/server/MailboxRoutesModule.java: ## @@ -53,6 +54,7 @@ protected void

[GitHub] [james-project] chibenwa commented on a diff in pull request #1685: [BUILD] Fix unstable SpamTrapHandlerTest.testSpamTrap test

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1685: URL: https://github.com/apache/james-project/pull/1685#discussion_r1297123859 ## protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java: ## @@ -54,8 +56,14 @@ public class SpamTrapHandler

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1297123183 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1687: Improve the rule for checkstyle

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1687: URL: https://github.com/apache/james-project/pull/1687#discussion_r1297120432 ## checkstyle.xml: ## @@ -30,6 +30,15 @@ + + + + + + + + Review Comment: No message here? -- This is an automated

[GitHub] [james-project] vttranlina opened a new pull request, #1687: Improve the rule for checkstyle

2023-08-17 Thread via GitHub
vttranlina opened a new pull request, #1687: URL: https://github.com/apache/james-project/pull/1687 - Check the license in the header - Found debug code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297064449 ## server/apps/distributed-app/docker-compose-with-pulsar.yml: ## @@ -0,0 +1,97 @@ +version: '3' + +services: + + james: +depends_on: +

[GitHub] [james-project] vttranlina commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
vttranlina commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297062061 ## server/apps/distributed-app/docker-compose-with-pulsar.yml: ## @@ -0,0 +1,97 @@ +version: '3' + +services: + + james: +depends_on: + cassandra: +

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297023616 ## server/apps/distributed-app/docker-compose-with-pulsar.yml: ## @@ -0,0 +1,97 @@ +version: '3' + +services: + + james: +depends_on: +

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297030139 ##

[GitHub] [james-project] Arsnael commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
Arsnael commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1297026026 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297017832 ##

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297013368 ## server/apps/distributed-app/sample-configuration/jmap.properties: ## @@ -6,6 +6,8 @@ enabled=true tls.keystoreURL=file://conf/keystore

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297011960 ## server/apps/distributed-app/sample-configuration/queue.properties: ## @@ -0,0 +1 @@ +queue.choice=PULSAR Review Comment: Ok, I"ll do it -- This

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297010704 ## server/apps/distributed-app/src/main/java/org/apache/james/CassandraRabbitMQJamesServerMain.java: ## @@ -205,6 +207,20 @@ public static GuiceJamesServer

[GitHub] [james-project] quantranhong1999 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
quantranhong1999 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297010329 ## server/apps/distributed-app/sample-configuration/queue.properties: ## @@ -0,0 +1 @@ +queue.choice=PULSAR Review Comment: Can you try to add that

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1297008501 ## server/apps/distributed-app/sample-configuration/queue.properties: ## @@ -0,0 +1 @@ +queue.choice=PULSAR Review Comment: No, we haven't had any

[GitHub] [james-project] hungphan227 opened a new pull request, #1686: DRAFT JAMES-4839 jmap quota for uploads implement a web admin api to update limit of uploads

2023-08-17 Thread via GitHub
hungphan227 opened a new pull request, #1686: URL: https://github.com/apache/james-project/pull/1686 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] hungphan227 commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-17 Thread via GitHub
hungphan227 commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1296990007 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaCurrentValueDao.java: ## @@ -0,0 +1,192 @@

[GitHub] [james-project] chibenwa commented on a diff in pull request #1685: [BUILD] Fix unstable SpamTrapHandlerTest.testSpamTrap test

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1685: URL: https://github.com/apache/james-project/pull/1685#discussion_r1296985185 ## protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java: ## @@ -42,13 +45,20 @@ public class SpamTrapHandler

[GitHub] [james-project] thanhbv200585 commented on a diff in pull request #1651: Package of Pulsar using docker-compose

2023-08-17 Thread via GitHub
thanhbv200585 commented on code in PR #1651: URL: https://github.com/apache/james-project/pull/1651#discussion_r1296986305 ##

[GitHub] [james-project] chibenwa commented on a diff in pull request #1685: [BUILD] Fix unstable SpamTrapHandlerTest.testSpamTrap test

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1685: URL: https://github.com/apache/james-project/pull/1685#discussion_r1296983855 ## protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/fastfail/SpamTrapHandler.java: ## @@ -42,13 +45,20 @@ public class SpamTrapHandler

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296976932 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296976932 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] quantranhong1999 opened a new pull request, #1685: [BUILD] Fix unstable SpamTrapHandlerTest.testSpamTrap test

2023-08-17 Thread via GitHub
quantranhong1999 opened a new pull request, #1685: URL: https://github.com/apache/james-project/pull/1685 resolve https://github.com/linagora/james-project/issues/4844 Rely on UpdatableTickingClock to avoid CPU resource race condition on the CI that leads to test unstable. --

[GitHub] [james-project] Arsnael commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
Arsnael commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296940048 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1673: URL: https://github.com/apache/james-project/pull/1673#discussion_r1296933039 ## mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/quota/CassandraQuotaCurrentValueDao.java: ## @@ -0,0 +1,192 @@

[GitHub] [james-project] chibenwa opened a new pull request, #1684: Various small enhancements for PropagateLookupRightListener

2023-08-17 Thread via GitHub
chibenwa opened a new pull request, #1684: URL: https://github.com/apache/james-project/pull/1684 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [james-project] Arsnael commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
Arsnael commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296827375 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296824874 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296822382 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] Arsnael commented on pull request #1673: JAMES-4840 refactor quota for cassandra: create cassandra DAOs

2023-08-17 Thread via GitHub
Arsnael commented on PR #1673: URL: https://github.com/apache/james-project/pull/1673#issuecomment-1681759228 Please rebase :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[james-project] branch master updated: JAMES-4824 Refactor quota for Cassandra: create POJOs (#1670)

2023-08-17 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new b17d3636f4 JAMES-4824 Refactor quota

[GitHub] [james-project] Arsnael merged pull request #1670: JAMES-4824 Refactor quota for Cassandra: create POJOs

2023-08-17 Thread via GitHub
Arsnael merged PR #1670: URL: https://github.com/apache/james-project/pull/1670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [james-project] Arsnael commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
Arsnael commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296760431 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1648: JAMES-3929 Upgrade to opensearch-java 2.6.0

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1648: URL: https://github.com/apache/james-project/pull/1648#discussion_r1296722296 ## backends-common/opensearch/pom.xml: ## @@ -71,6 +71,18 @@ org.apache.commons commons-configuration2 + + +

[GitHub] [james-project] chibenwa commented on a diff in pull request #1682: JAMES-3934 Allow external scheduling for RabbitMQ mailQueue browse st…

2023-08-17 Thread via GitHub
chibenwa commented on code in PR #1682: URL: https://github.com/apache/james-project/pull/1682#discussion_r1296716761 ##