Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
Arsnael commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440161536 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
Arsnael commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440161536 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440141258 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440141258 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440141258 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

(james-project) branch 3.8.x updated: [FIX] JMX password auto-detection

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/3.8.x by this push: new 7c4729f821 [FIX] JMX password

Re: [PR] [FIX] JMX password auto-detection [james-project]

2024-01-02 Thread via GitHub
Arsnael merged PR #1893: URL: https://github.com/apache/james-project/pull/1893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
Arsnael closed pull request #1882: JAMES-2586 Implement PostgresBlobStoreDAO URL: https://github.com/apache/james-project/pull/1882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] JAMES-2586 Introduce Pool PostgreExecutor [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1440137071 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolPostgresExecutor.java: ## @@ -0,0 +1,152 @@

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1882: URL: https://github.com/apache/james-project/pull/1882#issuecomment-1874939116 > I want you @vttranlina to create a ticket on connection pooling first ;-) yes, ticket for it https://github.com/linagora/james-project/issues/5020 -- This is an

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1884: URL: https://github.com/apache/james-project/pull/1884#discussion_r1440132601 ## server/container/guice/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreConfiguration.java: ## @@ -108,7 +112,8 @@ public static

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on PR #1882: URL: https://github.com/apache/james-project/pull/1882#issuecomment-1874932324 I want you @vttranlina to create a ticket on connection pooling first ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1883: URL: https://github.com/apache/james-project/pull/1883#issuecomment-1874925871 Rebase master & squash fixup for easier follow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1882: URL: https://github.com/apache/james-project/pull/1882#issuecomment-1874919505 we can close it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1884: URL: https://github.com/apache/james-project/pull/1884#issuecomment-1874918340 rebase master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] JAMES-2586 Implement only PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa merged PR #1895: URL: https://github.com/apache/james-project/pull/1895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(james-project) 02/02: JAMES-2586 Disable concurrent test of PostgresBlobStoreDAO

2024-01-02 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit 42ccbca1b8f9b68d2a38137ece3934e511253483 Author: Tung Tran AuthorDate: Wed Jan 3 08:33:15 2024 +0700

(james-project) branch postgresql updated (8a85f704f2 -> 42ccbca1b8)

2024-01-02 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a change to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git from 8a85f704f2 JAMES-3817 Only perform JMAP event bus dead letter health check if JMAP is used new

(james-project) 01/02: JAMES-2586 Implement PostgresBlobStoreDAO

2024-01-02 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit 5c125e46e26553580a96ccac075b8cb2c689ce64 Author: hung phan AuthorDate: Tue Dec 26 20:51:07 2023 +0700

(james-project) branch 3.7.x updated: [FIX] JMX password auto-detection (#1894)

2024-01-02 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch 3.7.x in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/3.7.x by this push: new ec277b6b87 [FIX] JMX password

Re: [PR] [FIX] JMX password auto-detection [james-project]

2024-01-02 Thread via GitHub
chibenwa merged PR #1894: URL: https://github.com/apache/james-project/pull/1894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1440108293 ## mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxMessageDAO.java: ## @@ -110,7 +112,7 @@ private static

Re: [PR] JAMES 3897: CrowdsecImapConnectionCheck [james-project]

2024-01-02 Thread via GitHub
Arsnael commented on code in PR #1824: URL: https://github.com/apache/james-project/pull/1824#discussion_r1440030589 ## third-party/crowdsec/src/test/java/org/apache/james/CrowdsecIntegrationTest.java: ## @@ -0,0 +1,91 @@

(james-project) branch postgresql updated (42cb00e2b3 -> 8a85f704f2)

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a change to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git from 42cb00e2b3 JAMES-2586 Add missing license new 0ea2767f7c JAMES-2586 Add a health check integration

(james-project) 01/02: JAMES-2586 Add a health check integration test

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit 0ea2767f7c12f3ea444eff9588bee5e0e701cfe6 Author: Quan Tran AuthorDate: Thu Dec 28 14:03:50 2023 +0700

(james-project) 02/02: JAMES-3817 Only perform JMAP event bus dead letter health check if JMAP is used

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch postgresql in repository https://gitbox.apache.org/repos/asf/james-project.git commit 8a85f704f2aa2bc138ecc9218aeb001dca034408 Author: Quan Tran AuthorDate: Thu Dec 28 14:09:09 2023 +0700

Re: [PR] JAMES-2586 Add health check integration test for postgres distributed app [james-project]

2024-01-02 Thread via GitHub
Arsnael merged PR #1885: URL: https://github.com/apache/james-project/pull/1885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(james-project) 01/02: JAMES-3817 Only perform JMAP event bus dead letter health check if JMAP is used

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit 9e1fa03a17f13171decdc89f29785d58f9b30353 Author: Quan Tran AuthorDate: Thu Dec 28 14:09:09 2023 +0700

(james-project) 02/02: [PERF] Only bind JMAPEventBusModule when JMAP is enabled

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit e89f35a5033d6a2689bf0b42d8524953cc28992e Author: Quan Tran AuthorDate: Thu Dec 28 15:03:48 2023 +0700

(james-project) branch master updated (3cf42e9630 -> e89f35a503)

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git from 3cf42e9630 [ENHANCEMENT] DataLineJamesMessageHookHandler: method extraction new 9e1fa03a17 JAMES-3817

Re: [PR] JAMES-3817 Only perform JMAP event bus dead letter health check if JMAP is used [james-project]

2024-01-02 Thread via GitHub
Arsnael merged PR #1886: URL: https://github.com/apache/james-project/pull/1886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
hungphan227 commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1440025101 ## mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxMessageDAO.java: ## @@ -110,7 +112,7 @@ private static

(james-project) 02/03: [FIX] Ignore commands after closed connection

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git commit 9d5e36947333cf468e3842bab99732926fea545e Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:52:59 2024 +0100

(james-project) 01/03: [FIX] Close connection after DATA errors

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git commit 95811d5b02937e9b395634ad01e6d4f8dd406fe7 Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:52:38 2024 +0100

(james-project) 03/03: [ENHANCEMENT] DataLineJamesMessageHookHandler: method extraction

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git commit 9288fbc7179bbb5ba8ade2c567920d0a92aabac8 Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:54:44 2024 +0100

(james-project) branch 3.8.x updated (d5cd8bb098 -> 9288fbc717)

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a change to branch 3.8.x in repository https://gitbox.apache.org/repos/asf/james-project.git from d5cd8bb098 [FIX] Enforce CRLF as part of SMTP DATA transaction (#1877) new 95811d5b02 [FIX] Close

Re: [PR] [FIX] Close connection after DATA errors [james-project]

2024-01-02 Thread via GitHub
Arsnael merged PR #1889: URL: https://github.com/apache/james-project/pull/1889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(james-project) branch master updated (a254af3458 -> 3cf42e9630)

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git from a254af3458 [FIX] Enforce CRLF as part of SMTP DATA transaction (#1876) new 30ad5e1704 [FIX] Close

(james-project) 03/03: [ENHANCEMENT] DataLineJamesMessageHookHandler: method extraction

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit 3cf42e9630b08cb1f91e34c4aacc10f624524c38 Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:54:44 2024 +0100

(james-project) 02/03: [FIX] Ignore commands after closed connection

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit dfbd3b2aefb76aa4d2f1c5d45f7aa73f4547356c Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:52:59 2024 +0100

(james-project) 01/03: [FIX] Close connection after DATA errors

2024-01-02 Thread rcordier
This is an automated email from the ASF dual-hosted git repository. rcordier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git commit 30ad5e17047bd1fdfc01dd29630b0e257e2c8e3a Author: Benoit TELLIER AuthorDate: Tue Jan 2 09:52:38 2024 +0100

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1440011934 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolPostgresExecutor.java: ## @@ -0,0 +1,152 @@

Re: [PR] [FIX] Close connection after DATA errors [james-project]

2024-01-02 Thread via GitHub
Arsnael merged PR #1890: URL: https://github.com/apache/james-project/pull/1890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] JAMES-2586 Implement only PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina opened a new pull request, #1895: URL: https://github.com/apache/james-project/pull/1895 The smaller split of https://github.com/apache/james-project/pull/1883 It only the implementation of `PostgresBlobStoreDAO` without PoolPostgresExecutor -- This is an automated

Re: [PR] JAMES 3897: CrowdsecImapConnectionCheck [james-project]

2024-01-02 Thread via GitHub
thanhbv200585 commented on code in PR #1824: URL: https://github.com/apache/james-project/pull/1824#discussion_r1439994965 ## third-party/crowdsec/src/test/java/org/apache/james/CrowdsecIntegrationTest.java: ## @@ -0,0 +1,91 @@

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on PR #1891: URL: https://github.com/apache/james-project/pull/1891#issuecomment-1874086347 > Maybe we can modify SinglePostgresConnectionFactory to be backed by the pool connection (and rename it) That would be enough to me. No need of an extra integration test

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439492028 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolPostgresExecutor.java: ## @@ -0,0 +1,152 @@

[PR] [FIX] JMX password auto-detection [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1894: URL: https://github.com/apache/james-project/pull/1894 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FIX] JMX password auto-detection [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1893: URL: https://github.com/apache/james-project/pull/1893 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FIX] JMX password auto-detection [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1892: URL: https://github.com/apache/james-project/pull/1892 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439388037 ## mailbox/postgres/src/main/java/org/apache/james/mailbox/postgres/mail/dao/PostgresMailboxMessageDAO.java: ## @@ -110,7 +112,7 @@ private static

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439385236 ## backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolPostgresExecutor.java: ## @@ -0,0 +1,152 @@

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 commented on PR #1891: URL: https://github.com/apache/james-project/pull/1891#issuecomment-1873912482 > I am missing a test... I thought about it as integration test `DeletedMessageVaultIntegrationTest` as part of the

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 commented on code in PR #1891: URL: https://github.com/apache/james-project/pull/1891#discussion_r1439364534 ## mailbox/plugin/deleted-messages-vault-postgres/src/main/java/org/apache/james/vault/metadata/PostgresDeletedMessageMetadataModule.java: ## @@ -0,0

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439351488 ## server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java: ## @@ -41,7 +41,7 @@ public class

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439351488 ## server/data/data-postgres/src/main/java/org/apache/james/domainlist/postgres/PostgresDomainList.java: ## @@ -41,7 +41,7 @@ public class

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1891: URL: https://github.com/apache/james-project/pull/1891#discussion_r1439350057 ## mailbox/plugin/deleted-messages-vault-postgres/src/main/java/org/apache/james/vault/metadata/PostgresDeletedMessageMetadataVault.java: ## @@ -0,0 +1,115 @@

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1891: URL: https://github.com/apache/james-project/pull/1891#discussion_r1439344153 ## mailbox/plugin/deleted-messages-vault-postgres/src/main/java/org/apache/james/vault/metadata/PostgresDeletedMessageMetadataModule.java: ## @@ -0,0 +1,56 @@

Re: [PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1891: URL: https://github.com/apache/james-project/pull/1891#discussion_r1439344153 ## mailbox/plugin/deleted-messages-vault-postgres/src/main/java/org/apache/james/vault/metadata/PostgresDeletedMessageMetadataModule.java: ## @@ -0,0 +1,56 @@

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439339572 ## server/apps/postgres-app/sample-configuration/postgres.properties: ## @@ -10,13 +10,18 @@ database.schema=public # Boolean. Optional, default to false.

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439323994 ## server/apps/postgres-app/sample-configuration/postgres.properties: ## @@ -10,13 +10,18 @@ database.schema=public # Boolean. Optional, default to

[PR] JAMES-2586 Implement Deleted Message Vault backed by Postgres [james-project]

2024-01-02 Thread via GitHub
quantranhong1999 opened a new pull request, #1891: URL: https://github.com/apache/james-project/pull/1891 resolve https://github.com/linagora/james-project/issues/5000 TODO: plug `DeletedMessageVaultDeletionCallback`. -- This is an automated message from the Apache Git Service. To

Re: [PR] JAMES-2586 [PGSQL] Guice binding Postgres BlobStore & Adapt to BlobStoreModulesChooser [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1884: URL: https://github.com/apache/james-project/pull/1884#issuecomment-1873824687 The task for benchmark and set default: https://github.com/linagora/james-project/issues/5006 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439278665 ## backends-common/postgres/src/test/java/org/apache/james/backends/postgres/PostgresExecutorThreadSafetyTest.java: ## @@ -51,7 +51,7 @@ class

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439274659 ## backends-common/postgres/src/test/java/org/apache/james/backends/postgres/PostgresExecutorThreadSafetyTest.java: ## @@ -51,7 +51,7 @@ class

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on code in PR #1883: URL: https://github.com/apache/james-project/pull/1883#discussion_r1439269988 ## backends-common/postgres/src/test/java/org/apache/james/backends/postgres/PostgresExecutorThreadSafetyTest.java: ## @@ -51,7 +51,7 @@ class

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1883: URL: https://github.com/apache/james-project/pull/1883#issuecomment-1873772980 > Let's go for the pool implementation now, but all pool settings shall be configurable into `postgres.properties` : > > * TTL > * Max size > * Min size > *

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
chibenwa commented on PR #1883: URL: https://github.com/apache/james-project/pull/1883#issuecomment-1873769727 Let's go for the pool implementation now, but all pool settings shall be configurable into `postgres.properties` : - TTL - Max size - Min size - Etc... --

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1883: URL: https://github.com/apache/james-project/pull/1883#issuecomment-1873768086 I will change the pool size from 50->2, and re-test again Then see the slowing come from the pool or another where -- This is an automated message from the Apache Git

Re: [PR] JAMES-2586 Implement PostgresBlobStoreDAO [james-project]

2024-01-02 Thread via GitHub
vttranlina commented on PR #1883: URL: https://github.com/apache/james-project/pull/1883#issuecomment-1873763223 ## Bench test Pool vs No pool ![image](https://github.com/apache/james-project/assets/81145350/d6406cb7-a60c-4a22-8c79-8e7722773178) // For easier get

[PR] [FIX] Close connection after DATA errors [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1890: URL: https://github.com/apache/james-project/pull/1890 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FIX] Close connection after DATA errors [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1889: URL: https://github.com/apache/james-project/pull/1889 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FIX] Close connection after DATA errors [james-project]

2024-01-02 Thread via GitHub
chibenwa opened a new pull request, #1888: URL: https://github.com/apache/james-project/pull/1888 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To