quantranhong1999 commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2024377812
> I would however agree that it is done in a follow up PR.
I pushed the tests in this PR by the way.
--
This is an automated message from the Apache Git Service.
Arsnael commented on PR #2161:
URL: https://github.com/apache/james-project/pull/2161#issuecomment-2024374849
Squash of the fixup needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Arsnael commented on PR #2162:
URL: https://github.com/apache/james-project/pull/2162#issuecomment-2024373271
Why duplicating and not moving them making it generic to implems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vttranlina commented on PR #2162:
URL: https://github.com/apache/james-project/pull/2162#issuecomment-2024325483
> You duplicated the quota dto related classes to quota-mailing module, you
didnt move them :)
updated the commit message
--
This is an automated message from the
quantranhong1999 commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2024299553
> I would however agree that it is done in a follow up PR.
Ticket: https://github.com/linagora/james-project/issues/5146
--
This is an automated message from the
This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
The following commit(s) were added to refs/heads/master by this push:
new 1bc01eb36e [FIX] IMAP STATUS should
Arsnael merged PR #2158:
URL: https://github.com/apache/james-project/pull/2158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Arsnael commented on PR #2162:
URL: https://github.com/apache/james-project/pull/2162#issuecomment-2024280278
You duplicated the quota dto related classes to quota-mailing module, you
didnt move them :)
--
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a change to branch dtm-workqueue
in repository https://gitbox.apache.org/repos/asf/james-project.git
from a32eb317f4 [ENHANCEMENT] Workqueue for the deleted message vault
add 4df78e56e4 fixup!
chibenwa commented on code in PR #2158:
URL: https://github.com/apache/james-project/pull/2158#discussion_r1541948946
##
protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java:
##
@@ -104,8 +104,8 @@ protected Mono processRequestReactive(StatusRequest
chibenwa commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2023854227
> Can we skip test for this?
There's a high value added for such a test to be honnest.
I would however agree that it is done in a follow up PR.
--
This is an
chibenwa commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2023850708
> FYI there is no test setup for JamesMailSpooler yet.
You do not know me well, then...
CF `MailetErrorsTest`
But only the memory implementation is exercised.
vttranlina opened a new pull request, #2162:
URL: https://github.com/apache/james-project/pull/2162
resolve https://github.com/linagora/james-project/issues/5144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
quantranhong1999 commented on code in PR #2158:
URL: https://github.com/apache/james-project/pull/2158#discussion_r1540853454
##
protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java:
##
@@ -104,8 +104,8 @@ protected Mono
quantranhong1999 commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2022433563
Can we skip test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
quantranhong1999 commented on PR #2159:
URL: https://github.com/apache/james-project/pull/2159#issuecomment-2022371704
> Please have a test for this?
How is the test that you want? Write a unit test using a `JamesMailSpooler`
that halts a mock `java.lang.NoSuchMethodError` during
chibenwa opened a new pull request, #2161:
URL: https://github.com/apache/james-project/pull/2161
This was not preserved for the Cassandra mailbox, leading to innacurrate
backpressure and down the line to OutOfMemoryExceptions
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
The following commit(s) were added to refs/heads/master by this push:
new 8f93b7ba42 [DOC] Update import layout
Arsnael merged PR #2160:
URL: https://github.com/apache/james-project/pull/2160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
19 matches
Mail list logo