Re: [PR] POC Make all queues on Rabbitmq quorum queue when quorum option is en… [james-project]

2024-04-07 Thread via GitHub
quantranhong1999 commented on code in PR #2065: URL: https://github.com/apache/james-project/pull/2065#discussion_r1555219520 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationHandler.java: ## @@ -128,7 +128,7 @@ private void declareQueue(Sender

Re: [PR] POC Make all queues on Rabbitmq quorum queue when quorum option is en… [james-project]

2024-04-07 Thread via GitHub
quantranhong1999 commented on code in PR #2065: URL: https://github.com/apache/james-project/pull/2065#discussion_r1555214281 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationHandler.java: ## @@ -128,7 +128,7 @@ private void declareQueue(Sender

Re: [PR] POC Make all queues on Rabbitmq quorum queue when quorum option is en… [james-project]

2024-04-07 Thread via GitHub
quantranhong1999 commented on code in PR #2065: URL: https://github.com/apache/james-project/pull/2065#discussion_r1555201412 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationHandler.java: ## @@ -128,7 +128,7 @@ private void declareQueue(Sender

Re: [PR] Added ingressClassName support and adminIngress for k8s [james-project]

2024-04-07 Thread via GitHub
baikjy0215 commented on PR #2188: URL: https://github.com/apache/james-project/pull/2188#issuecomment-2041819851 Sorry, I added separate commit that adds support for adminIngress. Although it is not related to ingressClassName, it is useful for the operator as the Admin and Jamp Ingress

Re: [PR] POC Make all queues on Rabbitmq quorum queue when quorum option is en… [james-project]

2024-04-07 Thread via GitHub
quantranhong1999 commented on code in PR #2065: URL: https://github.com/apache/james-project/pull/2065#discussion_r1555194095 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationHandler.java: ## @@ -128,7 +128,7 @@ private void declareQueue(Sender

Re: [PR] JAMES-4025 Drop JMAP draft [james-project]

2024-04-07 Thread via GitHub
vttranlina commented on PR #2187: URL: https://github.com/apache/james-project/pull/2187#issuecomment-2041771241 A lot of Webadmin integration tests use Jmap Draft for testing We need to rewrite it to jmap rfc -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [FIX] JWT should not attempt to unzip data by default [james-project]

2024-04-07 Thread via GitHub
quantranhong1999 commented on PR #2189: URL: https://github.com/apache/james-project/pull/2189#issuecomment-2041756088 Nothing to add -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
baikjy0215 commented on PR #2188: URL: https://github.com/apache/james-project/pull/2188#issuecomment-2041619242 Sure, it would be better to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FIX] JWT should not attempt to unzip data by default [james-project]

2024-04-07 Thread via GitHub
ottoka commented on code in PR #2189: URL: https://github.com/apache/james-project/pull/2189#discussion_r1555083407 ## server/protocols/jwt/src/main/java/org/apache/james/jwt/JwtTokenVerifier.java: ## @@ -25,16 +25,36 @@ import org.slf4j.Logger; import

Re: [PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
chibenwa commented on PR #2188: URL: https://github.com/apache/james-project/pull/2188#issuecomment-2041501887 Shall we remove ``` kubernetes.io/ingress.class: nginx ``` By default? -- This is an automated message from the Apache Git Service. To respond to the

[PR] [FIX] JWT should not attempt to unzip data by default [james-project]

2024-04-07 Thread via GitHub
chibenwa opened a new pull request, #2189: URL: https://github.com/apache/james-project/pull/2189 jjwt support zip by default yet uncompression of untrusted data can result in excessive memory/cpu usage for special crafted malicious payload. -- This is an automated message from the

[PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
baikjy0215 opened a new pull request, #2188: URL: https://github.com/apache/james-project/pull/2188 For James Helm Chart, the current version uses kubernetes.io/ingress.class annotation that has been deprecated. It is encouraged to use ingressClassName instead for Kubernetes v1.18+. --

(james-project) branch master updated: [DOCUMENTATION] Refresh server/features.xml (#2178)

2024-04-07 Thread btellier
This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git The following commit(s) were added to refs/heads/master by this push: new 6a316e53a7 [DOCUMENTATION] Refresh

Re: [PR] [DOCUMENTATION] Refresh server/features.xml [james-project]

2024-04-07 Thread via GitHub
chibenwa merged PR #2178: URL: https://github.com/apache/james-project/pull/2178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: