Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-26 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1503663261 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationBinder.java: ## @@ -19,36 +19,30 @@ package org.apache.james.events;

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-26 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1503637115 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationBinder.java: ## @@ -19,36 +19,30 @@ package org.apache.james.events;

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-26 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1503585953 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationBinder.java: ## @@ -19,36 +19,30 @@ package org.apache.james.events;

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-26 Thread via GitHub
chibenwa commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1502997593 ## event-bus/distributed/src/main/java/org/apache/james/events/KeyRegistrationBinder.java: ## @@ -19,36 +19,30 @@ package org.apache.james.events; +import

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-26 Thread via GitHub
chibenwa commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1502996220 ## event-bus/distributed/src/main/java/org/apache/james/events/EventDispatcher.java: ## @@ -168,18 +178,32 @@ private Mono remoteGroupsDispatch(byte[]

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-23 Thread via GitHub
quantranhong1999 commented on PR #2028: URL: https://github.com/apache/james-project/pull/2028#issuecomment-1961002365 `RabbitMQEventBusTest` is 99% green. (except 1 resilient test) Distributed James can run with the Redis event bus key within IT. Next: build docker image and

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-22 Thread via GitHub
quantranhong1999 commented on PR #2028: URL: https://github.com/apache/james-project/pull/2028#issuecomment-1959198347 TODO next: store notifications' metadata (EventBusId, RegistrationKey) in Redis. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-21 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1497433283 ## event-bus/redis/src/main/java/org/apache/james/events/GroupRegistrationHandler.java: ## @@ -104,68 +105,62 @@ GroupRegistration

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-21 Thread via GitHub
chibenwa commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1497400494 ## event-bus/redis/src/main/java/org/apache/james/events/GroupRegistrationHandler.java: ## @@ -104,68 +105,62 @@ GroupRegistration

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-21 Thread via GitHub
chibenwa commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1497401126 ## event-bus/redis/src/main/java/org/apache/james/events/GroupRegistrationHandler.java: ## @@ -104,68 +105,62 @@ GroupRegistration

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-21 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1497367581 ## event-bus/redis/src/main/java/org/apache/james/events/GroupRegistrationHandler.java: ## @@ -104,68 +105,62 @@ GroupRegistration

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-20 Thread via GitHub
quantranhong1999 commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1496801126 ## event-bus/redis/src/main/java/org/apache/james/events/KeyReconnectionHandler.java: ## @@ -0,0 +1,67 @@

Re: [PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-20 Thread via GitHub
chibenwa commented on code in PR #2028: URL: https://github.com/apache/james-project/pull/2028#discussion_r1496397813 ## event-bus/redis/src/main/java/org/apache/james/events/KeyReconnectionHandler.java: ## @@ -0,0 +1,67 @@

[PR] [WIP] JAMES 3996 Redis event bus POC [james-project]

2024-02-20 Thread via GitHub
quantranhong1999 opened a new pull request, #2028: URL: https://github.com/apache/james-project/pull/2028 WIP: not much yet, mostly trying Redis features related to our event bus use case. So far it seems for group registration, Redis Streams would be a good fit: - at least once