Re: [PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
baikjy0215 commented on PR #2188: URL: https://github.com/apache/james-project/pull/2188#issuecomment-2041619242 Sure, it would be better to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
chibenwa commented on PR #2188: URL: https://github.com/apache/james-project/pull/2188#issuecomment-2041501887 Shall we remove ``` kubernetes.io/ingress.class: nginx ``` By default? -- This is an automated message from the Apache Git Service. To respond to the

[PR] Added ingressClassName support for k8s ingress [james-project]

2024-04-07 Thread via GitHub
baikjy0215 opened a new pull request, #2188: URL: https://github.com/apache/james-project/pull/2188 For James Helm Chart, the current version uses kubernetes.io/ingress.class annotation that has been deprecated. It is encouraged to use ingressClassName instead for Kubernetes v1.18+. --