Arsnael merged PR #2190:
URL: https://github.com/apache/james-project/pull/2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
hungphan227 commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2089783198
Regarding collectList method, until now I am still not 100% sure that we no
longer use DomainImplPostgresConnectionFactory because rls performance test has
not been conducted
hungphan227 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1587172583
##
server/container/guice/postgres-common/src/main/java/org/apache/james/modules/data/PostgresCommonModule.java:
##
@@ -91,9 +88,15 @@
Arsnael commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1587164583
##
server/container/guice/postgres-common/src/main/java/org/apache/james/modules/data/PostgresCommonModule.java:
##
@@ -91,9 +88,15 @@
Arsnael commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2089759121
> one for RLS, one for noRLS
I thought just reusing the same pool for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
vttranlina commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2089734875
> the domain connection is not used anymore (except in some test), and can
probably be removed?
I think yes
> can't we find a way to get rid of the single
Arsnael commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2089489873
So if I understand well, rls enabled or not we use the pool connection
factory, and for things where we need a rls bypass (like some webadmin tasks
for example) we still use the
hungphan227 commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2081885150
> > Yes we can
>
> Can we be 100% sure about that? I have added some tests regarding that for
example cf https://github.com/apache/james-project/pull/2179/files We can
Arsnael commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2081838397
If we remove the collectList(), I want it to be etsted on staging too, so
don't hesitate to run the populate email query task for example with an image
having this
--
This is an
quantranhong1999 commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2081832297
> Yes we can
Can we be 100% sure about that?
I have added some tests regarding that for example cf
https://github.com/apache/james-project/pull/2179/files
We
hungphan227 commented on PR #2190:
URL: https://github.com/apache/james-project/pull/2190#issuecomment-2081828101
> And do this sort out the paging problem?
>
> IE can we remove the very dirty .collectList ?
I you mean this:
```
public Flux
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1578854500
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1578853727
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
chibenwa commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1577842174
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
chibenwa commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1577837899
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
hungphan227 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1577640978
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1576015166
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
hungphan227 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1575631539
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
import
Arsnael commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1575591049
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
import
quantranhong1999 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1574046576
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1574038971
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
import
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1574038456
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
import
quantranhong1999 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1571991600
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/DomainImplPostgresConnectionFactory.java:
##
@@ -31,6 +31,7 @@
hungphan227 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1568191076
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
chibenwa commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1560586100
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PoolBackedPostgresConnectionFactory.java:
##
@@ -0,0 +1,93 @@
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1557132970
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PostgresExecutor.java:
##
@@ -139,19 +156,21 @@ public Mono
hungphan227 commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1557111862
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PostgresExecutor.java:
##
@@ -139,19 +156,21 @@ public Mono
vttranlina commented on code in PR #2190:
URL: https://github.com/apache/james-project/pull/2190#discussion_r1556900671
##
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/utils/PostgresExecutor.java:
##
@@ -139,19 +156,21 @@ public Mono
hungphan227 opened a new pull request, #2190:
URL: https://github.com/apache/james-project/pull/2190
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
29 matches
Mail list logo
