Arsnael merged PR #2179:
URL: https://github.com/apache/james-project/pull/2179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chibenwa commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2040850716
No I did not meant paging as in a UI
I meant paging as in a SQL driver. For instance Cassandra driver fetch a
first page of 5000 items then when necessary to provide you
quantranhong1999 commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2039198484
> If I put, say, 5 users, do I actually encounter the bug?
It does not happen with a small amount of users.
BTW likely this is not paging related bug as we are
chibenwa commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2039190488
If I put, say, 5 users, do I actually encounter the bug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
quantranhong1999 commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2038963198
> My 2 cents is try to reproduce the bug into PGUsersRepositoryTest too.
I succeed in reproducing that indeed.
--
This is an automated message from the Apache Git
chibenwa commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2037404884
> Rethink about it, I think putting .collectList in PG
UsersRepository::listReactive may be a more common fix.
Agreed. THis avoids leaking this everywhere.
My 2 cents
quantranhong1999 commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2037308822
Rethink about it, I think putting `.collectList` in `PG
UsersRepository::listReactive` may be a more common fix.
--
This is an automated message from the Apache Git
quantranhong1999 commented on PR #2179:
URL: https://github.com/apache/james-project/pull/2179#issuecomment-2037234332
> Does adding .publishOn(Schedulers.parrallel()) in PG
UsersRepository::listReactive fixes the issue?
It does not.
--
This is an automated message from the Apache
quantranhong1999 opened a new pull request, #2179:
URL: https://github.com/apache/james-project/pull/2179
Root cause: likely a jooq reactive bug. Likely the query that lists a big
amount of users somehow blocks the jooq thread.
Mitigate fix: `collectList` to await the list users
